* [PATCH 1/2] Add Designated Reviewer (R:) to MAINTAINERS file and add support for it in get_maintainer.pl
2018-04-24 15:56 [PATCH 0/2] Add Designated Reviewer (R:) to MAINTAINERS (plus a test case) Lars Kurth
@ 2018-04-24 15:56 ` Lars Kurth
2018-04-24 15:56 ` [PATCH 2/2] Add Brian Woods as Designated reviewer to AMD IOMMU and AMD SVM Lars Kurth
2018-04-25 15:50 ` [PATCH 0/2] Add Designated Reviewer (R:) to MAINTAINERS (plus a test case) Wei Liu
2 siblings, 0 replies; 5+ messages in thread
From: Lars Kurth @ 2018-04-24 15:56 UTC (permalink / raw)
To: xen-devel
Cc: Lars Kurth, Stefano Stabellini, Wei Liu, George Dunlap,
Andrew Cooper, Ian Jackson, Tim Deegan, Julien Grall, Jan Beulich
The syntax has been copied from the Linux Maintainers file. I moved the following Linux
get_maintainer.pl patches to Xen, fixing up some merge issues (and a bug).
The get_maintainer.pl changes were based on the following git commits
* https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/scripts/get_maintainer.pl?id=
* c1c3f2c906e35bcb6e4cdf5b8e077660fead14fe
* 4f07510df2e8c47fd65b8ffaaf6c5d334d59d598
I also removed code related to
P: Person (obsolete)
which is in the Linux MAINTAINER's file, but not ours. I may not have
caught all instances though.
I have tested on a number of files using mock entries in MAINTAINERS
using ./scripts/get_maintainer.pl -f ...
I also tested --nor to disable the support and it worked as expected.
Signed-off-by: Lars Kurth <lars.kurth@citrix.com>
---
MAINTAINERS | 2 ++
scripts/get_maintainer.pl | 24 +++++++++++-------------
2 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index bbda4b9f43..cc1fdc013f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -60,6 +60,8 @@ appropriate branch.
Descriptions of section entries:
M: Mail patches to: FullName <address@domain>
+ R: Designated reviewer: FullName <address@domain>
+ These reviewers should be CCed on patches.
L: Mailing list that is relevant to this area
W: Web-page with status/info
T: SCM tree type and location. Type is one of: git, hg, quilt, stgit.
diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 3fb1ad4b69..d528da738c 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -21,6 +21,7 @@ my $xen_path = "./";
my $email = 1;
my $email_usename = 1;
my $email_maintainer = 1;
+my $email_reviewer = 1;
my $email_list = 1;
my $email_subscriber_list = 0;
my $email_git_penguin_chiefs = 0;
@@ -199,6 +200,7 @@ if (!GetOptions(
'mailmap!' => \$email_use_mailmap,
'drop_the_rest_supporter!' => \$email_drop_the_rest_supporter_if_supporter_found,
'm!' => \$email_maintainer,
+ 'r!' => \$email_reviewer,
'n!' => \$email_usename,
'l!' => \$email_list,
's!' => \$email_subscriber_list,
@@ -257,7 +259,8 @@ if ($sections) {
}
if ($email &&
- ($email_maintainer + $email_list + $email_subscriber_list +
+ ($email_maintainer + $email_reviewer +
+ $email_list + $email_subscriber_list +
$email_git + $email_git_penguin_chiefs + $email_git_blame) == 0) {
die "$P: Please select at least 1 email option\n";
}
@@ -791,6 +794,7 @@ MAINTAINER field selection options:
--hg-since => hg history to use (default: $email_hg_since)
--interactive => display a menu (mostly useful if used with the --git option)
--m => include maintainer(s) if any
+ --r => include reviewer(s) if any
--n => include name 'Full Name <addr\@domain.tld>'
--l => include list(s) if any
--s => include subscriber only list(s) if any
@@ -817,7 +821,7 @@ Other options:
--help => show this help information
Default options:
- [--email --nogit --git-fallback --m --n --l --multiline -pattern-depth=0
+ [--email --nogit --git-fallback --m --r --n --l --multiline -pattern-depth=0
--remove-duplicates --rolestats]
Notes:
@@ -1080,21 +1084,15 @@ sub add_categories {
}
} elsif ($ptype eq "M") {
my ($name, $address) = parse_email($pvalue);
- if ($name eq "") {
- if ($i > 0) {
- my $tv = $typevalue[$i - 1];
- if ($tv =~ m/^([A-Z]):\s*(.*)/) {
- if ($1 eq "P") {
- $name = $2;
- $pvalue = format_email($name, $address, $email_usename);
- }
- }
- }
- }
if ($email_maintainer) {
my $role = get_maintainer_role($i);
push_email_addresses($pvalue, $role);
}
+ } elsif ($ptype eq "R") {
+ my ($name, $address) = parse_email($pvalue);
+ if ($email_reviewer) {
+ push_email_addresses($pvalue, 'reviewer');
+ }
} elsif ($ptype eq "T") {
push(@scm, $pvalue);
} elsif ($ptype eq "W") {
--
2.13.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/2] Add Brian Woods as Designated reviewer to AMD IOMMU and AMD SVM
2018-04-24 15:56 [PATCH 0/2] Add Designated Reviewer (R:) to MAINTAINERS (plus a test case) Lars Kurth
2018-04-24 15:56 ` [PATCH 1/2] Add Designated Reviewer (R:) to MAINTAINERS file and add support for it in get_maintainer.pl Lars Kurth
@ 2018-04-24 15:56 ` Lars Kurth
2018-04-24 16:20 ` Brian Woods
2018-04-25 15:50 ` [PATCH 0/2] Add Designated Reviewer (R:) to MAINTAINERS (plus a test case) Wei Liu
2 siblings, 1 reply; 5+ messages in thread
From: Lars Kurth @ 2018-04-24 15:56 UTC (permalink / raw)
To: xen-devel
Cc: Lars Kurth, Stefano Stabellini, Wei Liu, George Dunlap,
Andrew Cooper, Ian Jackson, Tim Deegan, Julien Grall, Jan Beulich,
Brian Woods
This was discussed in an IRC discussion post the April x86 meeting.
Signed-off-by: Lars Kurth <lars.kurth@citrix.com>
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index cc1fdc013f..fab76b0af4 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -144,12 +144,14 @@ F: tools/libacpi/
AMD IOMMU
M: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
+R: Brian Woods <brian.woods@amd.com>
S: Maintained
F: xen/drivers/passthrough/amd/
AMD SVM
M: Boris Ostrovsky <boris.ostrovsky@oracle.com>
M: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
+R: Brian Woods <brian.woods@amd.com>
S: Supported
F: xen/arch/x86/hvm/svm/
F: xen/arch/x86/cpu/vpmu_amd.c
--
2.13.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 0/2] Add Designated Reviewer (R:) to MAINTAINERS (plus a test case)
2018-04-24 15:56 [PATCH 0/2] Add Designated Reviewer (R:) to MAINTAINERS (plus a test case) Lars Kurth
2018-04-24 15:56 ` [PATCH 1/2] Add Designated Reviewer (R:) to MAINTAINERS file and add support for it in get_maintainer.pl Lars Kurth
2018-04-24 15:56 ` [PATCH 2/2] Add Brian Woods as Designated reviewer to AMD IOMMU and AMD SVM Lars Kurth
@ 2018-04-25 15:50 ` Wei Liu
2 siblings, 0 replies; 5+ messages in thread
From: Wei Liu @ 2018-04-25 15:50 UTC (permalink / raw)
To: Lars Kurth
Cc: Stefano Stabellini, Wei Liu, George Dunlap, Andrew Cooper,
Ian Jackson, Tim Deegan, Julien Grall, Jan Beulich, xen-devel,
Brian Woods
On Tue, Apr 24, 2018 at 04:56:21PM +0100, Lars Kurth wrote:
> This follows up from a conversation after the April x86 community call, in which I had
> the following action: Lars to propose fixing CC issue in xen.git:MAINTAINERS copying
> the R section entries from Linux.git:MAINTAINERS (will need changes to
> get_maintainers.pl also)
>
> Lars Kurth (2):
> Add Designated Reviewer (R:) to MAINTAINERS file and add support for
> it in get_maintainer.pl
> Add Brian Woods as Designated reviewer to AMD IOMMU and AMD SVM
Acked-by: Wei Liu <wei.liu2@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread