From: Kalle Valo <kvalo@codeaurora.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Amitkumar Karwar <amit.karwar@redpinesignals.com>,
Prameela Rani Garnepudi <prameela.j04cs@gmail.com>,
Karun Eagalapati <karun256@gmail.com>,
Siva Rebbagondla <siva.rebbagondla@redpinesignals.com>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [v2] rsi: remove unecessary PTR_ALIGN()s
Date: Tue, 24 Apr 2018 17:24:47 +0000 [thread overview]
Message-ID: <20180424172447.D1A0360131@smtp.codeaurora.org> (raw)
In-Reply-To: <20180406083717.GA21857@mwanda>
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> The issue here is that we allocate "data" and then set
> "data = PTR_ALIGN(data, 8);" and then we free the aligned pointer
> instead of the original pointer.
>
> kmalloc() pointers are already ARCH_SLAB_MINALIGN aligned which is 8 or
> more on everything except certain Xtensa variants. We decided that if
> the Xtensa people ever notice a bug here then we'll tell them the bug is
> on their side. ;)
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Patch applied to wireless-drivers-next.git, thanks.
350fcdb83457 rsi: remove unecessary PTR_ALIGN()s
--
https://patchwork.kernel.org/patch/10325781/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Amitkumar Karwar <amit.karwar@redpinesignals.com>,
Prameela Rani Garnepudi <prameela.j04cs@gmail.com>,
Karun Eagalapati <karun256@gmail.com>,
Siva Rebbagondla <siva.rebbagondla@redpinesignals.com>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [v2] rsi: remove unecessary PTR_ALIGN()s
Date: Tue, 24 Apr 2018 17:24:47 +0000 (UTC) [thread overview]
Message-ID: <20180424172447.D1A0360131@smtp.codeaurora.org> (raw)
In-Reply-To: <20180406083717.GA21857@mwanda>
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> The issue here is that we allocate "data" and then set
> "data = PTR_ALIGN(data, 8);" and then we free the aligned pointer
> instead of the original pointer.
>
> kmalloc() pointers are already ARCH_SLAB_MINALIGN aligned which is 8 or
> more on everything except certain Xtensa variants. We decided that if
> the Xtensa people ever notice a bug here then we'll tell them the bug is
> on their side. ;)
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Patch applied to wireless-drivers-next.git, thanks.
350fcdb83457 rsi: remove unecessary PTR_ALIGN()s
--
https://patchwork.kernel.org/patch/10325781/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2018-04-24 17:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-05 11:23 [PATCH] rsi: Free the unaligned pointer Dan Carpenter
2018-04-05 11:23 ` Dan Carpenter
2018-04-05 11:30 ` Johannes Berg
2018-04-05 11:30 ` Johannes Berg
2018-04-05 11:39 ` Dan Carpenter
2018-04-05 11:39 ` Dan Carpenter
2018-04-05 11:41 ` Dan Carpenter
2018-04-05 11:41 ` Dan Carpenter
2018-04-05 11:46 ` Johannes Berg
2018-04-05 11:46 ` Johannes Berg
2018-04-05 12:23 ` Kalle Valo
2018-04-05 12:23 ` Kalle Valo
2018-04-06 8:37 ` [PATCH v2] rsi: remove unecessary PTR_ALIGN()s Dan Carpenter
2018-04-06 8:37 ` Dan Carpenter
2018-04-06 8:45 ` Arend van Spriel
2018-04-06 8:45 ` Arend van Spriel
2018-04-06 9:01 ` Kalle Valo
2018-04-06 9:01 ` Kalle Valo
2018-04-24 17:24 ` Kalle Valo [this message]
2018-04-24 17:24 ` [v2] " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180424172447.D1A0360131@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=amit.karwar@redpinesignals.com \
--cc=dan.carpenter@oracle.com \
--cc=karun256@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=prameela.j04cs@gmail.com \
--cc=siva.rebbagondla@redpinesignals.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.