* [PATCH] drm: Don't EXPORT drm_add/reset_display_info
@ 2018-04-24 14:22 Daniel Vetter
2018-04-24 17:29 ` Ville Syrjälä
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Vetter @ 2018-04-24 14:22 UTC (permalink / raw)
To: DRI Development; +Cc: Daniel Vetter, Keith Packard, Daniel Vetter
Only used within drm.ko, no need to tempt drivers.
Cc: Keith Packard <keithp@keithp.com>
Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/drm_crtc_internal.h | 2 ++
drivers/gpu/drm/drm_edid.c | 2 --
include/drm/drm_edid.h | 2 --
3 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/drm_crtc_internal.h b/drivers/gpu/drm/drm_crtc_internal.h
index 3c2b82865ad2..5d307b23a4e6 100644
--- a/drivers/gpu/drm/drm_crtc_internal.h
+++ b/drivers/gpu/drm/drm_crtc_internal.h
@@ -220,3 +220,5 @@ int drm_mode_page_flip_ioctl(struct drm_device *dev,
/* drm_edid.c */
void drm_mode_fixup_1366x768(struct drm_display_mode *mode);
+void drm_reset_display_info(struct drm_connector *connector);
+u32 drm_add_display_info(struct drm_connector *connector, const struct edid *edid);
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index 134069f36482..61dd9a2fbe5b 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -4454,7 +4454,6 @@ drm_reset_display_info(struct drm_connector *connector)
info->non_desktop = 0;
}
-EXPORT_SYMBOL_GPL(drm_reset_display_info);
u32 drm_add_display_info(struct drm_connector *connector, const struct edid *edid)
{
@@ -4538,7 +4537,6 @@ u32 drm_add_display_info(struct drm_connector *connector, const struct edid *edi
info->color_formats |= DRM_COLOR_FORMAT_YCRCB422;
return quirks;
}
-EXPORT_SYMBOL_GPL(drm_add_display_info);
static int validate_displayid(u8 *displayid, int length, int idx)
{
diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h
index 8d89a9c3748d..b25d12ef120a 100644
--- a/include/drm/drm_edid.h
+++ b/include/drm/drm_edid.h
@@ -465,8 +465,6 @@ struct edid *drm_get_edid(struct drm_connector *connector,
struct edid *drm_get_edid_switcheroo(struct drm_connector *connector,
struct i2c_adapter *adapter);
struct edid *drm_edid_duplicate(const struct edid *edid);
-void drm_reset_display_info(struct drm_connector *connector);
-u32 drm_add_display_info(struct drm_connector *connector, const struct edid *edid);
int drm_add_edid_modes(struct drm_connector *connector, struct edid *edid);
u8 drm_match_cea_mode(const struct drm_display_mode *to_match);
--
2.16.2
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm: Don't EXPORT drm_add/reset_display_info
2018-04-24 14:22 [PATCH] drm: Don't EXPORT drm_add/reset_display_info Daniel Vetter
@ 2018-04-24 17:29 ` Ville Syrjälä
2018-04-24 21:30 ` Daniel Vetter
0 siblings, 1 reply; 3+ messages in thread
From: Ville Syrjälä @ 2018-04-24 17:29 UTC (permalink / raw)
To: Daniel Vetter; +Cc: Daniel Vetter, Keith Packard, DRI Development
On Tue, Apr 24, 2018 at 04:22:42PM +0200, Daniel Vetter wrote:
> Only used within drm.ko, no need to tempt drivers.
>
> Cc: Keith Packard <keithp@keithp.com>
> Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/drm_crtc_internal.h | 2 ++
> drivers/gpu/drm/drm_edid.c | 2 --
> include/drm/drm_edid.h | 2 --
> 3 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_crtc_internal.h b/drivers/gpu/drm/drm_crtc_internal.h
> index 3c2b82865ad2..5d307b23a4e6 100644
> --- a/drivers/gpu/drm/drm_crtc_internal.h
> +++ b/drivers/gpu/drm/drm_crtc_internal.h
> @@ -220,3 +220,5 @@ int drm_mode_page_flip_ioctl(struct drm_device *dev,
>
> /* drm_edid.c */
> void drm_mode_fixup_1366x768(struct drm_display_mode *mode);
> +void drm_reset_display_info(struct drm_connector *connector);
> +u32 drm_add_display_info(struct drm_connector *connector, const struct edid *edid);
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index 134069f36482..61dd9a2fbe5b 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -4454,7 +4454,6 @@ drm_reset_display_info(struct drm_connector *connector)
>
> info->non_desktop = 0;
> }
> -EXPORT_SYMBOL_GPL(drm_reset_display_info);
>
> u32 drm_add_display_info(struct drm_connector *connector, const struct edid *edid)
> {
> @@ -4538,7 +4537,6 @@ u32 drm_add_display_info(struct drm_connector *connector, const struct edid *edi
> info->color_formats |= DRM_COLOR_FORMAT_YCRCB422;
> return quirks;
> }
> -EXPORT_SYMBOL_GPL(drm_add_display_info);
>
> static int validate_displayid(u8 *displayid, int length, int idx)
> {
> diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h
> index 8d89a9c3748d..b25d12ef120a 100644
> --- a/include/drm/drm_edid.h
> +++ b/include/drm/drm_edid.h
> @@ -465,8 +465,6 @@ struct edid *drm_get_edid(struct drm_connector *connector,
> struct edid *drm_get_edid_switcheroo(struct drm_connector *connector,
> struct i2c_adapter *adapter);
> struct edid *drm_edid_duplicate(const struct edid *edid);
> -void drm_reset_display_info(struct drm_connector *connector);
> -u32 drm_add_display_info(struct drm_connector *connector, const struct edid *edid);
> int drm_add_edid_modes(struct drm_connector *connector, struct edid *edid);
>
> u8 drm_match_cea_mode(const struct drm_display_mode *to_match);
> --
> 2.16.2
--
Ville Syrjälä
Intel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm: Don't EXPORT drm_add/reset_display_info
2018-04-24 17:29 ` Ville Syrjälä
@ 2018-04-24 21:30 ` Daniel Vetter
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2018-04-24 21:30 UTC (permalink / raw)
To: Ville Syrjälä
Cc: Daniel Vetter, Keith Packard, DRI Development, Daniel Vetter
On Tue, Apr 24, 2018 at 08:29:36PM +0300, Ville Syrjälä wrote:
> On Tue, Apr 24, 2018 at 04:22:42PM +0200, Daniel Vetter wrote:
> > Only used within drm.ko, no need to tempt drivers.
> >
> > Cc: Keith Packard <keithp@keithp.com>
> > Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Thanks for review, applied.
-Daniel
>
> > ---
> > drivers/gpu/drm/drm_crtc_internal.h | 2 ++
> > drivers/gpu/drm/drm_edid.c | 2 --
> > include/drm/drm_edid.h | 2 --
> > 3 files changed, 2 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/drm_crtc_internal.h b/drivers/gpu/drm/drm_crtc_internal.h
> > index 3c2b82865ad2..5d307b23a4e6 100644
> > --- a/drivers/gpu/drm/drm_crtc_internal.h
> > +++ b/drivers/gpu/drm/drm_crtc_internal.h
> > @@ -220,3 +220,5 @@ int drm_mode_page_flip_ioctl(struct drm_device *dev,
> >
> > /* drm_edid.c */
> > void drm_mode_fixup_1366x768(struct drm_display_mode *mode);
> > +void drm_reset_display_info(struct drm_connector *connector);
> > +u32 drm_add_display_info(struct drm_connector *connector, const struct edid *edid);
> > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> > index 134069f36482..61dd9a2fbe5b 100644
> > --- a/drivers/gpu/drm/drm_edid.c
> > +++ b/drivers/gpu/drm/drm_edid.c
> > @@ -4454,7 +4454,6 @@ drm_reset_display_info(struct drm_connector *connector)
> >
> > info->non_desktop = 0;
> > }
> > -EXPORT_SYMBOL_GPL(drm_reset_display_info);
> >
> > u32 drm_add_display_info(struct drm_connector *connector, const struct edid *edid)
> > {
> > @@ -4538,7 +4537,6 @@ u32 drm_add_display_info(struct drm_connector *connector, const struct edid *edi
> > info->color_formats |= DRM_COLOR_FORMAT_YCRCB422;
> > return quirks;
> > }
> > -EXPORT_SYMBOL_GPL(drm_add_display_info);
> >
> > static int validate_displayid(u8 *displayid, int length, int idx)
> > {
> > diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h
> > index 8d89a9c3748d..b25d12ef120a 100644
> > --- a/include/drm/drm_edid.h
> > +++ b/include/drm/drm_edid.h
> > @@ -465,8 +465,6 @@ struct edid *drm_get_edid(struct drm_connector *connector,
> > struct edid *drm_get_edid_switcheroo(struct drm_connector *connector,
> > struct i2c_adapter *adapter);
> > struct edid *drm_edid_duplicate(const struct edid *edid);
> > -void drm_reset_display_info(struct drm_connector *connector);
> > -u32 drm_add_display_info(struct drm_connector *connector, const struct edid *edid);
> > int drm_add_edid_modes(struct drm_connector *connector, struct edid *edid);
> >
> > u8 drm_match_cea_mode(const struct drm_display_mode *to_match);
> > --
> > 2.16.2
>
> --
> Ville Syrjälä
> Intel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-04-24 21:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-24 14:22 [PATCH] drm: Don't EXPORT drm_add/reset_display_info Daniel Vetter
2018-04-24 17:29 ` Ville Syrjälä
2018-04-24 21:30 ` Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.