All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/radeon: Change the default to PCI on PowerPC
@ 2018-04-24 19:55 Mathieu Malaterre
  2018-04-24 19:56 ` Mathieu Malaterre
  2018-04-25  9:49   ` Michel Dänzer
  0 siblings, 2 replies; 4+ messages in thread
From: Mathieu Malaterre @ 2018-04-24 19:55 UTC (permalink / raw)
  To: Christian König
  Cc: Mathieu Malaterre, Alex Deucher, David (ChunMing) Zhou,
	David Airlie, amd-gfx, dri-devel, linux-kernel

AGP mode is unstable on PowerPC. Symptoms are generally of the form:

[ 1228.795711] radeon 0000:00:10.0: ring 0 stalled for more than 10240msec

Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Mathieu Malaterre <malat@debian.org>
---
 drivers/gpu/drm/radeon/radeon_drv.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c
index b28288a781ef..2a7977a23b31 100644
--- a/drivers/gpu/drm/radeon/radeon_drv.c
+++ b/drivers/gpu/drm/radeon/radeon_drv.c
@@ -168,7 +168,12 @@ int radeon_no_wb;
 int radeon_modeset = -1;
 int radeon_dynclks = -1;
 int radeon_r4xx_atom = 0;
+#ifdef __powerpc__
+/* Default to PCI on PowerPC (fdo #95017) */
+int radeon_agpmode = -1;
+#else
 int radeon_agpmode = 0;
+#endif
 int radeon_vram_limit = 0;
 int radeon_gart_size = -1; /* auto */
 int radeon_benchmarking = 0;
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] drm/radeon: Change the default to PCI on PowerPC
  2018-04-24 19:55 [PATCH] drm/radeon: Change the default to PCI on PowerPC Mathieu Malaterre
@ 2018-04-24 19:56 ` Mathieu Malaterre
  2018-04-25  9:49   ` Michel Dänzer
  1 sibling, 0 replies; 4+ messages in thread
From: Mathieu Malaterre @ 2018-04-24 19:56 UTC (permalink / raw)
  To: Christian König
  Cc: Alex Deucher, David (ChunMing) Zhou, David Airlie, amd-gfx,
	dri-devel, LKML

For reference:

https://lists.freedesktop.org/archives/mesa-dev/2016-May/115453.html

2018-04-24 21:55 GMT+02:00 Mathieu Malaterre <malat@debian.org>:
> AGP mode is unstable on PowerPC. Symptoms are generally of the form:
>
> [ 1228.795711] radeon 0000:00:10.0: ring 0 stalled for more than 10240msec
>
> Reviewed-by: Christian König <christian.koenig@amd.com>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> ---
>  drivers/gpu/drm/radeon/radeon_drv.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c
> index b28288a781ef..2a7977a23b31 100644
> --- a/drivers/gpu/drm/radeon/radeon_drv.c
> +++ b/drivers/gpu/drm/radeon/radeon_drv.c
> @@ -168,7 +168,12 @@ int radeon_no_wb;
>  int radeon_modeset = -1;
>  int radeon_dynclks = -1;
>  int radeon_r4xx_atom = 0;
> +#ifdef __powerpc__
> +/* Default to PCI on PowerPC (fdo #95017) */
> +int radeon_agpmode = -1;
> +#else
>  int radeon_agpmode = 0;
> +#endif
>  int radeon_vram_limit = 0;
>  int radeon_gart_size = -1; /* auto */
>  int radeon_benchmarking = 0;
> --
> 2.11.0
>

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] drm/radeon: Change the default to PCI on PowerPC
  2018-04-24 19:55 [PATCH] drm/radeon: Change the default to PCI on PowerPC Mathieu Malaterre
@ 2018-04-25  9:49   ` Michel Dänzer
  2018-04-25  9:49   ` Michel Dänzer
  1 sibling, 0 replies; 4+ messages in thread
From: Michel Dänzer @ 2018-04-25  9:49 UTC (permalink / raw)
  To: Mathieu Malaterre, Christian König
  Cc: Alex Deucher, amd-gfx, linux-kernel, dri-devel

On 2018-04-24 09:55 PM, Mathieu Malaterre wrote:
> AGP mode is unstable on PowerPC. Symptoms are generally of the form:
> 
> [ 1228.795711] radeon 0000:00:10.0: ring 0 stalled for more than 10240msec
> 
> Reviewed-by: Christian König <christian.koenig@amd.com>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> ---
>  drivers/gpu/drm/radeon/radeon_drv.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c
> index b28288a781ef..2a7977a23b31 100644
> --- a/drivers/gpu/drm/radeon/radeon_drv.c
> +++ b/drivers/gpu/drm/radeon/radeon_drv.c
> @@ -168,7 +168,12 @@ int radeon_no_wb;
>  int radeon_modeset = -1;
>  int radeon_dynclks = -1;
>  int radeon_r4xx_atom = 0;
> +#ifdef __powerpc__
> +/* Default to PCI on PowerPC (fdo #95017) */
> +int radeon_agpmode = -1;
> +#else
>  int radeon_agpmode = 0;
> +#endif
>  int radeon_vram_limit = 0;
>  int radeon_gart_size = -1; /* auto */
>  int radeon_benchmarking = 0;
> 

Pushed to amd-staging-drm-next, thanks!


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] drm/radeon: Change the default to PCI on PowerPC
@ 2018-04-25  9:49   ` Michel Dänzer
  0 siblings, 0 replies; 4+ messages in thread
From: Michel Dänzer @ 2018-04-25  9:49 UTC (permalink / raw)
  To: Mathieu Malaterre, Christian König
  Cc: David (ChunMing) Zhou, linux-kernel, dri-devel, amd-gfx,
	Alex Deucher

On 2018-04-24 09:55 PM, Mathieu Malaterre wrote:
> AGP mode is unstable on PowerPC. Symptoms are generally of the form:
> 
> [ 1228.795711] radeon 0000:00:10.0: ring 0 stalled for more than 10240msec
> 
> Reviewed-by: Christian König <christian.koenig@amd.com>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> ---
>  drivers/gpu/drm/radeon/radeon_drv.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c
> index b28288a781ef..2a7977a23b31 100644
> --- a/drivers/gpu/drm/radeon/radeon_drv.c
> +++ b/drivers/gpu/drm/radeon/radeon_drv.c
> @@ -168,7 +168,12 @@ int radeon_no_wb;
>  int radeon_modeset = -1;
>  int radeon_dynclks = -1;
>  int radeon_r4xx_atom = 0;
> +#ifdef __powerpc__
> +/* Default to PCI on PowerPC (fdo #95017) */
> +int radeon_agpmode = -1;
> +#else
>  int radeon_agpmode = 0;
> +#endif
>  int radeon_vram_limit = 0;
>  int radeon_gart_size = -1; /* auto */
>  int radeon_benchmarking = 0;
> 

Pushed to amd-staging-drm-next, thanks!


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-04-25  9:49 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-24 19:55 [PATCH] drm/radeon: Change the default to PCI on PowerPC Mathieu Malaterre
2018-04-24 19:56 ` Mathieu Malaterre
2018-04-25  9:49 ` Michel Dänzer
2018-04-25  9:49   ` Michel Dänzer

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.