All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: RaghuramChary.Jallipalli@microchip.com
Cc: davem@davemloft.net, netdev@vger.kernel.org,
	UNGLinuxDriver@microchip.com, Woojung.Huh@microchip.com
Subject: Re: [PATCH net-next] lan78xx: Lan7801 Support for Fixed PHY
Date: Wed, 25 Apr 2018 14:39:06 +0200	[thread overview]
Message-ID: <20180425123906.GA13486@lunn.ch> (raw)
In-Reply-To: <0573C9D4B793EF43BF95221F2F4CC85153DA07@CHN-SV-EXMX06.mchp-main.com>

> OK. Will modify to netdev_dbg()
>  
> > > +			dev->interface = PHY_INTERFACE_MODE_RGMII;
> > > +			dev->fixedphy = phydev;
> > 
> > You can use
> > 
> > if (!phy_is_pseudo_fixed_link(phydev))
> > 
> > to determine is a PHY is a fixed phy. I think you can then do without
> > dev->fixedphy.
> > 
> dev->fixedphy stores the fixed phydev, which will be passed to the 
> fixed_phy_unregister routine , so I think phy_is_pseudo_fixed_link check is not necessary.

I'm saying you can get rid of dev->fixedphy, and just use
netdev->phydev, and phy_is_pseudo_fixed_link(netdev->phydev)

	Andrew

  reply	other threads:[~2018-04-25 12:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-23  4:46 [PATCH net-next] lan78xx: Lan7801 Support for Fixed PHY Raghuram Chary J
2018-04-23 12:42 ` Andrew Lunn
2018-04-25  5:21   ` RaghuramChary.Jallipalli
2018-04-25 12:39     ` Andrew Lunn [this message]
2018-04-25 17:04       ` RaghuramChary.Jallipalli
2018-04-25 17:36         ` Florian Fainelli
2018-04-25 19:05           ` RaghuramChary.Jallipalli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180425123906.GA13486@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=RaghuramChary.Jallipalli@microchip.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=Woojung.Huh@microchip.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.