From: Omar Sandoval <osandov@osandov.com>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>,
Linux Block Layer Mailinglist <linux-block@vger.kernel.org>
Subject: Re: [PATCH blktests 3/3] nvme: add a regression test for UUID ns descriptops
Date: Wed, 25 Apr 2018 08:58:39 -0700 [thread overview]
Message-ID: <20180425155839.GC30070@vader> (raw)
In-Reply-To: <20180425155211.o4bwaryvo3lo6l4i@linux-x5ow.site>
On Wed, Apr 25, 2018 at 09:52:12AM -0600, Johannes Thumshirn wrote:
> On Wed, Apr 25, 2018 at 08:30:36AM -0700, Omar Sandoval wrote:
> [...]
> > The TODO comment was leftover here, I removed it.
>
> Oops sorry.
I should probably rename it `make check` and have it check for leftover
TODO comments as well.
> > > +DESCRIPTION="Test nvme and nvmet UUID NS descriptors"
> > > +
> > > +QUICK=1
> > > +
> > > +requires() {
> > > + _have_program nvme && _have_module nvme-loop && _have_module loop \
> > > + && _have_configfs
> > > +}
> > > +
> > > +_find_nvme_loop_dev() {
> > > + for dev in /sys/block/nvme*; do
> > > + dev="$(basename $dev)"
> >
> > There's some missing quoting around "$dev" here. There's also some more
> > missing quoting, `make shellcheck` will catch this sort of thing.
>
> Thanks, I'll try to not forget running shellcheck. Maybe we should set
> up travis on github to catch this?
Good idea. I need to clean up some other errors that have snuck in.
WARNING: multiple messages have this Message-ID (diff)
From: osandov@osandov.com (Omar Sandoval)
Subject: [PATCH blktests 3/3] nvme: add a regression test for UUID ns descriptops
Date: Wed, 25 Apr 2018 08:58:39 -0700 [thread overview]
Message-ID: <20180425155839.GC30070@vader> (raw)
In-Reply-To: <20180425155211.o4bwaryvo3lo6l4i@linux-x5ow.site>
On Wed, Apr 25, 2018@09:52:12AM -0600, Johannes Thumshirn wrote:
> On Wed, Apr 25, 2018@08:30:36AM -0700, Omar Sandoval wrote:
> [...]
> > The TODO comment was leftover here, I removed it.
>
> Oops sorry.
I should probably rename it `make check` and have it check for leftover
TODO comments as well.
> > > +DESCRIPTION="Test nvme and nvmet UUID NS descriptors"
> > > +
> > > +QUICK=1
> > > +
> > > +requires() {
> > > + _have_program nvme && _have_module nvme-loop && _have_module loop \
> > > + && _have_configfs
> > > +}
> > > +
> > > +_find_nvme_loop_dev() {
> > > + for dev in /sys/block/nvme*; do
> > > + dev="$(basename $dev)"
> >
> > There's some missing quoting around "$dev" here. There's also some more
> > missing quoting, `make shellcheck` will catch this sort of thing.
>
> Thanks, I'll try to not forget running shellcheck. Maybe we should set
> up travis on github to catch this?
Good idea. I need to clean up some other errors that have snuck in.
next prev parent reply other threads:[~2018-04-25 15:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 16:12 [PATCH blktests 1/3] nvme: fix counting available ports Johannes Thumshirn
2018-04-24 16:12 ` Johannes Thumshirn
2018-04-24 16:12 ` [PATCH blktests 2/3] nvme: add uuid parameter to _create_nvmet_subsystem Johannes Thumshirn
2018-04-24 16:12 ` Johannes Thumshirn
2018-04-24 16:12 ` [PATCH blktests 3/3] nvme: add a regression test for UUID ns descriptops Johannes Thumshirn
2018-04-24 16:12 ` Johannes Thumshirn
2018-04-25 15:30 ` Omar Sandoval
2018-04-25 15:30 ` Omar Sandoval
2018-04-25 15:52 ` Johannes Thumshirn
2018-04-25 15:52 ` Johannes Thumshirn
2018-04-25 15:58 ` Omar Sandoval [this message]
2018-04-25 15:58 ` Omar Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180425155839.GC30070@vader \
--to=osandov@osandov.com \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.