All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@linux.intel.com>
To: speck@linutronix.de
Subject: [MODERATED] Re: [PATCH 1/6] Patch 1
Date: Wed, 25 Apr 2018 11:11:52 -0700	[thread overview]
Message-ID: <20180425181152.GK14273@tassilo.jf.intel.com> (raw)
In-Reply-To: <alpine.LFD.2.21.999.1804251050570.31078@i7.lan>

On Wed, Apr 25, 2018 at 11:00:57AM -0700, speck for Linus Torvalds wrote:
> 
> 
> On Wed, 25 Apr 2018, speck for Andi Kleen wrote:
> > 
> > If the MAX_PA-1 bit is inverted the address is not pointing to MMIO space anymore,
> > but likely to some real cached memory.
> 
> What the hell are you blathering about?
> 
> This is all only about the SWAP ENTRY. 

Ok. My patchkit handles both mprotect and swap entries. You're right 
we don't need it for swap entries and could use the inversion
there.

I was talking about mprotect though.

We need to handle mprotect (and potentially also non lazy fault mmap PROT_NONE)
because if we're in a guest setting something to PROT_NONE allows to bypass EPT temporarily, so you could suddenly see the values of some other guest pages.

What's your opinion on that case?

-Andi

  reply	other threads:[~2018-04-25 18:11 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-25  3:29 [MODERATED] [PATCH 1/6] Patch 1 Andi Kleen
2018-04-25 15:51 ` [MODERATED] " Linus Torvalds
2018-04-25 16:06   ` Andi Kleen
2018-04-25 17:25     ` Linus Torvalds
2018-04-25 17:36       ` Andi Kleen
2018-04-25 18:00         ` Linus Torvalds
2018-04-25 18:11           ` Andi Kleen [this message]
2018-04-25 18:26             ` Thomas Gleixner
2018-04-25 18:30             ` [MODERATED] " Linus Torvalds
2018-04-25 18:51               ` Andi Kleen
2018-04-25 20:15                 ` Linus Torvalds
2018-04-25 21:19                   ` Andi Kleen
2018-04-25 22:35                     ` Linus Torvalds
2018-04-25 23:12                       ` Andi Kleen
2018-04-25 23:21                         ` Linus Torvalds
2018-04-25 23:39                           ` Andi Kleen
2018-04-26  3:22                             ` Linus Torvalds
2018-04-26  3:39                               ` Jon Masters
2018-04-26 13:59                           ` Michal Hocko
2018-04-26 17:14                             ` Linus Torvalds
2018-04-27  0:05                               ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180425181152.GK14273@tassilo.jf.intel.com \
    --to=ak@linux.intel.com \
    --cc=speck@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.