From: Andi Kleen <ak@linux.intel.com>
To: speck@linutronix.de
Subject: [MODERATED] Re: [PATCH 1/6] Patch 1
Date: Wed, 25 Apr 2018 11:51:40 -0700 [thread overview]
Message-ID: <20180425185140.GL14273@tassilo.jf.intel.com> (raw)
In-Reply-To: <alpine.LFD.2.21.999.1804251114010.31078@i7.lan>
> - in a virtual environment, the host simply needs to flush its caches
> before entering vmx mode, and now there is nothing sensitive for the
> guest to access. All it can read is its own caches.
This doesn't help unfortunately because it could also leak data inside
the guest. If skipping EPT causes the PA to point to some other page
inside the same guest you can leak that data. And that other page might
be owned by the kernel or by some other process.
If a guest uses most memory in the system that's quite likely.
There was also another case, brought up by Google ChromeOS, where they
control/trust the guest kernel and want to rely on it from accessing
data outside the current guest, so not needing flush mitigations in the VMM.
That one is a bit more dubious, but I guess it's also not completely broken.
> Now, that said, we can have other things we can do to just make it harder
> to mis-use this. In particular, we could fairly easily say:
>
> - PROT_NONE on a shared mapping means that we just flush and unmap all
> the pages *entirely* (we leave the vma alone, and just rely on faulting
> them back in after you set it back to something that isn't PROT_NONE)
It doesn't need to be a shared mapping, can happen with any mapping.
>
> (And yes, I might be missing some detail, but I _really_ hate that
> "special bit" patch. It fundamentally should not be needed).
I don't think anyone likes it, we just couldn't find better solutions.
-Andi
next prev parent reply other threads:[~2018-04-25 18:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-25 3:29 [MODERATED] [PATCH 1/6] Patch 1 Andi Kleen
2018-04-25 15:51 ` [MODERATED] " Linus Torvalds
2018-04-25 16:06 ` Andi Kleen
2018-04-25 17:25 ` Linus Torvalds
2018-04-25 17:36 ` Andi Kleen
2018-04-25 18:00 ` Linus Torvalds
2018-04-25 18:11 ` Andi Kleen
2018-04-25 18:26 ` Thomas Gleixner
2018-04-25 18:30 ` [MODERATED] " Linus Torvalds
2018-04-25 18:51 ` Andi Kleen [this message]
2018-04-25 20:15 ` Linus Torvalds
2018-04-25 21:19 ` Andi Kleen
2018-04-25 22:35 ` Linus Torvalds
2018-04-25 23:12 ` Andi Kleen
2018-04-25 23:21 ` Linus Torvalds
2018-04-25 23:39 ` Andi Kleen
2018-04-26 3:22 ` Linus Torvalds
2018-04-26 3:39 ` Jon Masters
2018-04-26 13:59 ` Michal Hocko
2018-04-26 17:14 ` Linus Torvalds
2018-04-27 0:05 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180425185140.GL14273@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=speck@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.