All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/bridge: cdns: Mark runtime PM operations as maybe unused
Date: Thu, 26 Apr 2018 17:15:03 +0200	[thread overview]
Message-ID: <20180426151503.GG31888@ulmo> (raw)
In-Reply-To: <20180426142103.GD12521@phenom.ffwll.local>


[-- Attachment #1.1: Type: text/plain, Size: 978 bytes --]

On Thu, Apr 26, 2018 at 04:21:04PM +0200, Daniel Vetter wrote:
> On Thu, Apr 26, 2018 at 03:58:53PM +0200, Thierry Reding wrote:
> > From: Thierry Reding <treding@nvidia.com>
> > 
> > Building the driver in a configuration with !PM currently causes a
> > warning about these operations being unused. Mark them as such to shut
> > up the compiler.
> > 
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
> 
> I'd so love if we could use LTO (or at least link time garbage collection
> of functions/heap allocations) instead of tons of #ifdef (even in macros)
> and __maybe_unused.

I had discussed this with Arnd Bergmann a long time ago and neither of
us could figure out a way to make that work in this case, so we agreed
that __maybe_unused was the preferred way forward until somebody would
figure out a better way.

> Patch looks fine itself.
> 
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Thanks, applied to drm-misc-next.

Thierry

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

      reply	other threads:[~2018-04-26 15:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-26 13:58 [PATCH] drm/bridge: cdns: Mark runtime PM operations as maybe unused Thierry Reding
2018-04-26 14:21 ` Daniel Vetter
2018-04-26 15:15   ` Thierry Reding [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180426151503.GG31888@ulmo \
    --to=thierry.reding@gmail.com \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.