From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH v2] nvme: change order of qid and cmdid in completion trace
Date: Thu, 26 Apr 2018 14:41:04 -0600 [thread overview]
Message-ID: <20180426204104.GA3094@localhost.localdomain> (raw)
In-Reply-To: <20180426202515.20206-1-jthumshirn@suse.de>
On Thu, Apr 26, 2018@02:25:15PM -0600, Johannes Thumshirn wrote:
> Keith reported that command submission and command completion
> tracepoints have the order of the cmdid and qid fields swapped.
>
> While it isn't easily possible to change the command submission
> tracepoint, as there is a regression test parsing it in blktests we
> can swap the command completion tracepoint to have the fields aligned.
It's the little things that matter. :)
Thanks, applied to nvme-4.18.
WARNING: multiple messages have this Message-ID (diff)
From: Keith Busch <keith.busch@intel.com>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>,
Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCH v2] nvme: change order of qid and cmdid in completion trace
Date: Thu, 26 Apr 2018 14:41:04 -0600 [thread overview]
Message-ID: <20180426204104.GA3094@localhost.localdomain> (raw)
In-Reply-To: <20180426202515.20206-1-jthumshirn@suse.de>
On Thu, Apr 26, 2018 at 02:25:15PM -0600, Johannes Thumshirn wrote:
> Keith reported that command submission and command completion
> tracepoints have the order of the cmdid and qid fields swapped.
>
> While it isn't easily possible to change the command submission
> tracepoint, as there is a regression test parsing it in blktests we
> can swap the command completion tracepoint to have the fields aligned.
It's the little things that matter. :)
Thanks, applied to nvme-4.18.
next prev parent reply other threads:[~2018-04-26 20:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-26 20:25 [PATCH v2] nvme: change order of qid and cmdid in completion trace Johannes Thumshirn
2018-04-26 20:25 ` Johannes Thumshirn
2018-04-26 20:41 ` Keith Busch [this message]
2018-04-26 20:41 ` Keith Busch
2018-04-27 5:20 ` Christoph Hellwig
2018-04-27 5:20 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180426204104.GA3094@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.