From: Thierry Reding <thierry.reding@gmail.com>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 1/3] usb: xhci: tegra: Prepare for adding runtime PM support
Date: Fri, 27 Apr 2018 12:08:22 +0200 [thread overview]
Message-ID: <20180427100822.GP30388@ulmo> (raw)
In-Reply-To: <1524754750-3633-1-git-send-email-jonathanh@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 844 bytes --]
On Thu, Apr 26, 2018 at 03:59:08PM +0100, Jon Hunter wrote:
> When adding runtime PM support to the Tegra XHCI driver, it is desirable
> to move the function calls to enable the clocks, regulators and PHY from
> the tegra_xusb_probe into the runtime PM handlers. Currently, the
> clocks, regulators and PHY are all enabled before we call
> usb_create_hcd() in tegra_xusb_probe(), however, we cannot call
> pm_runtime_get_sync() at this point because the platform device data is
> not yet initialised. Fortunately, the function usb_create_hcd() can be
> called before we enable the clocks, regulators and PHY and so prepare
> for adding runtime PM support, by moving the call to usb_create_hcd()
> before we enable the hardware.
>
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [V2,1/3] usb: xhci: tegra: Prepare for adding runtime PM support
Date: Fri, 27 Apr 2018 12:08:22 +0200 [thread overview]
Message-ID: <20180427100822.GP30388@ulmo> (raw)
On Thu, Apr 26, 2018 at 03:59:08PM +0100, Jon Hunter wrote:
> When adding runtime PM support to the Tegra XHCI driver, it is desirable
> to move the function calls to enable the clocks, regulators and PHY from
> the tegra_xusb_probe into the runtime PM handlers. Currently, the
> clocks, regulators and PHY are all enabled before we call
> usb_create_hcd() in tegra_xusb_probe(), however, we cannot call
> pm_runtime_get_sync() at this point because the platform device data is
> not yet initialised. Fortunately, the function usb_create_hcd() can be
> called before we enable the clocks, regulators and PHY and so prepare
> for adding runtime PM support, by moving the call to usb_create_hcd()
> before we enable the hardware.
>
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
Acked-by: Thierry Reding <treding@nvidia.com>
next prev parent reply other threads:[~2018-04-27 10:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-26 14:59 [PATCH V2 1/3] usb: xhci: tegra: Prepare for adding runtime PM support Jon Hunter
2018-04-26 14:59 ` Jon Hunter
2018-04-26 14:59 ` [V2,1/3] " Jon Hunter
2018-04-26 14:59 ` [PATCH V2 2/3] usb: xhci: tegra: Add " Jon Hunter
2018-04-26 14:59 ` Jon Hunter
2018-04-26 14:59 ` [V2,2/3] " Jon Hunter
2018-04-27 10:10 ` [PATCH V2 2/3] " Thierry Reding
2018-04-27 10:10 ` [V2,2/3] " Thierry Reding
2018-04-26 14:59 ` [PATCH V2 3/3] usb: xhci: tegra: Add support for managing powergates Jon Hunter
2018-04-26 14:59 ` Jon Hunter
2018-04-26 14:59 ` [V2,3/3] " Jon Hunter
2018-04-27 10:13 ` [PATCH V2 3/3] " Thierry Reding
2018-04-27 10:13 ` [V2,3/3] " Thierry Reding
2018-04-27 10:08 ` Thierry Reding [this message]
2018-04-27 10:08 ` [V2,1/3] usb: xhci: tegra: Prepare for adding runtime PM support Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180427100822.GP30388@ulmo \
--to=thierry.reding@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.