All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] rsi: fix a bug in rsi_hal_key_config()
@ 2018-04-27 11:21 ` Dan Carpenter
  0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2018-04-27 11:21 UTC (permalink / raw)
  To: Kalle Valo, Prameela Rani Garnepudi
  Cc: Amitkumar Karwar, Karun Eagalapati, Siva Rebbagondla,
	linux-wireless, kernel-janitors

Smatch complains that the end of this function is dead code.  I'm pretty
sure that this return needs to be changed to only return on error.

Fixes: 4fd6c4762f37 ("rsi: roaming enhancements")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/net/wireless/rsi/rsi_91x_mac80211.c b/drivers/net/wireless/rsi/rsi_91x_mac80211.c
index 766d874cc6e2..80e7f4f4f188 100644
--- a/drivers/net/wireless/rsi/rsi_91x_mac80211.c
+++ b/drivers/net/wireless/rsi/rsi_91x_mac80211.c
@@ -911,14 +911,14 @@ static int rsi_hal_key_config(struct ieee80211_hw *hw,
 		}
 	}
 
-	return rsi_hal_load_key(adapter->priv,
-				key->key,
-				key->keylen,
-				key_type,
-				key->keyidx,
-				key->cipher,
-				sta_id,
-				vif);
+	status = rsi_hal_load_key(adapter->priv,
+				  key->key,
+				  key->keylen,
+				  key_type,
+				  key->keyidx,
+				  key->cipher,
+				  sta_id,
+				  vif);
 	if (status)
 		return status;
 

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH] rsi: fix a bug in rsi_hal_key_config()
@ 2018-04-27 11:21 ` Dan Carpenter
  0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2018-04-27 11:21 UTC (permalink / raw)
  To: Kalle Valo, Prameela Rani Garnepudi
  Cc: Amitkumar Karwar, Karun Eagalapati, Siva Rebbagondla,
	linux-wireless, kernel-janitors

Smatch complains that the end of this function is dead code.  I'm pretty
sure that this return needs to be changed to only return on error.

Fixes: 4fd6c4762f37 ("rsi: roaming enhancements")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/net/wireless/rsi/rsi_91x_mac80211.c b/drivers/net/wireless/rsi/rsi_91x_mac80211.c
index 766d874cc6e2..80e7f4f4f188 100644
--- a/drivers/net/wireless/rsi/rsi_91x_mac80211.c
+++ b/drivers/net/wireless/rsi/rsi_91x_mac80211.c
@@ -911,14 +911,14 @@ static int rsi_hal_key_config(struct ieee80211_hw *hw,
 		}
 	}
 
-	return rsi_hal_load_key(adapter->priv,
-				key->key,
-				key->keylen,
-				key_type,
-				key->keyidx,
-				key->cipher,
-				sta_id,
-				vif);
+	status = rsi_hal_load_key(adapter->priv,
+				  key->key,
+				  key->keylen,
+				  key_type,
+				  key->keyidx,
+				  key->cipher,
+				  sta_id,
+				  vif);
 	if (status)
 		return status;
 

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH] rsi: fix a bug in rsi_hal_key_config()
  2018-04-27 11:21 ` Dan Carpenter
@ 2018-04-27 11:32   ` Kalle Valo
  -1 siblings, 0 replies; 8+ messages in thread
From: Kalle Valo @ 2018-04-27 11:32 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: Prameela Rani Garnepudi, Amitkumar Karwar, Karun Eagalapati,
	Siva Rebbagondla, linux-wireless, kernel-janitors

Dan Carpenter <dan.carpenter@oracle.com> writes:

> Smatch complains that the end of this function is dead code.  I'm pretty
> sure that this return needs to be changed to only return on error.
>
> Fixes: 4fd6c4762f37 ("rsi: roaming enhancements")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/net/wireless/rsi/rsi_91x_mac80211.c b/drivers/net/wireless/rsi/rsi_91x_mac80211.c
> index 766d874cc6e2..80e7f4f4f188 100644
> --- a/drivers/net/wireless/rsi/rsi_91x_mac80211.c
> +++ b/drivers/net/wireless/rsi/rsi_91x_mac80211.c
> @@ -911,14 +911,14 @@ static int rsi_hal_key_config(struct ieee80211_hw *hw,
>  		}
>  	}
>  
> -	return rsi_hal_load_key(adapter->priv,
> -				key->key,
> -				key->keylen,
> -				key_type,
> -				key->keyidx,
> -				key->cipher,
> -				sta_id,
> -				vif);
> +	status = rsi_hal_load_key(adapter->priv,
> +				  key->key,
> +				  key->keylen,
> +				  key_type,
> +				  key->keyidx,
> +				  key->cipher,
> +				  sta_id,
> +				  vif);

Gustavo submitted an identical patch also for this one :)

https://patchwork.kernel.org/patch/10365997/

-- 
Kalle Valo

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] rsi: fix a bug in rsi_hal_key_config()
@ 2018-04-27 11:32   ` Kalle Valo
  0 siblings, 0 replies; 8+ messages in thread
From: Kalle Valo @ 2018-04-27 11:32 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: Prameela Rani Garnepudi, Amitkumar Karwar, Karun Eagalapati,
	Siva Rebbagondla, linux-wireless, kernel-janitors

Dan Carpenter <dan.carpenter@oracle.com> writes:

> Smatch complains that the end of this function is dead code.  I'm pretty
> sure that this return needs to be changed to only return on error.
>
> Fixes: 4fd6c4762f37 ("rsi: roaming enhancements")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/net/wireless/rsi/rsi_91x_mac80211.c b/drivers/net/wireless/rsi/rsi_91x_mac80211.c
> index 766d874cc6e2..80e7f4f4f188 100644
> --- a/drivers/net/wireless/rsi/rsi_91x_mac80211.c
> +++ b/drivers/net/wireless/rsi/rsi_91x_mac80211.c
> @@ -911,14 +911,14 @@ static int rsi_hal_key_config(struct ieee80211_hw *hw,
>  		}
>  	}
>  
> -	return rsi_hal_load_key(adapter->priv,
> -				key->key,
> -				key->keylen,
> -				key_type,
> -				key->keyidx,
> -				key->cipher,
> -				sta_id,
> -				vif);
> +	status = rsi_hal_load_key(adapter->priv,
> +				  key->key,
> +				  key->keylen,
> +				  key_type,
> +				  key->keyidx,
> +				  key->cipher,
> +				  sta_id,
> +				  vif);

Gustavo submitted an identical patch also for this one :)

https://patchwork.kernel.org/patch/10365997/

-- 
Kalle Valo

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] rsi: fix a bug in rsi_hal_key_config()
  2018-04-27 11:32   ` Kalle Valo
@ 2018-04-27 11:44     ` Dan Carpenter
  -1 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2018-04-27 11:44 UTC (permalink / raw)
  To: Kalle Valo, Gustavo A. R. Silva
  Cc: Prameela Rani Garnepudi, Amitkumar Karwar, Karun Eagalapati,
	Siva Rebbagondla, linux-wireless, kernel-janitors

On Fri, Apr 27, 2018 at 02:32:20PM +0300, Kalle Valo wrote:
> 
> Gustavo submitted an identical patch also for this one :)
> 
> https://patchwork.kernel.org/patch/10365997/
> 

Hey Gustavo,

We keep on sending duplicate patches.  Most of the static checker people
CC kernel-janitors@vger.kernel.org so we can see what's already been
sent.

regards,
dan carpenter


^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] rsi: fix a bug in rsi_hal_key_config()
@ 2018-04-27 11:44     ` Dan Carpenter
  0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2018-04-27 11:44 UTC (permalink / raw)
  To: Kalle Valo, Gustavo A. R. Silva
  Cc: Prameela Rani Garnepudi, Amitkumar Karwar, Karun Eagalapati,
	Siva Rebbagondla, linux-wireless, kernel-janitors

On Fri, Apr 27, 2018 at 02:32:20PM +0300, Kalle Valo wrote:
> 
> Gustavo submitted an identical patch also for this one :)
> 
> https://patchwork.kernel.org/patch/10365997/
> 

Hey Gustavo,

We keep on sending duplicate patches.  Most of the static checker people
CC kernel-janitors@vger.kernel.org so we can see what's already been
sent.

regards,
dan carpenter

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] rsi: fix a bug in rsi_hal_key_config()
  2018-04-27 11:44     ` Dan Carpenter
@ 2018-04-27 13:45       ` Gustavo A. R. Silva
  -1 siblings, 0 replies; 8+ messages in thread
From: Gustavo A. R. Silva @ 2018-04-27 13:45 UTC (permalink / raw)
  To: Dan Carpenter, Kalle Valo
  Cc: Prameela Rani Garnepudi, Amitkumar Karwar, Karun Eagalapati,
	Siva Rebbagondla, linux-wireless, kernel-janitors

Hi Dan,

On 04/27/2018 06:44 AM, Dan Carpenter wrote:
> On Fri, Apr 27, 2018 at 02:32:20PM +0300, Kalle Valo wrote:
>>
>> Gustavo submitted an identical patch also for this one :)
>>
>> https://patchwork.kernel.org/patch/10365997/
>>
> 
> Hey Gustavo,
> 
> We keep on sending duplicate patches.  Most of the static checker people
> CC kernel-janitors@vger.kernel.org so we can see what's already been
> sent.
> 

Oh, I didn't know that.  I'll start CCing that list then.

Thanks for letting me know.
--
Gustavo

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] rsi: fix a bug in rsi_hal_key_config()
@ 2018-04-27 13:45       ` Gustavo A. R. Silva
  0 siblings, 0 replies; 8+ messages in thread
From: Gustavo A. R. Silva @ 2018-04-27 13:45 UTC (permalink / raw)
  To: Dan Carpenter, Kalle Valo
  Cc: Prameela Rani Garnepudi, Amitkumar Karwar, Karun Eagalapati,
	Siva Rebbagondla, linux-wireless, kernel-janitors

Hi Dan,

On 04/27/2018 06:44 AM, Dan Carpenter wrote:
> On Fri, Apr 27, 2018 at 02:32:20PM +0300, Kalle Valo wrote:
>>
>> Gustavo submitted an identical patch also for this one :)
>>
>> https://patchwork.kernel.org/patch/10365997/
>>
> 
> Hey Gustavo,
> 
> We keep on sending duplicate patches.  Most of the static checker people
> CC kernel-janitors@vger.kernel.org so we can see what's already been
> sent.
> 

Oh, I didn't know that.  I'll start CCing that list then.

Thanks for letting me know.
--
Gustavo

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-04-27 13:45 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-27 11:21 [PATCH] rsi: fix a bug in rsi_hal_key_config() Dan Carpenter
2018-04-27 11:21 ` Dan Carpenter
2018-04-27 11:32 ` Kalle Valo
2018-04-27 11:32   ` Kalle Valo
2018-04-27 11:44   ` Dan Carpenter
2018-04-27 11:44     ` Dan Carpenter
2018-04-27 13:45     ` Gustavo A. R. Silva
2018-04-27 13:45       ` Gustavo A. R. Silva

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.