All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: David Veenstra <davidjulianveenstra@gmail.com>
Cc: lars@metafoo.de, pmeerw@pmeerw.net, robh+dt@kernel.org,
	Michael.Hennerich@analog.com, knaack.h@gmx.de,
	linux-iio@vger.kernel.org, daniel.baluta@nxp.com,
	devel@driverdev.osuosl.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 7/9] staging: iio: Documentation: Add missing sysfs docs for angle channel
Date: Sat, 28 Apr 2018 18:36:34 +0100	[thread overview]
Message-ID: <20180428183634.1c7e2769@archlinux> (raw)
In-Reply-To: <7c715bd223b129faa9e5e484a3e4b8e6eba0abeb.1524432236.git.davidjulianveenstra@gmail.com>

On Mon, 23 Apr 2018 00:04:10 +0200
David Veenstra <davidjulianveenstra@gmail.com> wrote:

> The iio resolver drivers in staging use angle channels. This patch
> add missing documentation for this type of channel.
> 
> As was discussed in [1], radians is chosen as the unit, to match the
> unit of angular velocity.
> 
> [1] https://marc.info/?l=linux-driver-devel&m=152190078308330&w=2
> 
> Signed-off-by: David Veenstra <davidjulianveenstra@gmail.com>
Great, no point in waiting on the other patches for the ABI docs
as we are fine with this.

Applied,

Thanks,

Jonathan

> ---
> Changes in v3:
>  - Remove axis modifier on in_angle.
> 
>  Documentation/ABI/testing/sysfs-bus-iio | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
> index 6a5f34b4d5b9..240287e2343a 100644
> --- a/Documentation/ABI/testing/sysfs-bus-iio
> +++ b/Documentation/ABI/testing/sysfs-bus-iio
> @@ -190,6 +190,13 @@ Description:
>  		but should match other such assignments on device).
>  		Units after application of scale and offset are m/s^2.
>  
> +What:		/sys/bus/iio/devices/iio:deviceX/in_angl_raw
> +KernelVersion:	4.17
> +Contact:	linux-iio@vger.kernel.org
> +Description:
> +		Angle of rotation. Units after application of scale and offset
> +		are radians.
> +
>  What:		/sys/bus/iio/devices/iio:deviceX/in_anglvel_x_raw
>  What:		/sys/bus/iio/devices/iio:deviceX/in_anglvel_y_raw
>  What:		/sys/bus/iio/devices/iio:deviceX/in_anglvel_z_raw
> @@ -297,6 +304,7 @@ What:		/sys/bus/iio/devices/iio:deviceX/in_pressure_offset
>  What:		/sys/bus/iio/devices/iio:deviceX/in_humidityrelative_offset
>  What:		/sys/bus/iio/devices/iio:deviceX/in_magn_offset
>  What:		/sys/bus/iio/devices/iio:deviceX/in_rot_offset
> +What:		/sys/bus/iio/devices/iio:deviceX/in_angl_offset
>  KernelVersion:	2.6.35
>  Contact:	linux-iio@vger.kernel.org
>  Description:
> @@ -350,6 +358,7 @@ What:		/sys/bus/iio/devices/iio:deviceX/in_humidityrelative_scale
>  What:		/sys/bus/iio/devices/iio:deviceX/in_velocity_sqrt(x^2+y^2+z^2)_scale
>  What:		/sys/bus/iio/devices/iio:deviceX/in_illuminance_scale
>  What:		/sys/bus/iio/devices/iio:deviceX/in_countY_scale
> +What:		/sys/bus/iio/devices/iio:deviceX/in_angl_scale
>  KernelVersion:	2.6.35
>  Contact:	linux-iio@vger.kernel.org
>  Description:


WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org>
To: David Veenstra <davidjulianveenstra@gmail.com>
Cc: devel@driverdev.osuosl.org, devicetree@vger.kernel.org,
	lars@metafoo.de, Michael.Hennerich@analog.com,
	linux-iio@vger.kernel.org, robh+dt@kernel.org, pmeerw@pmeerw.net,
	knaack.h@gmx.de, daniel.baluta@nxp.com
Subject: Re: [PATCH v3 7/9] staging: iio: Documentation: Add missing sysfs docs for angle channel
Date: Sat, 28 Apr 2018 18:36:34 +0100	[thread overview]
Message-ID: <20180428183634.1c7e2769@archlinux> (raw)
In-Reply-To: <7c715bd223b129faa9e5e484a3e4b8e6eba0abeb.1524432236.git.davidjulianveenstra@gmail.com>

On Mon, 23 Apr 2018 00:04:10 +0200
David Veenstra <davidjulianveenstra@gmail.com> wrote:

> The iio resolver drivers in staging use angle channels. This patch
> add missing documentation for this type of channel.
> 
> As was discussed in [1], radians is chosen as the unit, to match the
> unit of angular velocity.
> 
> [1] https://marc.info/?l=linux-driver-devel&m=152190078308330&w=2
> 
> Signed-off-by: David Veenstra <davidjulianveenstra@gmail.com>
Great, no point in waiting on the other patches for the ABI docs
as we are fine with this.

Applied,

Thanks,

Jonathan

> ---
> Changes in v3:
>  - Remove axis modifier on in_angle.
> 
>  Documentation/ABI/testing/sysfs-bus-iio | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
> index 6a5f34b4d5b9..240287e2343a 100644
> --- a/Documentation/ABI/testing/sysfs-bus-iio
> +++ b/Documentation/ABI/testing/sysfs-bus-iio
> @@ -190,6 +190,13 @@ Description:
>  		but should match other such assignments on device).
>  		Units after application of scale and offset are m/s^2.
>  
> +What:		/sys/bus/iio/devices/iio:deviceX/in_angl_raw
> +KernelVersion:	4.17
> +Contact:	linux-iio@vger.kernel.org
> +Description:
> +		Angle of rotation. Units after application of scale and offset
> +		are radians.
> +
>  What:		/sys/bus/iio/devices/iio:deviceX/in_anglvel_x_raw
>  What:		/sys/bus/iio/devices/iio:deviceX/in_anglvel_y_raw
>  What:		/sys/bus/iio/devices/iio:deviceX/in_anglvel_z_raw
> @@ -297,6 +304,7 @@ What:		/sys/bus/iio/devices/iio:deviceX/in_pressure_offset
>  What:		/sys/bus/iio/devices/iio:deviceX/in_humidityrelative_offset
>  What:		/sys/bus/iio/devices/iio:deviceX/in_magn_offset
>  What:		/sys/bus/iio/devices/iio:deviceX/in_rot_offset
> +What:		/sys/bus/iio/devices/iio:deviceX/in_angl_offset
>  KernelVersion:	2.6.35
>  Contact:	linux-iio@vger.kernel.org
>  Description:
> @@ -350,6 +358,7 @@ What:		/sys/bus/iio/devices/iio:deviceX/in_humidityrelative_scale
>  What:		/sys/bus/iio/devices/iio:deviceX/in_velocity_sqrt(x^2+y^2+z^2)_scale
>  What:		/sys/bus/iio/devices/iio:deviceX/in_illuminance_scale
>  What:		/sys/bus/iio/devices/iio:deviceX/in_countY_scale
> +What:		/sys/bus/iio/devices/iio:deviceX/in_angl_scale
>  KernelVersion:	2.6.35
>  Contact:	linux-iio@vger.kernel.org
>  Description:

  reply	other threads:[~2018-04-28 17:36 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-22 22:02 [PATCH v3 0/9] staging: iio: ad2s1200: Driver clean up David Veenstra
2018-04-22 22:02 ` David Veenstra
2018-04-22 22:02 ` [PATCH v3 1/9] staging: iio: ad2s1200: Add kernel docs to driver state David Veenstra
2018-04-22 22:02   ` David Veenstra
2018-04-28 17:11   ` Jonathan Cameron
2018-04-28 17:11     ` Jonathan Cameron
2018-05-18 12:57     ` David Julian Veenstra
2018-05-18 12:57       ` David Julian Veenstra
2018-04-22 22:03 ` [PATCH v3 2/9] staging: iio: ad2s1200: Improve readability with be16_to_cpup David Veenstra
2018-04-22 22:03   ` David Veenstra
2018-04-28 17:12   ` Jonathan Cameron
2018-04-28 17:12     ` Jonathan Cameron
2018-04-22 22:03 ` [PATCH v3 3/9] staging: iio: ad2s1200: Replace legacy gpio API with modern API David Veenstra
2018-04-22 22:03   ` David Veenstra
2018-04-28 17:17   ` Jonathan Cameron
2018-04-28 17:17     ` Jonathan Cameron
2018-04-22 22:03 ` [PATCH v3 4/9] staging: iio: ad2s1200: Replace platform data with dt bindings David Veenstra
2018-04-22 22:03   ` David Veenstra
2018-04-28 17:20   ` Jonathan Cameron
2018-04-28 17:20     ` Jonathan Cameron
2018-04-22 22:03 ` [PATCH v3 5/9] staging: iio: ad2s1200: Add documentation for device tree binding David Veenstra
2018-04-22 22:03   ` David Veenstra
2018-04-27 14:48   ` Rob Herring
2018-04-27 14:48     ` Rob Herring
2018-04-28 15:27     ` Jonathan Cameron
2018-04-28 15:27       ` Jonathan Cameron
2018-05-18 13:00       ` David Julian Veenstra
2018-05-18 13:00         ` David Julian Veenstra
2018-04-27 14:49   ` Rob Herring
2018-04-27 14:49     ` Rob Herring
2018-04-22 22:03 ` [PATCH v3 6/9] staging: iio: ad2s1200: Add scaling factor for angular velocity channel David Veenstra
2018-04-22 22:03   ` David Veenstra
2018-04-28 17:23   ` Jonathan Cameron
2018-04-28 17:23     ` Jonathan Cameron
2018-04-28 17:35     ` Jonathan Cameron
2018-04-28 17:35       ` Jonathan Cameron
2018-05-18 13:10       ` David Julian Veenstra
2018-05-18 13:10         ` David Julian Veenstra
2018-04-22 22:04 ` [PATCH v3 7/9] staging: iio: Documentation: Add missing sysfs docs for angle channel David Veenstra
2018-04-22 22:04   ` David Veenstra
2018-04-28 17:36   ` Jonathan Cameron [this message]
2018-04-28 17:36     ` Jonathan Cameron
2018-04-22 22:04 ` [PATCH v3 8/9] staging: iio: ad2s1200: Add scaling factor " David Veenstra
2018-04-22 22:04   ` David Veenstra
2018-04-28 17:37   ` Jonathan Cameron
2018-04-28 17:37     ` Jonathan Cameron
2018-04-22 22:04 ` [PATCH v3 9/9] staging: iio: ad2s1200: Move driver out of staging David Veenstra
2018-04-22 22:04   ` David Veenstra
2018-04-28 17:46   ` Jonathan Cameron
2018-04-28 17:46     ` Jonathan Cameron
2018-05-18 13:17     ` David Julian Veenstra
2018-05-18 13:17       ` David Julian Veenstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180428183634.1c7e2769@archlinux \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=daniel.baluta@nxp.com \
    --cc=davidjulianveenstra@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=devicetree@vger.kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.