[Buildroot] [PATCH 1/1] package/python-requests fix dependencies

[Buildroot] [PATCH 1/1] package/python-requests fix dependencies

[Sven Haardiek]

Requests need hashlib to run. Otherwise it is not possible to import, due to
missing e.g. md5.

Signed-off-by: Sven Haardiek <sven.haardiek@iotec-gmbh.de>
---
 package/python-requests/Config.in | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/python-requests/Config.in b/package/python-requests/Config.in
index d2726fb26a..d51b4079cb 100644
--- a/package/python-requests/Config.in
+++ b/package/python-requests/Config.in
@@ -4,6 +4,8 @@ config BR2_PACKAGE_PYTHON_REQUESTS
 	select BR2_PACKAGE_PYTHON_CHARDET # runtime
 	select BR2_PACKAGE_PYTHON_IDNA # runtime
 	select BR2_PACKAGE_PYTHON_URLLIB3 # runtime
+	select BR2_PACKAGE_PYTHON_HASHLIB # runtime
+	select BR2_PACKAGE_PYTHON3_HASHLIB # runtime
 	select BR2_PACKAGE_PYTHON_SSL if BR2_PACKAGE_PYTHON # runtime
 	select BR2_PACKAGE_PYTHON3_SSL if BR2_PACKAGE_PYTHON3 # runtime
 	select BR2_PACKAGE_PYTHON_ZLIB if BR2_PACKAGE_PYTHON # runtime
-- 
2.17.0

[Buildroot] [PATCH 1/1] package/python-requests fix dependencies

[Yann E. MORIN]

Sven, All,

On 2018-04-29 13:40 +0200, Sven Haardiek spake thusly:
> Requests need hashlib to run. Otherwise it is not possible to import, due to
> missing e.g. md5.
> 
> Signed-off-by: Sven Haardiek <sven.haardiek@iotec-gmbh.de>
> ---
>  package/python-requests/Config.in | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/package/python-requests/Config.in b/package/python-requests/Config.in
> index d2726fb26a..d51b4079cb 100644
> --- a/package/python-requests/Config.in
> +++ b/package/python-requests/Config.in
> @@ -4,6 +4,8 @@ config BR2_PACKAGE_PYTHON_REQUESTS
>  	select BR2_PACKAGE_PYTHON_CHARDET # runtime
>  	select BR2_PACKAGE_PYTHON_IDNA # runtime
>  	select BR2_PACKAGE_PYTHON_URLLIB3 # runtime
> +	select BR2_PACKAGE_PYTHON_HASHLIB # runtime
> +	select BR2_PACKAGE_PYTHON3_HASHLIB # runtime

This is definitely incorrect: you can't select for both pyhon and
python3 at the same time. See how it idoes done for SSL, just below:

>  	select BR2_PACKAGE_PYTHON_SSL if BR2_PACKAGE_PYTHON # runtime
>  	select BR2_PACKAGE_PYTHON3_SSL if BR2_PACKAGE_PYTHON3 # runtime
>  	select BR2_PACKAGE_PYTHON_ZLIB if BR2_PACKAGE_PYTHON # runtime

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 1/1] package/python-requests fix dependencies

[Sven Haardiek]

Requests need hashlib to run with Pyhton 2. Otherwise it is not possible to
import, due to missing e.g. md5. There is a variable BR2_PACKAGE_PYTHON_HASHLIB
to make it work.

Signed-off-by: Sven Haardiek <sven.haardiek@iotec-gmbh.de>
---
 package/python-requests/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/python-requests/Config.in b/package/python-requests/Config.in
index d2726fb26a..30158b8d25 100644
--- a/package/python-requests/Config.in
+++ b/package/python-requests/Config.in
@@ -4,6 +4,7 @@ config BR2_PACKAGE_PYTHON_REQUESTS
 	select BR2_PACKAGE_PYTHON_CHARDET # runtime
 	select BR2_PACKAGE_PYTHON_IDNA # runtime
 	select BR2_PACKAGE_PYTHON_URLLIB3 # runtime
+	select BR2_PACKAGE_PYTHON_HASHLIB if BR2_PACKAGE_PYTHON # runtime
 	select BR2_PACKAGE_PYTHON_SSL if BR2_PACKAGE_PYTHON # runtime
 	select BR2_PACKAGE_PYTHON3_SSL if BR2_PACKAGE_PYTHON3 # runtime
 	select BR2_PACKAGE_PYTHON_ZLIB if BR2_PACKAGE_PYTHON # runtime
-- 
2.17.0

[Buildroot] [PATCH 1/1] package/python-requests fix dependencies

[Peter Korsgaard]

>>>>> "Sven" == Sven Haardiek <sven.haardiek@iotec-gmbh.de> writes:

 > Requests need hashlib to run with Pyhton 2. Otherwise it is not possible to
 > import, due to missing e.g. md5. There is a variable BR2_PACKAGE_PYTHON_HASHLIB
 > to make it work.

 > Signed-off-by: Sven Haardiek <sven.haardiek@iotec-gmbh.de>

Committed after tweaking the commit message a bit, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 1/1] package/python-requests fix dependencies

[Peter Korsgaard]

>>>>> "Sven" == Sven Haardiek <sven.haardiek@iotec-gmbh.de> writes:

 > Requests need hashlib to run with Pyhton 2. Otherwise it is not possible to
 > import, due to missing e.g. md5. There is a variable BR2_PACKAGE_PYTHON_HASHLIB
 > to make it work.

 > Signed-off-by: Sven Haardiek <sven.haardiek@iotec-gmbh.de>

Committed to 2018.02.x, thanks.

-- 
Bye, Peter Korsgaard