From: Bin Liu <b-liu@ti.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, stable@vger.kernel.org
Subject: [1/2] usb: musb: host: fix potential NULL pointer dereference
Date: Mon, 30 Apr 2018 13:11:34 -0500 [thread overview]
Message-ID: <20180430181134.GB21238@uda0271908> (raw)
On Mon, Apr 30, 2018 at 09:42:15AM -0700, Greg Kroah-Hartman wrote:
> On Mon, Apr 30, 2018 at 11:20:53AM -0500, Bin Liu wrote:
> > musb_start_urb() doesn't check the pass-in parameter if it is NULL. But
> > in musb_bulk_nak_timeout() the parameter passed to musb_start_urb() is
> > returned from first_qh(), which could be NULL.
> >
> > So wrap the musb_start_urb() call here with a if condition check to
> > avoid the potential NULL pointer dereference.
> >
> > Fixes: f283862f3b5cb("usb: musb: NAK timeout scheme on bulk TX endpoint")
>
> Nit, you forgot a ' ', this should be:
> f283862f3b5c ("usb: musb: NAK timeout scheme on bulk TX endpoint")
Sorry, thanks.
> You also had one extra id value in there, odd. I'll edit this by
Not sure why 'git blame' gives that one extra on my computer. I will see
if I will figure it out...
> hand...
Thanks,
-Bin.
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Bin Liu <b-liu@ti.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: <linux-usb@vger.kernel.org>, <stable@vger.kernel.org>
Subject: Re: [PATCH 1/2] usb: musb: host: fix potential NULL pointer dereference
Date: Mon, 30 Apr 2018 13:11:34 -0500 [thread overview]
Message-ID: <20180430181134.GB21238@uda0271908> (raw)
In-Reply-To: <20180430164215.GA17510@kroah.com>
On Mon, Apr 30, 2018 at 09:42:15AM -0700, Greg Kroah-Hartman wrote:
> On Mon, Apr 30, 2018 at 11:20:53AM -0500, Bin Liu wrote:
> > musb_start_urb() doesn't check the pass-in parameter if it is NULL. But
> > in musb_bulk_nak_timeout() the parameter passed to musb_start_urb() is
> > returned from first_qh(), which could be NULL.
> >
> > So wrap the musb_start_urb() call here with a if condition check to
> > avoid the potential NULL pointer dereference.
> >
> > Fixes: f283862f3b5cb("usb: musb: NAK timeout scheme on bulk TX endpoint")
>
> Nit, you forgot a ' ', this should be:
> f283862f3b5c ("usb: musb: NAK timeout scheme on bulk TX endpoint")
Sorry, thanks.
> You also had one extra id value in there, odd. I'll edit this by
Not sure why 'git blame' gives that one extra on my computer. I will see
if I will figure it out...
> hand...
Thanks,
-Bin.
next reply other threads:[~2018-04-30 18:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-30 18:11 Bin Liu [this message]
2018-04-30 18:11 ` [PATCH 1/2] usb: musb: host: fix potential NULL pointer dereference Bin Liu
-- strict thread matches above, loose matches on Subject: below --
2018-04-30 18:41 [1/2] " Bin Liu
2018-04-30 18:41 ` [PATCH 1/2] " Bin Liu
2018-04-30 18:24 [1/2] " Greg Kroah-Hartman
2018-04-30 18:24 ` [PATCH 1/2] " Greg Kroah-Hartman
2018-04-30 16:42 [1/2] " Greg Kroah-Hartman
2018-04-30 16:42 ` [PATCH 1/2] " Greg Kroah-Hartman
2018-04-30 16:20 [2/2] usb: musb: trace: fix NULL pointer dereference in musb_g_tx() Bin Liu
2018-04-30 16:20 ` [PATCH 2/2] " Bin Liu
2018-04-30 16:20 [1/2] usb: musb: host: fix potential NULL pointer dereference Bin Liu
2018-04-30 16:20 ` [PATCH 1/2] " Bin Liu
2018-04-30 16:20 [PATCH 0/2] musb fixes for v4.17-rc4 Bin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180430181134.GB21238@uda0271908 \
--to=b-liu@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.