From: Tony Lindgren <tony@atomide.com>
To: Tero Kristo <t-kristo@ti.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: OMAP2+: powerdomain: use raw_smp_processor_id() for trace
Date: Tue, 1 May 2018 07:50:40 -0700 [thread overview]
Message-ID: <20180501145040.GH5671@atomide.com> (raw)
In-Reply-To: <1520589020-14018-1-git-send-email-t-kristo@ti.com>
* Tero Kristo <t-kristo@ti.com> [180309 01:51]:
> smp_processor_id() checks preemption if CONFIG_DEBUG_PREEMPT is enabled,
> causing a warning dump during boot:
>
> [ 5.042377] BUG: using smp_processor_id() in preemptible [00000000] code: swapper/0/1
> [ 5.050281] caller is pwrdm_set_next_pwrst+0x48/0x88
> [ 5.055330] CPU: 1 PID: 1 Comm: swapper/0 Not tainted 4.14.24-g57341df0b4 #1
>
> Use the raw_smp_processor_id() for the trace instead, this value does
> not need to be perfectly correct. The alternative of disabling preempt
> is too heavy weight operation to be applied in PM hot path for just
> tracing purposes.
Sorry just noticed this is still pending while looking through
my inbox. Applying into omap-for-v4.17/fixes.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP2+: powerdomain: use raw_smp_processor_id() for trace
Date: Tue, 1 May 2018 07:50:40 -0700 [thread overview]
Message-ID: <20180501145040.GH5671@atomide.com> (raw)
In-Reply-To: <1520589020-14018-1-git-send-email-t-kristo@ti.com>
* Tero Kristo <t-kristo@ti.com> [180309 01:51]:
> smp_processor_id() checks preemption if CONFIG_DEBUG_PREEMPT is enabled,
> causing a warning dump during boot:
>
> [ 5.042377] BUG: using smp_processor_id() in preemptible [00000000] code: swapper/0/1
> [ 5.050281] caller is pwrdm_set_next_pwrst+0x48/0x88
> [ 5.055330] CPU: 1 PID: 1 Comm: swapper/0 Not tainted 4.14.24-g57341df0b4 #1
>
> Use the raw_smp_processor_id() for the trace instead, this value does
> not need to be perfectly correct. The alternative of disabling preempt
> is too heavy weight operation to be applied in PM hot path for just
> tracing purposes.
Sorry just noticed this is still pending while looking through
my inbox. Applying into omap-for-v4.17/fixes.
Regards,
Tony
next prev parent reply other threads:[~2018-05-01 14:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-09 9:50 [PATCH] ARM: OMAP2+: powerdomain: use raw_smp_processor_id() for trace Tero Kristo
2018-03-09 9:50 ` Tero Kristo
2018-05-01 14:50 ` Tony Lindgren [this message]
2018-05-01 14:50 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180501145040.GH5671@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.