From: Tejun Heo <tj@kernel.org>
To: Waiman Long <longman@redhat.com>
Cc: Li Zefan <lizefan@huawei.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, kernel-team@fb.com, pjt@google.com,
luto@amacapital.net, Mike Galbraith <efault@gmx.de>,
torvalds@linux-foundation.org, Roman Gushchin <guro@fb.com>,
Juri Lelli <juri.lelli@redhat.com>
Subject: Re: [PATCH v7 4/5] cpuset: Restrict load balancing off cpus to subset of cpus.isolated
Date: Tue, 1 May 2018 13:58:28 -0700 [thread overview]
Message-ID: <20180501205828.GD2368884@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <9eb2c45e-e71e-61ef-aa6d-b8124b739cdf@redhat.com>
Hello,
On Tue, May 01, 2018 at 04:33:45PM -0400, Waiman Long wrote:
> I think that will work too. We currently don't have a flag to make a
> file visible on first-level children only, but it shouldn't be hard to
> make one.
I think it'd be fine to make the flag file exist on all !root cgroups
but only writable on the first level children.
> Putting CPUs into an isolated child cpuset means removing it from the
> root's effective CPUs. So I would probably like to expose the read-only
> cpus.effective in the root cgroup so that we can check changes in the
> effective cpu list.
Ah, yeah, that makes sense.
> I will renew the patchset will your suggestion.
Thank you very much.
--
tejun
WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: Waiman Long <longman@redhat.com>
Cc: Li Zefan <lizefan@huawei.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, kernel-team@fb.com, pjt@google.com,
luto@amacapital.net, Mike Galbraith <efault@gmx.de>,
torvalds@linux-foundation.org, Roman Gushchin <guro@fb.com>,
Juri Lelli <juri.lelli@redhat.com>
Subject: Re: [PATCH v7 4/5] cpuset: Restrict load balancing off cpus to subset of cpus.isolated
Date: Tue, 1 May 2018 13:58:28 -0700 [thread overview]
Message-ID: <20180501205828.GD2368884@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <9eb2c45e-e71e-61ef-aa6d-b8124b739cdf@redhat.com>
Hello,
On Tue, May 01, 2018 at 04:33:45PM -0400, Waiman Long wrote:
> I think that will work too. We currently don't have a flag to make a
> file visible on first-level children only, but it shouldn't be hard to
> make one.
I think it'd be fine to make the flag file exist on all !root cgroups
but only writable on the first level children.
> Putting CPUs into an isolated child cpuset means removing it from the
> root's effective CPUs. So I would probably like to expose the read-only
> cpus.effective in the root cgroup so that we can check changes in the
> effective cpu list.
Ah, yeah, that makes sense.
> I will renew the patchset will your suggestion.
Thank you very much.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-05-01 20:58 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-19 13:46 [PATCH v7 0/5] cpuset: Enable cpuset controller in default hierarchy Waiman Long
2018-04-19 13:46 ` Waiman Long
2018-04-19 13:47 ` [PATCH v7 1/5] " Waiman Long
2018-04-19 13:47 ` Waiman Long
2018-04-19 13:47 ` [PATCH v7 2/5] cpuset: Add cpuset.sched_load_balance to v2 Waiman Long
2018-04-19 13:47 ` Waiman Long
2018-05-02 10:24 ` Peter Zijlstra
2018-05-02 10:24 ` Peter Zijlstra
2018-05-02 13:29 ` Waiman Long
2018-05-02 13:29 ` Waiman Long
2018-05-02 13:42 ` Peter Zijlstra
2018-05-02 13:42 ` Peter Zijlstra
2018-05-02 13:47 ` Waiman Long
2018-05-02 13:47 ` Waiman Long
2018-05-02 14:02 ` Peter Zijlstra
2018-05-02 14:02 ` Peter Zijlstra
2018-05-02 14:35 ` Mike Galbraith
2018-05-02 14:35 ` Mike Galbraith
2018-04-19 13:47 ` [PATCH v7 3/5] cpuset: Add a root-only cpus.isolated v2 control file Waiman Long
2018-04-19 13:47 ` Waiman Long
2018-04-23 15:56 ` Juri Lelli
2018-04-23 15:56 ` Juri Lelli
2018-05-02 14:08 ` Peter Zijlstra
2018-05-02 14:08 ` Peter Zijlstra
2018-05-08 0:30 ` Waiman Long
2018-05-08 0:30 ` Waiman Long
2018-04-19 13:47 ` [PATCH v7 4/5] cpuset: Restrict load balancing off cpus to subset of cpus.isolated Waiman Long
2018-04-19 13:47 ` Waiman Long
2018-05-01 19:51 ` Tejun Heo
2018-05-01 19:51 ` Tejun Heo
2018-05-01 20:33 ` Waiman Long
2018-05-01 20:33 ` Waiman Long
2018-05-01 20:58 ` Tejun Heo [this message]
2018-05-01 20:58 ` Tejun Heo
2018-05-01 21:31 ` Waiman Long
2018-05-01 21:31 ` Waiman Long
2018-04-19 13:47 ` [PATCH v7 5/5] cpuset: Make generate_sched_domains() recognize isolated_cpus Waiman Long
2018-04-19 13:47 ` Waiman Long
2018-04-20 8:23 ` [PATCH v7 0/5] cpuset: Enable cpuset controller in default hierarchy Mike Galbraith
2018-04-20 8:23 ` Mike Galbraith
2018-04-23 16:32 ` Waiman Long
2018-04-23 16:32 ` Waiman Long
2018-04-23 13:07 ` Juri Lelli
2018-04-23 13:07 ` Juri Lelli
2018-04-23 13:57 ` Juri Lelli
2018-04-23 13:57 ` Juri Lelli
2018-04-23 14:10 ` Waiman Long
2018-04-23 14:10 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180501205828.GD2368884@devbig577.frc2.facebook.com \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=efault@gmx.de \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=juri.lelli@redhat.com \
--cc=kernel-team@fb.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=longman@redhat.com \
--cc=luto@amacapital.net \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.