From: Shawn Guo <shawnguo@kernel.org>
To: Stefan Agner <stefan@agner.ch>
Cc: kernel@pengutronix.de, fabio.estevam@nxp.com,
mturquette@baylibre.com, sboyd@kernel.org,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-imx@nxp.com
Subject: Re: [PATCH] clk: imx6ul: fix periph clk2 clock mux selection
Date: Wed, 2 May 2018 15:40:28 +0800 [thread overview]
Message-ID: <20180502074027.GF3443@dragon> (raw)
In-Reply-To: <20180418125254.4397-1-stefan@agner.ch>
Add linux-imx list, in case NXP friends have a comment.
On Wed, Apr 18, 2018 at 02:52:54PM +0200, Stefan Agner wrote:
> According to the data sheet the 3rd choice is the bypass clock
> of pll2. This should not have any effect in practice as this
> selection is not used currently.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
For me it looks good,
Acked-by: Shawn Guo <shawnguo@kernel.org>
> ---
> drivers/clk/imx/clk-imx6ul.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/imx/clk-imx6ul.c b/drivers/clk/imx/clk-imx6ul.c
> index 12320118f8de..2ed7dae39008 100644
> --- a/drivers/clk/imx/clk-imx6ul.c
> +++ b/drivers/clk/imx/clk-imx6ul.c
> @@ -40,7 +40,7 @@ static const char *axi_alt_sels[] = { "pll2_pfd2_396m", "pll3_pfd1_540m", };
> static const char *axi_sels[] = {"periph", "axi_alt_sel", };
> static const char *periph_pre_sels[] = { "pll2_bus", "pll2_pfd2_396m", "pll2_pfd0_352m", "pll2_198m", };
> static const char *periph2_pre_sels[] = { "pll2_bus", "pll2_pfd2_396m", "pll2_pfd0_352m", "pll4_audio_div", };
> -static const char *periph_clk2_sels[] = { "pll3_usb_otg", "osc", "osc", };
> +static const char *periph_clk2_sels[] = { "pll3_usb_otg", "osc", "pll2_bypass_src", };
> static const char *periph2_clk2_sels[] = { "pll3_usb_otg", "osc", };
> static const char *periph_sels[] = { "periph_pre", "periph_clk2", };
> static const char *periph2_sels[] = { "periph2_pre", "periph2_clk2", };
> --
> 2.17.0
>
WARNING: multiple messages have this Message-ID (diff)
From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: imx6ul: fix periph clk2 clock mux selection
Date: Wed, 2 May 2018 15:40:28 +0800 [thread overview]
Message-ID: <20180502074027.GF3443@dragon> (raw)
In-Reply-To: <20180418125254.4397-1-stefan@agner.ch>
Add linux-imx list, in case NXP friends have a comment.
On Wed, Apr 18, 2018 at 02:52:54PM +0200, Stefan Agner wrote:
> According to the data sheet the 3rd choice is the bypass clock
> of pll2. This should not have any effect in practice as this
> selection is not used currently.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
For me it looks good,
Acked-by: Shawn Guo <shawnguo@kernel.org>
> ---
> drivers/clk/imx/clk-imx6ul.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/imx/clk-imx6ul.c b/drivers/clk/imx/clk-imx6ul.c
> index 12320118f8de..2ed7dae39008 100644
> --- a/drivers/clk/imx/clk-imx6ul.c
> +++ b/drivers/clk/imx/clk-imx6ul.c
> @@ -40,7 +40,7 @@ static const char *axi_alt_sels[] = { "pll2_pfd2_396m", "pll3_pfd1_540m", };
> static const char *axi_sels[] = {"periph", "axi_alt_sel", };
> static const char *periph_pre_sels[] = { "pll2_bus", "pll2_pfd2_396m", "pll2_pfd0_352m", "pll2_198m", };
> static const char *periph2_pre_sels[] = { "pll2_bus", "pll2_pfd2_396m", "pll2_pfd0_352m", "pll4_audio_div", };
> -static const char *periph_clk2_sels[] = { "pll3_usb_otg", "osc", "osc", };
> +static const char *periph_clk2_sels[] = { "pll3_usb_otg", "osc", "pll2_bypass_src", };
> static const char *periph2_clk2_sels[] = { "pll3_usb_otg", "osc", };
> static const char *periph_sels[] = { "periph_pre", "periph_clk2", };
> static const char *periph2_sels[] = { "periph2_pre", "periph2_clk2", };
> --
> 2.17.0
>
next prev parent reply other threads:[~2018-05-02 7:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 12:52 [PATCH] clk: imx6ul: fix periph clk2 clock mux selection Stefan Agner
2018-04-18 12:52 ` Stefan Agner
2018-05-02 7:40 ` Shawn Guo [this message]
2018-05-02 7:40 ` Shawn Guo
2018-05-05 2:55 ` Stephen Boyd
2018-05-05 2:55 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180502074027.GF3443@dragon \
--to=shawnguo@kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.