From: Johannes Weiner <hannes@cmpxchg.org>
To: Roman Gushchin <guro@fb.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org, kernel-team@fb.com,
Michal Hocko <mhocko@suse.com>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH v2] mm: introduce memory.min
Date: Wed, 2 May 2018 08:30:40 -0400 [thread overview]
Message-ID: <20180502123040.GA16060@cmpxchg.org> (raw)
In-Reply-To: <20180423123610.27988-1-guro@fb.com>
On Mon, Apr 23, 2018 at 01:36:10PM +0100, Roman Gushchin wrote:
> @@ -59,6 +59,12 @@ enum memcg_memory_event {
> MEMCG_NR_MEMORY_EVENTS,
> };
>
> +enum mem_cgroup_protection {
> + MEMCG_PROT_NONE,
> + MEMCG_PROT_LOW,
> + MEMCG_PROT_HIGH,
Ha, HIGH doesn't make much sense, but I went back and it's indeed what
I suggested. Must have been a brainfart. This should be
MEMCG_PROT_NONE,
MEMCG_PROT_LOW,
MEMCG_PROT_MIN
right? To indicate which type of protection is applying.
The rest of the patch looks good:
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
next prev parent reply other threads:[~2018-05-02 12:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-23 12:36 [PATCH v2] mm: introduce memory.min Roman Gushchin
2018-04-23 12:36 ` Roman Gushchin
2018-04-24 12:30 ` Vladimir Davydov
2018-04-24 13:54 ` Roman Gushchin
2018-04-24 13:54 ` Roman Gushchin
2018-04-24 13:54 ` Roman Gushchin
2018-04-25 10:52 ` Vladimir Davydov
2018-04-25 12:38 ` Roman Gushchin
2018-04-25 12:38 ` Roman Gushchin
2018-05-02 13:38 ` Johannes Weiner
2018-05-02 12:30 ` Johannes Weiner [this message]
2018-05-02 12:52 ` Roman Gushchin
2018-05-02 12:52 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180502123040.GA16060@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=cgroups@vger.kernel.org \
--cc=guro@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=tj@kernel.org \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.