From: Johannes Weiner <hannes@cmpxchg.org>
To: Roman Gushchin <guro@fb.com>
Cc: Vladimir Davydov <vdavydov.dev@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org, kernel-team@fb.com,
Michal Hocko <mhocko@suse.com>, Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH v2] mm: introduce memory.min
Date: Wed, 2 May 2018 09:38:32 -0400 [thread overview]
Message-ID: <20180502133832.GA18204@cmpxchg.org> (raw)
In-Reply-To: <20180424135409.GA28080@castle.DHCP.thefacebook.com>
On Tue, Apr 24, 2018 at 02:54:15PM +0100, Roman Gushchin wrote:
> From: Roman Gushchin <guro@fb.com>
> Date: Tue, 24 Apr 2018 14:44:14 +0100
> Subject: [PATCH] mm: ignore memory.min of abandoned memory cgroups
>
> If a cgroup has no associated tasks, invoking the OOM killer
> won't help release any memory, so respecting the memory.min
> can lead to an infinite OOM loop or system stall.
>
> Let's ignore memory.min of unpopulated cgroups.
Good point, this makes sense.
> Signed-off-by: Roman Gushchin <guro@fb.com>
> Cc: Johannes Weiner <hannes@cmpxchg.org>
> Cc: Michal Hocko <mhocko@suse.com>
> Cc: Vladimir Davydov <vdavydov.dev@gmail.com>
> Cc: Tejun Heo <tj@kernel.org>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
> @@ -2549,8 +2549,11 @@ static bool shrink_node(pg_data_t *pgdat, struct scan_control *sc)
> /*
> * Hard protection.
> * If there is no reclaimable memory, OOM.
> + * Abandoned cgroups are loosing protection,
losing
next prev parent reply other threads:[~2018-05-02 13:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-23 12:36 [PATCH v2] mm: introduce memory.min Roman Gushchin
2018-04-23 12:36 ` Roman Gushchin
2018-04-24 12:30 ` Vladimir Davydov
2018-04-24 13:54 ` Roman Gushchin
2018-04-24 13:54 ` Roman Gushchin
2018-04-24 13:54 ` Roman Gushchin
2018-04-25 10:52 ` Vladimir Davydov
2018-04-25 12:38 ` Roman Gushchin
2018-04-25 12:38 ` Roman Gushchin
2018-05-02 13:38 ` Johannes Weiner [this message]
2018-05-02 12:30 ` Johannes Weiner
2018-05-02 12:52 ` Roman Gushchin
2018-05-02 12:52 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180502133832.GA18204@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=cgroups@vger.kernel.org \
--cc=guro@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=tj@kernel.org \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.