From: Anthony PERARD <anthony.perard@citrix.com>
To: Igor Druzhinin <igor.druzhinin@citrix.com>
Cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org,
qemu-devel@nongnu.org, paul.durrant@citrix.com,
pbonzini@redhat.com
Subject: Re: [PATCH] xen/hvm: correct reporting of modified memory under physmap during migration
Date: Wed, 2 May 2018 16:48:48 +0100 [thread overview]
Message-ID: <20180502154848.GC14376@perard> (raw)
In-Reply-To: <1524664007-12687-1-git-send-email-igor.druzhinin@citrix.com>
On Wed, Apr 25, 2018 at 02:46:47PM +0100, Igor Druzhinin wrote:
> When global_log_dirty is enabled VRAM modification tracking never
> worked correctly. The address that is passed to xen_hvm_modified_memory()
> is not the effective PFN but RAM block address which is not the same
> for VRAM.
>
> We need to make a translation for this address into PFN using
> physmap. Since there is no way to access physmap properly inside
> xen_hvm_modified_memory() let's make it a global structure.
>
> Signed-off-by: Igor Druzhinin <igor.druzhinin@citrix.com>
Acked-by: Anthony PERARD <anthony.perard@citrix.com>
Thanks,
--
Anthony PERARD
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: Anthony PERARD <anthony.perard@citrix.com>
To: Igor Druzhinin <igor.druzhinin@citrix.com>
Cc: xen-devel@lists.xenproject.org, qemu-devel@nongnu.org,
sstabellini@kernel.org, pbonzini@redhat.com,
paul.durrant@citrix.com
Subject: Re: [Qemu-devel] [PATCH] xen/hvm: correct reporting of modified memory under physmap during migration
Date: Wed, 2 May 2018 16:48:48 +0100 [thread overview]
Message-ID: <20180502154848.GC14376@perard> (raw)
In-Reply-To: <1524664007-12687-1-git-send-email-igor.druzhinin@citrix.com>
On Wed, Apr 25, 2018 at 02:46:47PM +0100, Igor Druzhinin wrote:
> When global_log_dirty is enabled VRAM modification tracking never
> worked correctly. The address that is passed to xen_hvm_modified_memory()
> is not the effective PFN but RAM block address which is not the same
> for VRAM.
>
> We need to make a translation for this address into PFN using
> physmap. Since there is no way to access physmap properly inside
> xen_hvm_modified_memory() let's make it a global structure.
>
> Signed-off-by: Igor Druzhinin <igor.druzhinin@citrix.com>
Acked-by: Anthony PERARD <anthony.perard@citrix.com>
Thanks,
--
Anthony PERARD
next prev parent reply other threads:[~2018-05-02 15:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-25 13:46 [PATCH] xen/hvm: correct reporting of modified memory under physmap during migration Igor Druzhinin
2018-04-25 13:46 ` [Qemu-devel] " Igor Druzhinin
2018-05-02 15:48 ` Anthony PERARD [this message]
2018-05-02 15:48 ` Anthony PERARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180502154848.GC14376@perard \
--to=anthony.perard@citrix.com \
--cc=igor.druzhinin@citrix.com \
--cc=paul.durrant@citrix.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.