* [PATCH v2] thermal: ti-soc-thermal: fix incorrect entry in omap5430_adc_to_temp[] [not found] <CGME20180502141432eucas1p1c85aa366979b73c59a46ec0c2f7ef8e6@eucas1p1.samsung.com> @ 2018-05-02 14:14 ` Bartlomiej Zolnierkiewicz 2018-05-02 15:44 ` Keerthy 2018-05-02 15:49 ` Daniel Lezcano 0 siblings, 2 replies; 5+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2018-05-02 14:14 UTC (permalink / raw) To: Eduardo Valentin, Keerthy; +Cc: Zhang Rui, linux-pm, linux-omap, linux-kernel Entry for Index 941 has one zero too much. Fix it. Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> --- v2: - Fix patch description. drivers/thermal/ti-soc-thermal/omap5-thermal-data.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: b/drivers/thermal/ti-soc-thermal/omap5-thermal-data.c =================================================================== --- a/drivers/thermal/ti-soc-thermal/omap5-thermal-data.c 2018-04-30 16:23:42.000000000 +0200 +++ b/drivers/thermal/ti-soc-thermal/omap5-thermal-data.c 2018-05-02 14:16:09.461434201 +0200 @@ -310,7 +310,7 @@ omap5430_adc_to_temp[ 119800, 120200, 120600, 121000, 121400, 121800, 122400, 122600, 123000, 123400, /* Index 940 - 945 */ - 123800, 1242000, 124600, 124900, 125000, 125000, + 123800, 124200, 124600, 124900, 125000, 125000, }; /* OMAP54xx ES2.0 data */ ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] thermal: ti-soc-thermal: fix incorrect entry in omap5430_adc_to_temp[] 2018-05-02 14:14 ` [PATCH v2] thermal: ti-soc-thermal: fix incorrect entry in omap5430_adc_to_temp[] Bartlomiej Zolnierkiewicz @ 2018-05-02 15:44 ` Keerthy 2018-05-02 15:49 ` Daniel Lezcano 1 sibling, 0 replies; 5+ messages in thread From: Keerthy @ 2018-05-02 15:44 UTC (permalink / raw) To: Bartlomiej Zolnierkiewicz, Eduardo Valentin Cc: Zhang Rui, linux-pm, linux-omap, linux-kernel On Wednesday 02 May 2018 07:44 PM, Bartlomiej Zolnierkiewicz wrote: > Entry for Index 941 has one zero too much. Fix it. > Acked-by: Keerthy <j-keerthy@ti.com> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > --- > v2: > - Fix patch description. > > drivers/thermal/ti-soc-thermal/omap5-thermal-data.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: b/drivers/thermal/ti-soc-thermal/omap5-thermal-data.c > =================================================================== > --- a/drivers/thermal/ti-soc-thermal/omap5-thermal-data.c 2018-04-30 16:23:42.000000000 +0200 > +++ b/drivers/thermal/ti-soc-thermal/omap5-thermal-data.c 2018-05-02 14:16:09.461434201 +0200 > @@ -310,7 +310,7 @@ omap5430_adc_to_temp[ > 119800, 120200, 120600, 121000, 121400, 121800, 122400, 122600, 123000, > 123400, > /* Index 940 - 945 */ > - 123800, 1242000, 124600, 124900, 125000, 125000, > + 123800, 124200, 124600, 124900, 125000, 125000, > }; > > /* OMAP54xx ES2.0 data */ > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] thermal: ti-soc-thermal: fix incorrect entry in omap5430_adc_to_temp[] @ 2018-05-02 15:44 ` Keerthy 0 siblings, 0 replies; 5+ messages in thread From: Keerthy @ 2018-05-02 15:44 UTC (permalink / raw) To: Bartlomiej Zolnierkiewicz, Eduardo Valentin Cc: Zhang Rui, linux-pm, linux-omap, linux-kernel On Wednesday 02 May 2018 07:44 PM, Bartlomiej Zolnierkiewicz wrote: > Entry for Index 941 has one zero too much. Fix it. > Acked-by: Keerthy <j-keerthy@ti.com> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > --- > v2: > - Fix patch description. > > drivers/thermal/ti-soc-thermal/omap5-thermal-data.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: b/drivers/thermal/ti-soc-thermal/omap5-thermal-data.c > =================================================================== > --- a/drivers/thermal/ti-soc-thermal/omap5-thermal-data.c 2018-04-30 16:23:42.000000000 +0200 > +++ b/drivers/thermal/ti-soc-thermal/omap5-thermal-data.c 2018-05-02 14:16:09.461434201 +0200 > @@ -310,7 +310,7 @@ omap5430_adc_to_temp[ > 119800, 120200, 120600, 121000, 121400, 121800, 122400, 122600, 123000, > 123400, > /* Index 940 - 945 */ > - 123800, 1242000, 124600, 124900, 125000, 125000, > + 123800, 124200, 124600, 124900, 125000, 125000, > }; > > /* OMAP54xx ES2.0 data */ > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] thermal: ti-soc-thermal: fix incorrect entry in omap5430_adc_to_temp[] 2018-05-02 14:14 ` [PATCH v2] thermal: ti-soc-thermal: fix incorrect entry in omap5430_adc_to_temp[] Bartlomiej Zolnierkiewicz 2018-05-02 15:44 ` Keerthy @ 2018-05-02 15:49 ` Daniel Lezcano 2018-05-02 16:20 ` Bartlomiej Zolnierkiewicz 1 sibling, 1 reply; 5+ messages in thread From: Daniel Lezcano @ 2018-05-02 15:49 UTC (permalink / raw) To: Bartlomiej Zolnierkiewicz Cc: Eduardo Valentin, Keerthy, Zhang Rui, linux-pm, linux-omap, linux-kernel On Wed, May 02, 2018 at 04:14:32PM +0200, Bartlomiej Zolnierkiewicz wrote: > Entry for Index 941 has one zero too much. Fix it. > > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Good catch :) I'm curious, how did you spot it ? > --- > v2: > - Fix patch description. > > drivers/thermal/ti-soc-thermal/omap5-thermal-data.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: b/drivers/thermal/ti-soc-thermal/omap5-thermal-data.c > =================================================================== > --- a/drivers/thermal/ti-soc-thermal/omap5-thermal-data.c 2018-04-30 16:23:42.000000000 +0200 > +++ b/drivers/thermal/ti-soc-thermal/omap5-thermal-data.c 2018-05-02 14:16:09.461434201 +0200 > @@ -310,7 +310,7 @@ omap5430_adc_to_temp[ > 119800, 120200, 120600, 121000, 121400, 121800, 122400, 122600, 123000, > 123400, > /* Index 940 - 945 */ > - 123800, 1242000, 124600, 124900, 125000, 125000, > + 123800, 124200, 124600, 124900, 125000, 125000, > }; > > /* OMAP54xx ES2.0 data */ > -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] thermal: ti-soc-thermal: fix incorrect entry in omap5430_adc_to_temp[] 2018-05-02 15:49 ` Daniel Lezcano @ 2018-05-02 16:20 ` Bartlomiej Zolnierkiewicz 0 siblings, 0 replies; 5+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2018-05-02 16:20 UTC (permalink / raw) To: Daniel Lezcano Cc: Eduardo Valentin, Keerthy, Zhang Rui, linux-pm, linux-omap, linux-kernel On Wednesday, May 02, 2018 05:49:31 PM Daniel Lezcano wrote: > On Wed, May 02, 2018 at 04:14:32PM +0200, Bartlomiej Zolnierkiewicz wrote: > > Entry for Index 941 has one zero too much. Fix it. > > > > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > > Good catch :) Thanks. :) > I'm curious, how did you spot it ? While I was reading the driver code I've noticed that omap5430_adc_to_temp[] and dra752_adc_to_temp[] look pretty similar so I've diff-ed them to find the actual differences (+ to see if one of the tables can be removed). One of such differences was the line containing the incorrect entry. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-05-02 16:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20180502141432eucas1p1c85aa366979b73c59a46ec0c2f7ef8e6@eucas1p1.samsung.com>
2018-05-02 14:14 ` [PATCH v2] thermal: ti-soc-thermal: fix incorrect entry in omap5430_adc_to_temp[] Bartlomiej Zolnierkiewicz
2018-05-02 15:44 ` Keerthy
2018-05-02 15:44 ` Keerthy
2018-05-02 15:49 ` Daniel Lezcano
2018-05-02 16:20 ` Bartlomiej Zolnierkiewicz
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.