All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Rui Miguel Silva <rui.silva@linaro.org>
Cc: devel@driverdev.osuosl.org, devicetree@vger.kernel.org,
	sakari.ailus@linux.intel.com,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Ryan Harkin <ryan.harkin@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Steve Longerbeam <slongerbeam@gmail.com>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	mchehab@kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH v2 10/15] ARM: dts: imx7s: add multiplexer controls
Date: Thu, 3 May 2018 11:05:03 +0800	[thread overview]
Message-ID: <20180503030501.GQ3443@dragon> (raw)
In-Reply-To: <20180423134750.30403-11-rui.silva@linaro.org>

On Mon, Apr 23, 2018 at 02:47:45PM +0100, Rui Miguel Silva wrote:
> The IOMUXC General Purpose Register has bitfield to control video bus
> multiplexer to control the CSI input between the MIPI-CSI2 and parallel
> interface. Add that register and mask.
> 
> Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org>
> ---
>  arch/arm/boot/dts/imx7s.dtsi | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi
> index d913c3f9c284..3027d6a62021 100644
> --- a/arch/arm/boot/dts/imx7s.dtsi
> +++ b/arch/arm/boot/dts/imx7s.dtsi
> @@ -534,8 +534,15 @@
>  
>  			gpr: iomuxc-gpr@30340000 {
>  				compatible = "fsl,imx7d-iomuxc-gpr",
> -					"fsl,imx6q-iomuxc-gpr", "syscon";
> +					"fsl,imx6q-iomuxc-gpr", "syscon", "simple-mfd";
>  				reg = <0x30340000 0x10000>;
> +
> +				mux: mux-controller {
> +					compatible = "mmio-mux";
> +					#mux-control-cells = <1>;
> +

The newline in between property list is not really necessary.

Shawn

> +					mux-reg-masks = <0x14 0x00000010>;
> +				};
>  			};
>  
>  			ocotp: ocotp-ctrl@30350000 {
> -- 
> 2.17.0
> 

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Rui Miguel Silva <rui.silva@linaro.org>
Cc: mchehab@kernel.org, sakari.ailus@linux.intel.com,
	Steve Longerbeam <slongerbeam@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Rob Herring <robh+dt@kernel.org>,
	linux-media@vger.kernel.org, devel@driverdev.osuosl.org,
	Fabio Estevam <fabio.estevam@nxp.com>,
	devicetree@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Ryan Harkin <ryan.harkin@linaro.org>
Subject: Re: [PATCH v2 10/15] ARM: dts: imx7s: add multiplexer controls
Date: Thu, 3 May 2018 11:05:03 +0800	[thread overview]
Message-ID: <20180503030501.GQ3443@dragon> (raw)
In-Reply-To: <20180423134750.30403-11-rui.silva@linaro.org>

On Mon, Apr 23, 2018 at 02:47:45PM +0100, Rui Miguel Silva wrote:
> The IOMUXC General Purpose Register has bitfield to control video bus
> multiplexer to control the CSI input between the MIPI-CSI2 and parallel
> interface. Add that register and mask.
> 
> Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org>
> ---
>  arch/arm/boot/dts/imx7s.dtsi | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi
> index d913c3f9c284..3027d6a62021 100644
> --- a/arch/arm/boot/dts/imx7s.dtsi
> +++ b/arch/arm/boot/dts/imx7s.dtsi
> @@ -534,8 +534,15 @@
>  
>  			gpr: iomuxc-gpr@30340000 {
>  				compatible = "fsl,imx7d-iomuxc-gpr",
> -					"fsl,imx6q-iomuxc-gpr", "syscon";
> +					"fsl,imx6q-iomuxc-gpr", "syscon", "simple-mfd";
>  				reg = <0x30340000 0x10000>;
> +
> +				mux: mux-controller {
> +					compatible = "mmio-mux";
> +					#mux-control-cells = <1>;
> +

The newline in between property list is not really necessary.

Shawn

> +					mux-reg-masks = <0x14 0x00000010>;
> +				};
>  			};
>  
>  			ocotp: ocotp-ctrl@30350000 {
> -- 
> 2.17.0
> 

  reply	other threads:[~2018-05-03  3:05 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-23 13:47 [PATCH v2 00/15] media: staging/imx7: add i.MX7 media driver Rui Miguel Silva
2018-04-23 13:47 ` Rui Miguel Silva
2018-04-23 13:47 ` [PATCH v2 01/15] media: staging/imx: add support to media dev for no IPU systems Rui Miguel Silva
2018-04-23 13:47   ` Rui Miguel Silva
2018-04-23 13:47 ` [PATCH v2 02/15] media: staging/imx7: add imx7 CSI subdev driver Rui Miguel Silva
2018-04-23 13:47   ` Rui Miguel Silva
2018-04-23 13:47 ` [PATCH v2 03/15] clk: imx7d: fix mipi dphy div parent Rui Miguel Silva
2018-04-23 13:47   ` Rui Miguel Silva
2018-05-01 22:11   ` Stephen Boyd
2018-05-01 22:11     ` Stephen Boyd
2018-05-03  1:08   ` Shawn Guo
2018-05-03  1:08     ` Shawn Guo
2018-05-03  1:50     ` A.s. Dong
2018-05-03  1:50       ` A.s. Dong
2018-05-03  1:50       ` A.s. Dong
2018-04-23 13:47 ` [PATCH v2 04/15] clk: imx7d: reset parent for mipi csi root Rui Miguel Silva
2018-04-23 13:47   ` Rui Miguel Silva
2018-05-03  2:27   ` Shawn Guo
2018-05-03  2:27     ` Shawn Guo
2018-04-23 13:47 ` [PATCH v2 05/15] media: staging/imx7: add MIPI CSI-2 receiver subdev for i.MX7 Rui Miguel Silva
2018-04-23 13:47   ` Rui Miguel Silva
2018-04-23 13:47 ` [PATCH v2 06/15] media: staging/imx: add imx7 capture subsystem Rui Miguel Silva
2018-04-23 13:47   ` Rui Miguel Silva
2018-04-23 15:48   ` Philipp Zabel
2018-04-23 15:48     ` Philipp Zabel
2018-04-24  8:46     ` Rui Miguel Silva
2018-04-24  8:46       ` Rui Miguel Silva
2018-04-23 13:47 ` [PATCH v2 07/15] ARM: dts: increase default cma size to 40MB Rui Miguel Silva
2018-04-23 13:47   ` Rui Miguel Silva
2018-05-03  2:40   ` Shawn Guo
2018-05-03  2:40     ` Shawn Guo
2018-04-23 13:47 ` [PATCH v2 08/15] media: dt-bindings: add bindings for i.MX7 media driver Rui Miguel Silva
2018-04-23 13:47   ` Rui Miguel Silva
2018-04-27 19:06   ` Rob Herring
2018-04-27 19:06     ` Rob Herring
2018-05-07 16:28     ` Rui Miguel Silva
2018-05-07 16:28       ` Rui Miguel Silva
2018-04-23 13:47 ` [PATCH v2 09/15] ARM: dts: imx7s: add mipi phy power domain Rui Miguel Silva
2018-04-23 13:47   ` Rui Miguel Silva
2018-04-23 13:47 ` [PATCH v2 10/15] ARM: dts: imx7s: add multiplexer controls Rui Miguel Silva
2018-04-23 13:47   ` Rui Miguel Silva
2018-05-03  3:05   ` Shawn Guo [this message]
2018-05-03  3:05     ` Shawn Guo
2018-04-23 13:47 ` [PATCH v2 11/15] ARM: dts: imx7: Add video mux, csi and mipi_csi and connections Rui Miguel Silva
2018-04-23 13:47   ` Rui Miguel Silva
2018-04-23 15:46   ` Philipp Zabel
2018-04-23 15:46     ` Philipp Zabel
2018-04-24  8:50     ` Rui Miguel Silva
2018-04-24  8:50       ` Rui Miguel Silva
2018-04-23 13:47 ` [PATCH v2 12/15] ARM: dts: imx7s: add capture subsystem Rui Miguel Silva
2018-04-23 13:47   ` Rui Miguel Silva
2018-04-23 13:47 ` [PATCH v2 13/15] ARM: dts: imx7s-warp: add ov2680 sensor node Rui Miguel Silva
2018-04-23 13:47   ` Rui Miguel Silva
2018-04-23 13:47 ` [PATCH v2 14/15] media: imx7.rst: add documentation for i.MX7 media driver Rui Miguel Silva
2018-04-23 13:47   ` Rui Miguel Silva
2018-04-23 13:47 ` [PATCH v2 15/15] media: staging/imx: add i.MX7 entries to TODO file Rui Miguel Silva
2018-04-23 13:47   ` Rui Miguel Silva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180503030501.GQ3443@dragon \
    --to=shawnguo@kernel.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=devicetree@vger.kernel.org \
    --cc=fabio.estevam@nxp.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=rui.silva@linaro.org \
    --cc=ryan.harkin@linaro.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=slongerbeam@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.