From: Pavel Machek <pavel@ucw.cz>
To: Tony Lindgren <tony@atomide.com>
Cc: kernel list <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-omap@vger.kernel.org, sre@kernel.org, nekit1000@gmail.com,
mpartap@gmx.net, merlijn@wizzup.org
Subject: Re: Droid 4: very confusing config around OHCI_OMAP3_HCD
Date: Thu, 3 May 2018 21:38:38 +0200 [thread overview]
Message-ID: <20180503193837.GC32572@amd> (raw)
In-Reply-To: <20180503192838.GY98604@atomide.com>
[-- Attachment #1: Type: text/plain, Size: 2096 bytes --]
On Thu 2018-05-03 12:28:38, Tony Lindgren wrote:
> * Pavel Machek <pavel@ucw.cz> [180503 19:27]:
> > Hi!
> >
> > For power management experiments, I tried
> >
> > CONFIG_USB_OHCI_HCD=y
> > CONFIG_USB_OHCI_HCD_OMAP3=m
> > CONFIG_USB_OHCI_HCD_PLATFORM=y
> >
> > and could not find resulting .ko.
> >
> > Help text says:
> >
> > CONFIG_USB_OHCI_HCD_OMAP3:
> >
> > This option is deprecated now and the driver was removed, use
> > USB_OHCI_HCD_PLATFORM instead.
> >
> > Enables support for the on-chip OHCI controller on
> > OMAP3 and later chips.
> >
> > Which may partly explain it. But if the option no longer does
> > anything, why keep it? Certainly second part is confusing if option is
> > NOP...
>
> Yeah it's ohci-platform now, I think we decided to keep the old one
> around to avoid breaking people's .config files for booting rather
> than silently fail.
Ok, what about this? (Should I do the same for the other drivers?)
Or at least put (DEPRECATED) as other drivers do?
Situation is quite confusing if you already have PLATFORM=y. OMAP=m
can be selected, but nothing happens.
diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
index 5d958da..67c151a 100644
--- a/drivers/usb/host/Kconfig
+++ b/drivers/usb/host/Kconfig
@@ -455,7 +455,7 @@ config USB_OHCI_HCD_AT91
Atmel chips.
config USB_OHCI_HCD_OMAP3
- tristate "OHCI support for OMAP3 and later chips"
+ tristate "dummy option for backwards compatibility"
depends on (ARCH_OMAP3 || ARCH_OMAP4 || SOC_OMAP5)
select USB_OHCI_HCD_PLATFORM
default y
@@ -463,9 +463,6 @@ config USB_OHCI_HCD_OMAP3
This option is deprecated now and the driver was removed, use
USB_OHCI_HCD_PLATFORM instead.
- Enables support for the on-chip OHCI controller on
- OMAP3 and later chips.
-
config USB_OHCI_HCD_DAVINCI
tristate "OHCI support for TI DaVinci DA8xx"
depends on ARCH_DAVINCI_DA8XX
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: pavel@ucw.cz (Pavel Machek)
To: linux-arm-kernel@lists.infradead.org
Subject: Droid 4: very confusing config around OHCI_OMAP3_HCD
Date: Thu, 3 May 2018 21:38:38 +0200 [thread overview]
Message-ID: <20180503193837.GC32572@amd> (raw)
In-Reply-To: <20180503192838.GY98604@atomide.com>
On Thu 2018-05-03 12:28:38, Tony Lindgren wrote:
> * Pavel Machek <pavel@ucw.cz> [180503 19:27]:
> > Hi!
> >
> > For power management experiments, I tried
> >
> > CONFIG_USB_OHCI_HCD=y
> > CONFIG_USB_OHCI_HCD_OMAP3=m
> > CONFIG_USB_OHCI_HCD_PLATFORM=y
> >
> > and could not find resulting .ko.
> >
> > Help text says:
> >
> > CONFIG_USB_OHCI_HCD_OMAP3:
> >
> > This option is deprecated now and the driver was removed, use
> > USB_OHCI_HCD_PLATFORM instead.
> >
> > Enables support for the on-chip OHCI controller on
> > OMAP3 and later chips.
> >
> > Which may partly explain it. But if the option no longer does
> > anything, why keep it? Certainly second part is confusing if option is
> > NOP...
>
> Yeah it's ohci-platform now, I think we decided to keep the old one
> around to avoid breaking people's .config files for booting rather
> than silently fail.
Ok, what about this? (Should I do the same for the other drivers?)
Or at least put (DEPRECATED) as other drivers do?
Situation is quite confusing if you already have PLATFORM=y. OMAP=m
can be selected, but nothing happens.
diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
index 5d958da..67c151a 100644
--- a/drivers/usb/host/Kconfig
+++ b/drivers/usb/host/Kconfig
@@ -455,7 +455,7 @@ config USB_OHCI_HCD_AT91
Atmel chips.
config USB_OHCI_HCD_OMAP3
- tristate "OHCI support for OMAP3 and later chips"
+ tristate "dummy option for backwards compatibility"
depends on (ARCH_OMAP3 || ARCH_OMAP4 || SOC_OMAP5)
select USB_OHCI_HCD_PLATFORM
default y
@@ -463,9 +463,6 @@ config USB_OHCI_HCD_OMAP3
This option is deprecated now and the driver was removed, use
USB_OHCI_HCD_PLATFORM instead.
- Enables support for the on-chip OHCI controller on
- OMAP3 and later chips.
-
config USB_OHCI_HCD_DAVINCI
tristate "OHCI support for TI DaVinci DA8xx"
depends on ARCH_DAVINCI_DA8XX
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180503/9205ad12/attachment.sig>
next prev parent reply other threads:[~2018-05-03 19:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 19:25 Droid 4: very confusing config around OHCI_OMAP3_HCD Pavel Machek
2018-05-03 19:25 ` Pavel Machek
2018-05-03 19:28 ` Tony Lindgren
2018-05-03 19:28 ` Tony Lindgren
2018-05-03 19:38 ` Pavel Machek [this message]
2018-05-03 19:38 ` Pavel Machek
2018-05-03 22:07 ` Tony Lindgren
2018-05-03 22:07 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180503193837.GC32572@amd \
--to=pavel@ucw.cz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=merlijn@wizzup.org \
--cc=mpartap@gmx.net \
--cc=nekit1000@gmail.com \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.