From: "Michael S. Tsirkin" <mst@redhat.com>
To: Amit Shah <amit@amitshah.net>
Cc: linux-kernel@vger.kernel.org, Amit Shah <amit@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
virtualization@lists.linux-foundation.org,
stable@vger.kernel.org, Tiwei Bie <tiwei.bie@intel.com>,
Jason Wang <jasowang@redhat.com>
Subject: Re: [PATCH 0/6] virtio-console: spec compliance fixes
Date: Thu, 3 May 2018 22:28:32 +0300 [thread overview]
Message-ID: <20180503222702-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20180503034529.GA16676@grmbl.mre>
On Thu, May 03, 2018 at 05:45:29AM +0200, Amit Shah wrote:
> (apologies if you received a dup)
>
> On (Tue) 24 Apr 2018 [21:41:29], Michael S. Tsirkin wrote:
> > On Fri, Apr 20, 2018 at 09:17:59PM +0300, Michael S. Tsirkin wrote:
> > > Turns out virtio console tries to take a buffer out of an active vq.
> > > Works by sheer luck, and is explicitly forbidden by spec. And while
> > > going over it I saw that error handling is also broken -
> > > failure is easy to trigger if I force allocations to fail.
> > >
> > > Lightly tested.
> >
> > Amit - any feedback before I push these patches?
>
> The changes look good spec-wise.
>
> There are a bunch of tests in avocado-vt that test virtio-console
> functionality. Can you give those a try before pushing?
>
> Amit
I pushed before I did that test, will try to find the time later. BTW
do you still want to be on the maintainers list?
> --
> http://amitshah.net/
next prev parent reply other threads:[~2018-05-03 19:28 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-20 18:18 [PATCH 0/6] virtio-console: spec compliance fixes Michael S. Tsirkin
2018-04-20 18:18 ` [PATCH 1/6] virtio_console: don't tie bufs to a vq Michael S. Tsirkin
2018-04-20 18:18 ` Michael S. Tsirkin
2018-04-21 7:30 ` Greg Kroah-Hartman
2018-04-24 18:56 ` Michael S. Tsirkin
2018-04-25 5:50 ` Greg Kroah-Hartman
2018-04-25 5:50 ` Greg Kroah-Hartman
2018-04-24 18:56 ` Michael S. Tsirkin
2018-04-21 7:30 ` Greg Kroah-Hartman
2018-04-20 18:18 ` [PATCH 3/6] virtio_console: free buffers after reset Michael S. Tsirkin
2018-04-20 18:18 ` Michael S. Tsirkin
2018-04-24 2:40 ` Jason Wang
2018-04-24 2:40 ` Jason Wang
2018-04-20 18:18 ` [PATCH 2/6] virtio: add ability to iterate over vqs Michael S. Tsirkin
2018-04-20 18:18 ` Michael S. Tsirkin
2018-04-20 18:18 ` [PATCH 4/6] virtio_console: drop custom control queue cleanup Michael S. Tsirkin
2018-04-20 18:18 ` Michael S. Tsirkin
2018-04-20 18:18 ` [PATCH 5/6] virtio_console: move removal code Michael S. Tsirkin
2018-04-20 18:18 ` Michael S. Tsirkin
2018-04-20 18:18 ` [PATCH 6/6] virtio_console: reset on out of memory Michael S. Tsirkin
2018-04-20 18:18 ` Michael S. Tsirkin
2018-04-24 18:41 ` [PATCH 0/6] virtio-console: spec compliance fixes Michael S. Tsirkin
2018-04-24 18:41 ` Michael S. Tsirkin
2018-04-25 14:01 ` Amit Shah
2018-05-03 3:34 ` Amit Shah
2018-05-03 3:34 ` Amit Shah
2018-05-03 3:45 ` Amit Shah
2018-05-03 19:28 ` Michael S. Tsirkin [this message]
2018-05-06 17:56 ` Amit Shah
2018-05-06 17:56 ` Amit Shah
2018-05-06 18:24 ` Amit Shah
2018-05-06 19:52 ` Michael S. Tsirkin
2018-05-06 19:52 ` Michael S. Tsirkin
2018-05-03 19:28 ` Michael S. Tsirkin
-- strict thread matches above, loose matches on Subject: below --
2018-04-20 18:18 Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180503222702-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=amit@amitshah.net \
--cc=amit@kernel.org \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tiwei.bie@intel.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.