From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH] ARM: dts: imx: replace underscore with hyphen in aliases name
Date: Fri, 4 May 2018 16:15:08 +0800 [thread overview]
Message-ID: <20180504081506.GZ3443@dragon> (raw)
In-Reply-To: <20180504085248.532c8a47@karo-electronics.de>
On Fri, May 04, 2018 at 08:52:48AM +0200, Lothar Wa?mann wrote:
> Hi,
>
> On Fri, 4 May 2018 09:58:48 +0800 Shawn Guo wrote:
> > It replaces underscore with hyphen in aliases name to fix DTC
> > alias_paths warning below, which is seen with various i.MX board dts
> > files when W=1 switch is on.
> >
> > Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-'
> >
> > Cc: Lothar Wa?mann <LW@KARO-electronics.de>
> > Cc: Gary Bisson <gary.bisson@boundarydevices.com>
> > Signed-off-by: Shawn Guo <shawnguo@kernel.org>
> > ---
> > Hi Lothar, Gary,
> >
> > Per my search on kernel code, this change will not break anything on
> > kernel support. But I'm not really sure about the case of bootloaders
> > running on the boards. That's why I'm sending it as RFC.
> >
> > We really want i.MX to be the first-class citizen in the community.
> > After a few cycles efforts on cleaning up DTC warnings, this alias_paths
> > warning is the last one we see with i.MX dts files. We really want to
> > get rid of it and make i.MX dts be DTC warning free.
> >
> > So please comment whether we can merge this patch.
> >
> This breaks our U-Boot which searches for the alias names with '_'.
> But I think it's not worth keeping the old names alive, since the
> problem can easily be fixed by adding the old alias name to the FDT
> on affected boards from within U-Boot, if necessary.
>
> Alternatively we could add a:
> reg_can_xcvr = "reg-can-xcvr";
> [...]
> so that the respective aliases can be resolved using both names for a
> while.
Appreciate it.
>
> So:
> Acked-By: Lothar Wa?mann <LW@KARO-electronics.de>
Thanks, Lothar.
Shawn
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: "Lothar Waßmann" <LW@KARO-electronics.de>
Cc: devicetree@vger.kernel.org,
Gary Bisson <gary.bisson@boundarydevices.com>,
Rob Herring <robh+dt@kernel.org>,
linux-imx@nxp.com, kernel@pengutronix.de,
Fabio Estevam <fabio.estevam@nxp.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH] ARM: dts: imx: replace underscore with hyphen in aliases name
Date: Fri, 4 May 2018 16:15:08 +0800 [thread overview]
Message-ID: <20180504081506.GZ3443@dragon> (raw)
In-Reply-To: <20180504085248.532c8a47@karo-electronics.de>
On Fri, May 04, 2018 at 08:52:48AM +0200, Lothar Waßmann wrote:
> Hi,
>
> On Fri, 4 May 2018 09:58:48 +0800 Shawn Guo wrote:
> > It replaces underscore with hyphen in aliases name to fix DTC
> > alias_paths warning below, which is seen with various i.MX board dts
> > files when W=1 switch is on.
> >
> > Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-'
> >
> > Cc: Lothar Waßmann <LW@KARO-electronics.de>
> > Cc: Gary Bisson <gary.bisson@boundarydevices.com>
> > Signed-off-by: Shawn Guo <shawnguo@kernel.org>
> > ---
> > Hi Lothar, Gary,
> >
> > Per my search on kernel code, this change will not break anything on
> > kernel support. But I'm not really sure about the case of bootloaders
> > running on the boards. That's why I'm sending it as RFC.
> >
> > We really want i.MX to be the first-class citizen in the community.
> > After a few cycles efforts on cleaning up DTC warnings, this alias_paths
> > warning is the last one we see with i.MX dts files. We really want to
> > get rid of it and make i.MX dts be DTC warning free.
> >
> > So please comment whether we can merge this patch.
> >
> This breaks our U-Boot which searches for the alias names with '_'.
> But I think it's not worth keeping the old names alive, since the
> problem can easily be fixed by adding the old alias name to the FDT
> on affected boards from within U-Boot, if necessary.
>
> Alternatively we could add a:
> reg_can_xcvr = "reg-can-xcvr";
> [...]
> so that the respective aliases can be resolved using both names for a
> while.
Appreciate it.
>
> So:
> Acked-By: Lothar Waßmann <LW@KARO-electronics.de>
Thanks, Lothar.
Shawn
next prev parent reply other threads:[~2018-05-04 8:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-04 1:58 [RFC PATCH] ARM: dts: imx: replace underscore with hyphen in aliases name Shawn Guo
2018-05-04 1:58 ` Shawn Guo
2018-05-04 6:52 ` Lothar Waßmann
2018-05-04 6:52 ` Lothar Waßmann
2018-05-04 8:15 ` Shawn Guo [this message]
2018-05-04 8:15 ` Shawn Guo
2018-05-04 7:40 ` Gary Bisson
2018-05-04 7:40 ` Gary Bisson
2018-05-04 8:15 ` Shawn Guo
2018-05-04 8:15 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180504081506.GZ3443@dragon \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.