From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: imx6sx-sabreauto: add egalax touch screen support
Date: Fri, 4 May 2018 16:27:34 +0800 [thread overview]
Message-ID: <20180504082733.GC3443@dragon> (raw)
In-Reply-To: <1524813650-19241-1-git-send-email-Anson.Huang@nxp.com>
On Fri, Apr 27, 2018 at 03:20:50PM +0800, Anson Huang wrote:
> From: Haibo Chen <haibo.chen@nxp.com>
>
> Add egalax touch screen support on i2c2 bus.
>
> Signed-off-by: Haibo Chen <haibo.chen@freescale.com>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> this patch is based on patch (ARM: dts: imx6sx-sabreauto: add debug LED support) I sent out for review.
> arch/arm/boot/dts/imx6sx-sabreauto.dts | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6sx-sabreauto.dts b/arch/arm/boot/dts/imx6sx-sabreauto.dts
> index 6b94f24..2f6e474 100644
> --- a/arch/arm/boot/dts/imx6sx-sabreauto.dts
> +++ b/arch/arm/boot/dts/imx6sx-sabreauto.dts
> @@ -131,6 +131,12 @@
> &iomuxc {
> imx6x-sabreauto {
>
> + pinctrl_egalax_int: egalax_intgrp {
General recommendation: use hyphen instead of underscore in the node
node.
> + fsl,pins = <
> + MX6SX_PAD_SD4_RESET_B__GPIO6_IO_22 0x80000000
> + >;
> + };
> +
> pinctrl_led: ledgrp {
> fsl,pins = <
> MX6SX_PAD_CSI_PIXCLK__GPIO1_IO_24 0x17059
> @@ -274,6 +280,16 @@
> pinctrl-0 = <&pinctrl_i2c2_1>;
> status = "okay";
>
> + egalax_ts at 04 {
Use generic node name - touchscreen, as recommended by Devicetree
Specification, and drop leading zeros in unit-address.
Shawn
> + compatible = "eeti,egalax_ts";
> + reg = <0x04>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_egalax_int>;
> + interrupt-parent = <&gpio6>;
> + interrupts = <22 IRQ_TYPE_EDGE_FALLING>;
> + wakeup-gpios = <&gpio6 22 GPIO_ACTIVE_HIGH>;
> + };
> +
> max7322: gpio at 68 {
> compatible = "maxim,max7322";
> reg = <0x68>;
> --
> 2.7.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Anson Huang <Anson.Huang@nxp.com>
Cc: kernel@pengutronix.de, fabio.estevam@nxp.com, robh+dt@kernel.org,
mark.rutland@arm.com, haibo.chen@nxp.com,
devicetree@vger.kernel.org, Linux-imx@nxp.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: imx6sx-sabreauto: add egalax touch screen support
Date: Fri, 4 May 2018 16:27:34 +0800 [thread overview]
Message-ID: <20180504082733.GC3443@dragon> (raw)
In-Reply-To: <1524813650-19241-1-git-send-email-Anson.Huang@nxp.com>
On Fri, Apr 27, 2018 at 03:20:50PM +0800, Anson Huang wrote:
> From: Haibo Chen <haibo.chen@nxp.com>
>
> Add egalax touch screen support on i2c2 bus.
>
> Signed-off-by: Haibo Chen <haibo.chen@freescale.com>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> this patch is based on patch (ARM: dts: imx6sx-sabreauto: add debug LED support) I sent out for review.
> arch/arm/boot/dts/imx6sx-sabreauto.dts | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6sx-sabreauto.dts b/arch/arm/boot/dts/imx6sx-sabreauto.dts
> index 6b94f24..2f6e474 100644
> --- a/arch/arm/boot/dts/imx6sx-sabreauto.dts
> +++ b/arch/arm/boot/dts/imx6sx-sabreauto.dts
> @@ -131,6 +131,12 @@
> &iomuxc {
> imx6x-sabreauto {
>
> + pinctrl_egalax_int: egalax_intgrp {
General recommendation: use hyphen instead of underscore in the node
node.
> + fsl,pins = <
> + MX6SX_PAD_SD4_RESET_B__GPIO6_IO_22 0x80000000
> + >;
> + };
> +
> pinctrl_led: ledgrp {
> fsl,pins = <
> MX6SX_PAD_CSI_PIXCLK__GPIO1_IO_24 0x17059
> @@ -274,6 +280,16 @@
> pinctrl-0 = <&pinctrl_i2c2_1>;
> status = "okay";
>
> + egalax_ts@04 {
Use generic node name - touchscreen, as recommended by Devicetree
Specification, and drop leading zeros in unit-address.
Shawn
> + compatible = "eeti,egalax_ts";
> + reg = <0x04>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_egalax_int>;
> + interrupt-parent = <&gpio6>;
> + interrupts = <22 IRQ_TYPE_EDGE_FALLING>;
> + wakeup-gpios = <&gpio6 22 GPIO_ACTIVE_HIGH>;
> + };
> +
> max7322: gpio@68 {
> compatible = "maxim,max7322";
> reg = <0x68>;
> --
> 2.7.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-05-04 8:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-27 7:20 [PATCH] ARM: dts: imx6sx-sabreauto: add egalax touch screen support Anson Huang
2018-04-27 7:20 ` Anson Huang
2018-05-04 8:27 ` Shawn Guo [this message]
2018-05-04 8:27 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180504082733.GC3443@dragon \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.