From: Oleg Nesterov <oleg@redhat.com>
To: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Cc: mhiramat@kernel.org,
Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>,
peterz@infradead.org, srikar@linux.vnet.ibm.com,
rostedt@goodmis.org, acme@kernel.org, ananth@linux.vnet.ibm.com,
akpm@linux-foundation.org, alexander.shishkin@linux.intel.com,
alexis.berlemont@gmail.com, corbet@lwn.net,
dan.j.williams@intel.com, jolsa@redhat.com, kan.liang@intel.com,
kjlx@templeofstupid.com, kstewart@linuxfoundation.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, milian.wolff@kdab.com, mingo@redhat.com,
namhyung@kernel.org, naveen.n.rao@linux.vnet.ibm.com,
pc@us.ibm.com, tglx@linutronix.de, yao.jin@linux.intel.com,
fengguang.wu@intel.com, jglisse@redhat.com
Subject: Re: [PATCH v3 0/9] trace_uprobe: Support SDT markers having reference count (semaphore)
Date: Fri, 4 May 2018 16:30:21 +0200 [thread overview]
Message-ID: <20180504143021.GB26151@redhat.com> (raw)
In-Reply-To: <f77789c0-9277-23bf-9abb-92f3f36c4baa@linux.ibm.com>
Sorry Ravi, I saved the new version for review and forgot about it... I'll
try to do this on weekend.
On 05/03, Ravi Bangoria wrote:
>
> On 04/17/2018 10:02 AM, Ravi Bangoria wrote:
> > Userspace Statically Defined Tracepoints[1] are dtrace style markers
> > inside userspace applications. Applications like PostgreSQL, MySQL,
> > Pthread, Perl, Python, Java, Ruby, Node.js, libvirt, QEMU, glib etc
> > have these markers embedded in them. These markers are added by developer
> > at important places in the code. Each marker source expands to a single
> > nop instruction in the compiled code but there may be additional
> > overhead for computing the marker arguments which expands to couple of
> > instructions. In case the overhead is more, execution of it can be
> > omitted by runtime if() condition when no one is tracing on the marker:
> >
> > if (reference_counter > 0) {
> > Execute marker instructions;
> > }
> >
> > Default value of reference counter is 0. Tracer has to increment the
> > reference counter before tracing on a marker and decrement it when
> > done with the tracing.
>
> Hi Oleg, Masami,
>
> Can you please review this :) ?
>
> Thanks.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Oleg Nesterov <oleg@redhat.com>
To: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Cc: mhiramat@kernel.org,
Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>,
peterz@infradead.org, srikar@linux.vnet.ibm.com,
rostedt@goodmis.org, acme@kernel.org, ananth@linux.vnet.ibm.com,
akpm@linux-foundation.org, alexander.shishkin@linux.intel.com,
alexis.berlemont@gmail.com, corbet@lwn.net,
dan.j.williams@intel.com, jolsa@redhat.com, kan.liang@intel.com,
kjlx@templeofstupid.com, kstewart@linuxfoundation.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, milian.wolff@kdab.com, mingo@redhat.com,
namhyung@kernel.org, naveen.n.rao@linux.vnet.ibm.com,
pc@us.ibm.com, tglx@linutronix.de, yao.jin@linux.intel.com,
fengguang.wu@intel.com, jglisse@redhat.com
Subject: Re: [PATCH v3 0/9] trace_uprobe: Support SDT markers having reference count (semaphore)
Date: Fri, 4 May 2018 16:30:21 +0200 [thread overview]
Message-ID: <20180504143021.GB26151@redhat.com> (raw)
In-Reply-To: <f77789c0-9277-23bf-9abb-92f3f36c4baa@linux.ibm.com>
Sorry Ravi, I saved the new version for review and forgot about it... I'll
try to do this on weekend.
On 05/03, Ravi Bangoria wrote:
>
> On 04/17/2018 10:02 AM, Ravi Bangoria wrote:
> > Userspace Statically Defined Tracepoints[1] are dtrace style markers
> > inside userspace applications. Applications like PostgreSQL, MySQL,
> > Pthread, Perl, Python, Java, Ruby, Node.js, libvirt, QEMU, glib etc
> > have these markers embedded in them. These markers are added by developer
> > at important places in the code. Each marker source expands to a single
> > nop instruction in the compiled code but there may be additional
> > overhead for computing the marker arguments which expands to couple of
> > instructions. In case the overhead is more, execution of it can be
> > omitted by runtime if() condition when no one is tracing on the marker:
> >
> > if (reference_counter > 0) {
> > Execute marker instructions;
> > }
> >
> > Default value of reference counter is 0. Tracer has to increment the
> > reference counter before tracing on a marker and decrement it when
> > done with the tracing.
>
> Hi Oleg, Masami,
>
> Can you please review this :) ?
>
> Thanks.
>
next prev parent reply other threads:[~2018-05-04 14:30 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 4:32 [PATCH v3 0/9] trace_uprobe: Support SDT markers having reference count (semaphore) Ravi Bangoria
2018-04-17 4:32 ` Ravi Bangoria
2018-04-17 4:32 ` [PATCH v3 1/9] Uprobe: Export vaddr <-> offset conversion functions Ravi Bangoria
2018-04-17 4:32 ` Ravi Bangoria
2018-04-17 4:32 ` Ravi Bangoria
2018-04-17 4:32 ` [PATCH v3 2/9] mm: Prefix vma_ to vaddr_to_offset() and offset_to_vaddr() Ravi Bangoria
2018-04-17 4:32 ` Ravi Bangoria
2018-04-17 4:32 ` Ravi Bangoria
2018-05-03 14:59 ` Steven Rostedt
2018-05-03 14:59 ` Steven Rostedt
2018-04-17 4:32 ` [PATCH v3 3/9] Uprobe: Move mmput() into free_map_info() Ravi Bangoria
2018-04-17 4:32 ` Ravi Bangoria
2018-04-17 4:32 ` [PATCH v3 4/9] Uprobe: Rename map_info to uprobe_map_info Ravi Bangoria
2018-04-17 4:32 ` Ravi Bangoria
2018-04-17 4:32 ` Ravi Bangoria
2018-04-17 4:32 ` [PATCH v3 5/9] Uprobe: Export uprobe_map_info along with uprobe_{build/free}_map_info() Ravi Bangoria
2018-04-17 4:32 ` Ravi Bangoria
2018-04-17 4:32 ` Ravi Bangoria
2018-04-17 4:32 ` [PATCH v3 6/9] trace_uprobe: Support SDT markers having reference count (semaphore) Ravi Bangoria
2018-04-17 4:32 ` Ravi Bangoria
2018-05-04 4:48 ` Masami Hiramatsu
2018-05-04 4:48 ` Masami Hiramatsu
2018-05-04 14:21 ` Ravi Bangoria
2018-05-04 14:21 ` Ravi Bangoria
2018-05-07 8:21 ` Ravi Bangoria
2018-05-07 8:21 ` Ravi Bangoria
2018-05-07 15:56 ` Masami Hiramatsu
2018-05-07 15:56 ` Masami Hiramatsu
2018-05-08 9:46 ` Naveen N. Rao
2018-05-08 9:46 ` Naveen N. Rao
2018-05-08 10:26 ` Ravi Bangoria
2018-05-08 10:26 ` Ravi Bangoria
2018-05-24 16:26 ` Oleg Nesterov
2018-05-24 16:26 ` Oleg Nesterov
2018-05-25 8:28 ` Ravi Bangoria
2018-05-25 8:28 ` Ravi Bangoria
2018-04-17 4:32 ` [PATCH v3 7/9] trace_uprobe/sdt: Fix multiple update of same reference counter Ravi Bangoria
2018-04-17 4:32 ` Ravi Bangoria
2018-04-17 4:32 ` [PATCH v3 8/9] trace_uprobe/sdt: Document about " Ravi Bangoria
2018-04-17 4:32 ` Ravi Bangoria
2018-05-03 14:57 ` Masami Hiramatsu
2018-05-03 14:57 ` Masami Hiramatsu
2018-04-17 4:32 ` [PATCH v3 9/9] perf probe: Support SDT markers having reference counter (semaphore) Ravi Bangoria
2018-04-17 4:32 ` Ravi Bangoria
2018-05-03 14:57 ` Masami Hiramatsu
2018-05-03 14:57 ` Masami Hiramatsu
2018-05-03 8:32 ` [PATCH v3 0/9] trace_uprobe: Support SDT markers having reference count (semaphore) Ravi Bangoria
2018-05-03 8:32 ` Ravi Bangoria
2018-05-04 14:30 ` Oleg Nesterov [this message]
2018-05-04 14:30 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180504143021.GB26151@redhat.com \
--to=oleg@redhat.com \
--cc=acme@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexis.berlemont@gmail.com \
--cc=ananth@linux.vnet.ibm.com \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=fengguang.wu@intel.com \
--cc=jglisse@redhat.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=kjlx@templeofstupid.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhiramat@kernel.org \
--cc=milian.wolff@kdab.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=pc@us.ibm.com \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@linux.ibm.com \
--cc=ravi.bangoria@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
--cc=srikar@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.