All of lore.kernel.org
 help / color / mirror / Atom feed
From: shuah at kernel.org (Shuah Khan (Samsung OSG))
Subject: [PATCH 12/24] selftests: ipc: return Kselftest Skip code for skipped tests
Date: Fri,  4 May 2018 19:13:16 -0600	[thread overview]
Message-ID: <20180505011328.32078-12-shuah@kernel.org> (raw)
In-Reply-To: <20180505011328.32078-1-shuah@kernel.org>

When ipc test is skipped because of unmet dependencies and/or
unsupported configuration, it exits with error which is treated as
a fail by the Kselftest framework. This leads to false negative
result even when the test could not be run.

Change it to return kselftest skip code when a test gets skipped to
clearly report that the test could not be run.

Change it to use ksft_exit_skip() when the test is skipped.

Signed-off-by: Shuah Khan (Samsung OSG) <shuah at kernel.org>
---
 tools/testing/selftests/ipc/msgque.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/tools/testing/selftests/ipc/msgque.c b/tools/testing/selftests/ipc/msgque.c
index ee9382bdfadc..dac927e82336 100644
--- a/tools/testing/selftests/ipc/msgque.c
+++ b/tools/testing/selftests/ipc/msgque.c
@@ -196,10 +196,9 @@ int main(int argc, char **argv)
 	int msg, pid, err;
 	struct msgque_data msgque;
 
-	if (getuid() != 0) {
-		printf("Please run the test as root - Exiting.\n");
-		return ksft_exit_fail();
-	}
+	if (getuid() != 0)
+		return ksft_exit_skip(
+				"Please run the test as root - Exiting.\n");
 
 	msgque.key = ftok(argv[0], 822155650);
 	if (msgque.key == -1) {
-- 
2.14.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: shuah@kernel.org (Shuah Khan (Samsung OSG))
Subject: [PATCH 12/24] selftests: ipc: return Kselftest Skip code for skipped tests
Date: Fri,  4 May 2018 19:13:16 -0600	[thread overview]
Message-ID: <20180505011328.32078-12-shuah@kernel.org> (raw)
Message-ID: <20180505011316.Rz6adSj_KMAyPYdEwK27h7P6Lign_FmwtJqcGyaIUWI@z> (raw)
In-Reply-To: <20180505011328.32078-1-shuah@kernel.org>

When ipc test is skipped because of unmet dependencies and/or
unsupported configuration, it exits with error which is treated as
a fail by the Kselftest framework. This leads to false negative
result even when the test could not be run.

Change it to return kselftest skip code when a test gets skipped to
clearly report that the test could not be run.

Change it to use ksft_exit_skip() when the test is skipped.

Signed-off-by: Shuah Khan (Samsung OSG) <shuah at kernel.org>
---
 tools/testing/selftests/ipc/msgque.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/tools/testing/selftests/ipc/msgque.c b/tools/testing/selftests/ipc/msgque.c
index ee9382bdfadc..dac927e82336 100644
--- a/tools/testing/selftests/ipc/msgque.c
+++ b/tools/testing/selftests/ipc/msgque.c
@@ -196,10 +196,9 @@ int main(int argc, char **argv)
 	int msg, pid, err;
 	struct msgque_data msgque;
 
-	if (getuid() != 0) {
-		printf("Please run the test as root - Exiting.\n");
-		return ksft_exit_fail();
-	}
+	if (getuid() != 0)
+		return ksft_exit_skip(
+				"Please run the test as root - Exiting.\n");
 
 	msgque.key = ftok(argv[0], 822155650);
 	if (msgque.key == -1) {
-- 
2.14.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: "Shuah Khan (Samsung OSG)" <shuah@kernel.org>
To: shuah@kernel.org
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 12/24] selftests: ipc: return Kselftest Skip code for skipped tests
Date: Fri,  4 May 2018 19:13:16 -0600	[thread overview]
Message-ID: <20180505011328.32078-12-shuah@kernel.org> (raw)
In-Reply-To: <20180505011328.32078-1-shuah@kernel.org>

When ipc test is skipped because of unmet dependencies and/or
unsupported configuration, it exits with error which is treated as
a fail by the Kselftest framework. This leads to false negative
result even when the test could not be run.

Change it to return kselftest skip code when a test gets skipped to
clearly report that the test could not be run.

Change it to use ksft_exit_skip() when the test is skipped.

Signed-off-by: Shuah Khan (Samsung OSG) <shuah@kernel.org>
---
 tools/testing/selftests/ipc/msgque.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/tools/testing/selftests/ipc/msgque.c b/tools/testing/selftests/ipc/msgque.c
index ee9382bdfadc..dac927e82336 100644
--- a/tools/testing/selftests/ipc/msgque.c
+++ b/tools/testing/selftests/ipc/msgque.c
@@ -196,10 +196,9 @@ int main(int argc, char **argv)
 	int msg, pid, err;
 	struct msgque_data msgque;
 
-	if (getuid() != 0) {
-		printf("Please run the test as root - Exiting.\n");
-		return ksft_exit_fail();
-	}
+	if (getuid() != 0)
+		return ksft_exit_skip(
+				"Please run the test as root - Exiting.\n");
 
 	msgque.key = ftok(argv[0], 822155650);
 	if (msgque.key == -1) {
-- 
2.14.1

  parent reply	other threads:[~2018-05-05  1:13 UTC|newest]

Thread overview: 123+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-05  1:13 [PATCH 01/24] selftests: android: ion: return Kselftest Skip code for skipped tests shuah
2018-05-05  1:13 ` Shuah Khan (Samsung OSG)
2018-05-05  1:13 ` Shuah Khan (Samsung OSG)
2018-05-05  1:13 ` [PATCH 02/24] selftests: breakpoints: " shuah
2018-05-05  1:13   ` Shuah Khan (Samsung OSG)
2018-05-05  1:13   ` Shuah Khan (Samsung OSG)
2018-05-05  1:13 ` [PATCH 03/24] selftests: cpu-hotplug: " shuah
2018-05-05  1:13   ` Shuah Khan (Samsung OSG)
2018-05-05  1:13   ` Shuah Khan (Samsung OSG)
2018-05-05  1:13 ` [PATCH 04/24] selftests: cpufreq: " shuah
2018-05-05  1:13   ` Shuah Khan (Samsung OSG)
2018-05-05  1:13   ` Shuah Khan (Samsung OSG)
2018-05-07  5:01   ` viresh.kumar
2018-05-07  5:01     ` Viresh Kumar
2018-05-07  5:01     ` Viresh Kumar
2018-05-05  1:13 ` [PATCH 05/24] selftests: efivarfs: " shuah
2018-05-05  1:13   ` Shuah Khan (Samsung OSG)
2018-05-05  1:13   ` Shuah Khan (Samsung OSG)
2018-05-05  1:13 ` [PATCH 06/24] selftests: exec: " shuah
2018-05-05  1:13   ` Shuah Khan (Samsung OSG)
2018-05-05  1:13   ` Shuah Khan (Samsung OSG)
2018-05-08  0:03   ` smuckle.linux
2018-05-08  0:03     ` Steve Muckle
2018-05-08  0:03     ` Steve Muckle
2018-05-05  1:13 ` [PATCH 07/24] selftests: filesystems: " shuah
2018-05-05  1:13   ` Shuah Khan (Samsung OSG)
2018-05-05  1:13   ` Shuah Khan (Samsung OSG)
2018-05-06  8:15   ` christian.brauner
2018-05-06  8:15     ` Christian Brauner
2018-05-06  8:15     ` Christian Brauner
2018-05-05  1:13 ` [PATCH 08/24] selftests: firmware: " shuah
2018-05-05  1:13   ` Shuah Khan (Samsung OSG)
2018-05-05  1:13   ` Shuah Khan (Samsung OSG)
2018-05-09 19:27   ` mcgrof
2018-05-09 19:27     ` Luis R. Rodriguez
2018-05-09 19:27     ` Luis R. Rodriguez
2018-05-05  1:13 ` [PATCH 09/24] selftests: ftrace: " shuah
2018-05-05  1:13   ` Shuah Khan (Samsung OSG)
2018-05-05  1:13   ` Shuah Khan (Samsung OSG)
2018-05-07 15:17   ` rostedt
2018-05-07 15:17     ` Steven Rostedt
2018-05-07 15:17     ` Steven Rostedt
2018-05-08  3:29     ` mhiramat
2018-05-08  3:29       ` Masami Hiramatsu
2018-05-08  3:29       ` Masami Hiramatsu
2018-05-08  3:38   ` mhiramat
2018-05-08  3:38     ` Masami Hiramatsu
2018-05-08  3:38     ` Masami Hiramatsu
2018-05-10 20:18     ` shuah
2018-05-10 20:18       ` Shuah Khan
2018-05-10 20:18       ` Shuah Khan
2018-05-11  6:09       ` mhiramat
2018-05-11  6:09         ` Masami Hiramatsu
2018-05-11  6:09         ` Masami Hiramatsu
2018-05-05  1:13 ` [PATCH 10/24] selftests: gpio: " Shuah Khan (Samsung OSG)
2018-05-05  1:13   ` Shuah Khan (Samsung OSG)
2018-05-05  1:13   ` shuah
2018-05-05  1:13 ` [PATCH 11/24] selftests: intel_pstate: " shuah
2018-05-05  1:13   ` Shuah Khan (Samsung OSG)
2018-05-05  1:13   ` Shuah Khan (Samsung OSG)
2018-05-05  1:13 ` shuah [this message]
2018-05-05  1:13   ` [PATCH 12/24] selftests: ipc: " Shuah Khan (Samsung OSG)
2018-05-05  1:13   ` Shuah Khan (Samsung OSG)
2018-05-05  1:13 ` [PATCH 13/24] selftests: kmod: " shuah
2018-05-05  1:13   ` Shuah Khan (Samsung OSG)
2018-05-05  1:13   ` Shuah Khan (Samsung OSG)
2018-05-09 19:28   ` mcgrof
2018-05-09 19:28     ` Luis R. Rodriguez
2018-05-09 19:28     ` Luis R. Rodriguez
2018-05-05  1:13 ` [PATCH 14/24] selftests: kvm: " shuah
2018-05-05  1:13   ` Shuah Khan (Samsung OSG)
2018-05-05  1:13   ` Shuah Khan (Samsung OSG)
2018-05-07 11:46   ` pbonzini
2018-05-07 11:46     ` Paolo Bonzini
2018-05-07 11:46     ` Paolo Bonzini
2018-05-07 19:41     ` shuah
2018-05-07 19:41       ` Shuah Khan
2018-05-07 19:41       ` Shuah Khan
2018-05-07 20:19       ` shuah
2018-05-07 20:19         ` Shuah Khan
2018-05-07 20:19         ` Shuah Khan
2018-05-05  1:13 ` [PATCH 15/24] selftests: lib: add prime_numbers.sh test to Makefile shuah
2018-05-05  1:13   ` Shuah Khan (Samsung OSG)
2018-05-05  1:13   ` Shuah Khan (Samsung OSG)
2018-05-05  1:13 ` [PATCH 16/24] selftests: lib: return Kselftest Skip code for skipped tests shuah
2018-05-05  1:13   ` Shuah Khan (Samsung OSG)
2018-05-05  1:13   ` Shuah Khan (Samsung OSG)
2018-05-05  1:13 ` [PATCH 17/24] selftests: locking: add Makefile for locking test shuah
2018-05-05  1:13   ` Shuah Khan (Samsung OSG)
2018-05-05  1:13   ` Shuah Khan (Samsung OSG)
2018-05-05  1:13 ` [PATCH 18/24] selftests: locking: return Kselftest Skip code for skipped tests shuah
2018-05-05  1:13   ` Shuah Khan (Samsung OSG)
2018-05-05  1:13   ` Shuah Khan (Samsung OSG)
2018-05-05  1:13 ` [PATCH 19/24] selftests: media_tests: " shuah
2018-05-05  1:13   ` Shuah Khan (Samsung OSG)
2018-05-05  1:13   ` Shuah Khan (Samsung OSG)
2018-05-05  1:13 ` [PATCH 20/24] selftests: membarrier: " shuah
2018-05-05  1:13   ` Shuah Khan (Samsung OSG)
2018-05-05  1:13   ` Shuah Khan (Samsung OSG)
2018-05-05  1:13 ` [PATCH 21/24] selftests: memfd: " shuah
2018-05-05  1:13   ` Shuah Khan (Samsung OSG)
2018-05-05  1:13   ` Shuah Khan (Samsung OSG)
2018-05-05  1:52   ` mike.kravetz
2018-05-05  1:52     ` Mike Kravetz
2018-05-05  1:52     ` Mike Kravetz
2018-05-07 18:45     ` shuah
2018-05-07 18:45       ` Shuah Khan
2018-05-07 18:45       ` Shuah Khan
2018-05-07 21:16       ` shuah
2018-05-07 21:16         ` Shuah Khan
2018-05-07 21:16         ` Shuah Khan
2018-05-05  1:13 ` [PATCH 22/24] selftests: memory-hotplug: " shuah
2018-05-05  1:13   ` Shuah Khan (Samsung OSG)
2018-05-05  1:13   ` Shuah Khan (Samsung OSG)
2018-05-05  1:13 ` [PATCH 23/24] selftests: mqueue: " shuah
2018-05-05  1:13   ` Shuah Khan (Samsung OSG)
2018-05-05  1:13   ` Shuah Khan (Samsung OSG)
2018-05-05  1:13 ` [PATCH 24/24] selftests: net: " shuah
2018-05-05  1:13   ` Shuah Khan (Samsung OSG)
2018-05-05  1:13   ` Shuah Khan (Samsung OSG)
2018-05-07 11:04 ` [PATCH 01/24] selftests: android: ion: " pintu.ping
2018-05-07 11:04   ` Pintu Kumar
2018-05-07 11:04   ` Pintu Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180505011328.32078-12-shuah@kernel.org \
    --to=unknown@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.