From: Johan Hovold <johan@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>, Johan Hovold <johan@kernel.org>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Pavel Machek <pavel@ucw.cz>,
linux-serial@vger.kernel.org, linux-leds@vger.kernel.org,
linux-can@vger.kernel.org, kernel@pengutronix.de,
One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
Florian Fainelli <f.fainelli@gmail.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
linux-kernel@vger.kernel.org, Robin Murphy <robin.murphy@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 3/3] tty: implement led triggers
Date: Tue, 8 May 2018 12:08:51 +0200 [thread overview]
Message-ID: <20180508100851.GY2285@localhost> (raw)
In-Reply-To: <20180508100543.12559-4-u.kleine-koenig@pengutronix.de>
On Tue, May 08, 2018 at 12:05:43PM +0200, Uwe Kleine-König wrote:
> The rx trigger fires when data is pushed to the ldisc by the driver. This
> is a bit later than the actual receiving of data but has the nice benefit
> that it doesn't need adaption for each driver and isn't in the hot path.
>
> Similarly the tx trigger fires when data was copied from userspace and is
> given to the ldisc.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> arch/arm/boot/dts/imx25-logitech-baby.dts | 192 ++++++++++++++++++++++
Looks like you included more than intended in this patch.
> drivers/tty/Kconfig | 7 +
> drivers/tty/tty_buffer.c | 2 +
> drivers/tty/tty_io.c | 3 +
> drivers/tty/tty_port.c | 32 +++-
> include/linux/tty.h | 22 +++
> 6 files changed, 256 insertions(+), 2 deletions(-)
> create mode 100644 arch/arm/boot/dts/imx25-logitech-baby.dts
Johan
WARNING: multiple messages have this Message-ID (diff)
From: johan@kernel.org (Johan Hovold)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 3/3] tty: implement led triggers
Date: Tue, 8 May 2018 12:08:51 +0200 [thread overview]
Message-ID: <20180508100851.GY2285@localhost> (raw)
In-Reply-To: <20180508100543.12559-4-u.kleine-koenig@pengutronix.de>
On Tue, May 08, 2018 at 12:05:43PM +0200, Uwe Kleine-K?nig wrote:
> The rx trigger fires when data is pushed to the ldisc by the driver. This
> is a bit later than the actual receiving of data but has the nice benefit
> that it doesn't need adaption for each driver and isn't in the hot path.
>
> Similarly the tx trigger fires when data was copied from userspace and is
> given to the ldisc.
>
> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> ---
> arch/arm/boot/dts/imx25-logitech-baby.dts | 192 ++++++++++++++++++++++
Looks like you included more than intended in this patch.
> drivers/tty/Kconfig | 7 +
> drivers/tty/tty_buffer.c | 2 +
> drivers/tty/tty_io.c | 3 +
> drivers/tty/tty_port.c | 32 +++-
> include/linux/tty.h | 22 +++
> 6 files changed, 256 insertions(+), 2 deletions(-)
> create mode 100644 arch/arm/boot/dts/imx25-logitech-baby.dts
Johan
next prev parent reply other threads:[~2018-05-08 10:08 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-08 10:05 [PATCH v3 0/3] led_trigger_register_format and tty triggers Uwe Kleine-König
2018-05-08 10:05 ` Uwe Kleine-König
2018-05-08 10:05 ` [PATCH v3 1/3] leds: triggers: provide led_trigger_register_format() Uwe Kleine-König
2018-05-08 10:05 ` Uwe Kleine-König
2018-05-08 19:33 ` Jacek Anaszewski
2018-05-08 19:33 ` Jacek Anaszewski
2018-05-08 20:17 ` Uwe Kleine-König
2018-05-08 20:17 ` Uwe Kleine-König
2018-05-09 19:57 ` Jacek Anaszewski
2018-05-09 19:57 ` Jacek Anaszewski
2018-05-10 11:21 ` Pavel Machek
2018-05-10 11:21 ` Pavel Machek
2018-05-10 11:22 ` Pavel Machek
2018-05-10 11:22 ` Pavel Machek
2018-05-12 18:59 ` Uwe Kleine-König
2018-05-12 18:59 ` Uwe Kleine-König
2018-05-13 14:34 ` Andy Shevchenko
2018-05-13 14:34 ` Andy Shevchenko
2018-05-08 10:05 ` [PATCH v3 2/3] can: simplify LED trigger handling Uwe Kleine-König
2018-05-08 10:05 ` Uwe Kleine-König
2018-05-08 11:04 ` Marc Kleine-Budde
2018-05-08 11:04 ` Marc Kleine-Budde
2018-05-08 10:05 ` [PATCH v3 3/3] tty: implement led triggers Uwe Kleine-König
2018-05-08 10:05 ` Uwe Kleine-König
2018-05-08 10:08 ` Johan Hovold [this message]
2018-05-08 10:08 ` Johan Hovold
2018-05-08 10:51 ` Uwe Kleine-König
2018-05-08 10:51 ` Uwe Kleine-König
2018-05-13 14:23 ` Andy Shevchenko
2018-05-13 14:23 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180508100851.GY2285@localhost \
--to=johan@kernel.org \
--cc=f.fainelli@gmail.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=jacek.anaszewski@gmail.com \
--cc=jslaby@suse.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=pavel@ucw.cz \
--cc=robin.murphy@arm.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.