From: robh@kernel.org (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: dts: juno: fix missing Coresight STM graph connection
Date: Tue, 8 May 2018 10:09:50 -0500 [thread overview]
Message-ID: <20180508150952.24562-2-robh@kernel.org> (raw)
In-Reply-To: <20180508150952.24562-1-robh@kernel.org>
OF graph endpoint connections must be bidirectional. Fix 2 missing
connections to the STM output port:
arch/arm64/boot/dts/arm/juno-r1.dtb: Warning (graph_endpoint): /stm at 20100000/port/endpoint: graph connection to node '/funnel at 20130000/ports/port at 1/endpoint' is not bidirectional
arch/arm64/boot/dts/arm/juno-r2.dtb: Warning (graph_endpoint): /stm at 20100000/port/endpoint: graph connection to node '/funnel at 20130000/ports/port at 1/endpoint' is not bidirectional
Fixes: cde6f9ab10c6 ("arm64: dts: juno: add missing CoreSight STM component")
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: Mike Leach <mike.leach@linaro.org>
Cc: Liviu Dudau <liviu.dudau@arm.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Signed-off-by: Rob Herring <robh@kernel.org>
---
arch/arm64/boot/dts/arm/juno-r1.dts | 4 ++++
arch/arm64/boot/dts/arm/juno-r2.dts | 4 ++++
2 files changed, 8 insertions(+)
diff --git a/arch/arm64/boot/dts/arm/juno-r1.dts b/arch/arm64/boot/dts/arm/juno-r1.dts
index aed6389468c4..c52c5c40dede 100644
--- a/arch/arm64/boot/dts/arm/juno-r1.dts
+++ b/arch/arm64/boot/dts/arm/juno-r1.dts
@@ -278,6 +278,10 @@
remote-endpoint = <&csys2_funnel_out_port>;
};
+&csys1_funnel_in_port0 {
+ remote-endpoint = <&stm_out_port>;
+};
+
&stm_out_port {
remote-endpoint = <&csys1_funnel_in_port0>;
};
diff --git a/arch/arm64/boot/dts/arm/juno-r2.dts b/arch/arm64/boot/dts/arm/juno-r2.dts
index b39b6d6ec5aa..a90982ceda35 100644
--- a/arch/arm64/boot/dts/arm/juno-r2.dts
+++ b/arch/arm64/boot/dts/arm/juno-r2.dts
@@ -278,6 +278,10 @@
remote-endpoint = <&csys2_funnel_out_port>;
};
+&csys1_funnel_in_port0 {
+ remote-endpoint = <&stm_out_port>;
+};
+
&stm_out_port {
remote-endpoint = <&csys1_funnel_in_port0>;
};
--
2.17.0
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Liviu Dudau <liviu.dudau@arm.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Mike Leach <mike.leach@linaro.org>
Subject: [PATCH] arm64: dts: juno: fix missing Coresight STM graph connection
Date: Tue, 8 May 2018 10:09:50 -0500 [thread overview]
Message-ID: <20180508150952.24562-2-robh@kernel.org> (raw)
In-Reply-To: <20180508150952.24562-1-robh@kernel.org>
OF graph endpoint connections must be bidirectional. Fix 2 missing
connections to the STM output port:
arch/arm64/boot/dts/arm/juno-r1.dtb: Warning (graph_endpoint): /stm@20100000/port/endpoint: graph connection to node '/funnel@20130000/ports/port@1/endpoint' is not bidirectional
arch/arm64/boot/dts/arm/juno-r2.dtb: Warning (graph_endpoint): /stm@20100000/port/endpoint: graph connection to node '/funnel@20130000/ports/port@1/endpoint' is not bidirectional
Fixes: cde6f9ab10c6 ("arm64: dts: juno: add missing CoreSight STM component")
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: Mike Leach <mike.leach@linaro.org>
Cc: Liviu Dudau <liviu.dudau@arm.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Signed-off-by: Rob Herring <robh@kernel.org>
---
arch/arm64/boot/dts/arm/juno-r1.dts | 4 ++++
arch/arm64/boot/dts/arm/juno-r2.dts | 4 ++++
2 files changed, 8 insertions(+)
diff --git a/arch/arm64/boot/dts/arm/juno-r1.dts b/arch/arm64/boot/dts/arm/juno-r1.dts
index aed6389468c4..c52c5c40dede 100644
--- a/arch/arm64/boot/dts/arm/juno-r1.dts
+++ b/arch/arm64/boot/dts/arm/juno-r1.dts
@@ -278,6 +278,10 @@
remote-endpoint = <&csys2_funnel_out_port>;
};
+&csys1_funnel_in_port0 {
+ remote-endpoint = <&stm_out_port>;
+};
+
&stm_out_port {
remote-endpoint = <&csys1_funnel_in_port0>;
};
diff --git a/arch/arm64/boot/dts/arm/juno-r2.dts b/arch/arm64/boot/dts/arm/juno-r2.dts
index b39b6d6ec5aa..a90982ceda35 100644
--- a/arch/arm64/boot/dts/arm/juno-r2.dts
+++ b/arch/arm64/boot/dts/arm/juno-r2.dts
@@ -278,6 +278,10 @@
remote-endpoint = <&csys2_funnel_out_port>;
};
+&csys1_funnel_in_port0 {
+ remote-endpoint = <&stm_out_port>;
+};
+
&stm_out_port {
remote-endpoint = <&csys1_funnel_in_port0>;
};
--
2.17.0
next prev parent reply other threads:[~2018-05-08 15:09 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-08 15:09 [PATCH] arm64: dts: juno: fix OF graph endpoint node names Rob Herring
2018-05-08 15:09 ` Rob Herring
2018-05-08 15:09 ` Rob Herring [this message]
2018-05-08 15:09 ` [PATCH] arm64: dts: juno: fix missing Coresight STM graph connection Rob Herring
2018-05-08 15:09 ` [PATCH] arm64: dts: msm8916: fix Coresight ETF graph connections Rob Herring
2018-05-08 15:09 ` Rob Herring
2018-05-23 20:29 ` Rob Herring
2018-05-23 20:29 ` Rob Herring
2018-05-24 4:48 ` Ivan T. Ivanov
2018-05-24 4:48 ` Ivan T. Ivanov
2018-05-24 16:32 ` Mathieu Poirier
2018-05-24 16:32 ` Mathieu Poirier
2018-05-25 22:46 ` Andy Gross
2018-05-25 22:46 ` Andy Gross
2018-05-08 15:09 ` [PATCH] arm64: dts: sprd: fix typo in 'remote-endpoint' Rob Herring
2018-05-08 15:09 ` Rob Herring
2018-05-09 1:58 ` Chunyan Zhang
2018-05-09 1:58 ` Chunyan Zhang
2018-05-23 20:30 ` Rob Herring
2018-05-23 20:30 ` Rob Herring
2018-05-24 5:27 ` Baolin Wang
2018-05-24 5:27 ` Baolin Wang
2018-05-25 2:36 ` Chunyan Zhang
2018-05-25 2:36 ` Chunyan Zhang
2018-05-25 22:11 ` Olof Johansson
2018-05-25 22:11 ` Olof Johansson
2018-05-08 15:15 ` [PATCH] arm64: dts: juno: fix OF graph endpoint node names Liviu Dudau
2018-05-08 15:15 ` Liviu Dudau
2018-05-09 16:34 ` Sudeep Holla
2018-05-09 16:34 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180508150952.24562-2-robh@kernel.org \
--to=robh@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.