* [PATCH] drm/i915: Remove unused i915_flip tracepoints
@ 2018-05-08 15:15 Chris Wilson
2018-05-08 15:35 ` Ville Syrjälä
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Chris Wilson @ 2018-05-08 15:15 UTC (permalink / raw)
To: intel-gfx; +Cc: Daniel Vetter
The i915_flip* tracepoints are no longer in use since the removal of CS
flip in commit 8b5d27b911d7 ("drm/i915: Remove intel_flip_work
infrastructure")
References: 8b5d27b911d7 ("drm/i915: Remove intel_flip_work infrastructure")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/i915/i915_trace.h | 36 -------------------------------
1 file changed, 36 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_trace.h b/drivers/gpu/drm/i915/i915_trace.h
index 77ee5e53eb32..8cc3a256f29d 100644
--- a/drivers/gpu/drm/i915/i915_trace.h
+++ b/drivers/gpu/drm/i915/i915_trace.h
@@ -834,42 +834,6 @@ DEFINE_EVENT(i915_request, i915_request_wait_end,
TP_ARGS(rq)
);
-TRACE_EVENT(i915_flip_request,
- TP_PROTO(int plane, struct drm_i915_gem_object *obj),
-
- TP_ARGS(plane, obj),
-
- TP_STRUCT__entry(
- __field(int, plane)
- __field(struct drm_i915_gem_object *, obj)
- ),
-
- TP_fast_assign(
- __entry->plane = plane;
- __entry->obj = obj;
- ),
-
- TP_printk("plane=%d, obj=%p", __entry->plane, __entry->obj)
-);
-
-TRACE_EVENT(i915_flip_complete,
- TP_PROTO(int plane, struct drm_i915_gem_object *obj),
-
- TP_ARGS(plane, obj),
-
- TP_STRUCT__entry(
- __field(int, plane)
- __field(struct drm_i915_gem_object *, obj)
- ),
-
- TP_fast_assign(
- __entry->plane = plane;
- __entry->obj = obj;
- ),
-
- TP_printk("plane=%d, obj=%p", __entry->plane, __entry->obj)
-);
-
TRACE_EVENT_CONDITION(i915_reg_rw,
TP_PROTO(bool write, i915_reg_t reg, u64 val, int len, bool trace),
--
2.17.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] drm/i915: Remove unused i915_flip tracepoints
2018-05-08 15:15 [PATCH] drm/i915: Remove unused i915_flip tracepoints Chris Wilson
@ 2018-05-08 15:35 ` Ville Syrjälä
2018-05-08 20:50 ` Chris Wilson
2018-05-08 16:46 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Ville Syrjälä @ 2018-05-08 15:35 UTC (permalink / raw)
To: Chris Wilson; +Cc: Daniel Vetter, intel-gfx
On Tue, May 08, 2018 at 04:15:52PM +0100, Chris Wilson wrote:
> The i915_flip* tracepoints are no longer in use since the removal of CS
> flip in commit 8b5d27b911d7 ("drm/i915: Remove intel_flip_work
> infrastructure")
>
> References: 8b5d27b911d7 ("drm/i915: Remove intel_flip_work infrastructure")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Daniel Vetter <daniel.vetter@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_trace.h | 36 -------------------------------
> 1 file changed, 36 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_trace.h b/drivers/gpu/drm/i915/i915_trace.h
> index 77ee5e53eb32..8cc3a256f29d 100644
> --- a/drivers/gpu/drm/i915/i915_trace.h
> +++ b/drivers/gpu/drm/i915/i915_trace.h
> @@ -834,42 +834,6 @@ DEFINE_EVENT(i915_request, i915_request_wait_end,
> TP_ARGS(rq)
> );
>
> -TRACE_EVENT(i915_flip_request,
> - TP_PROTO(int plane, struct drm_i915_gem_object *obj),
> -
> - TP_ARGS(plane, obj),
> -
> - TP_STRUCT__entry(
> - __field(int, plane)
> - __field(struct drm_i915_gem_object *, obj)
> - ),
> -
> - TP_fast_assign(
> - __entry->plane = plane;
> - __entry->obj = obj;
> - ),
> -
> - TP_printk("plane=%d, obj=%p", __entry->plane, __entry->obj)
> -);
> -
> -TRACE_EVENT(i915_flip_complete,
> - TP_PROTO(int plane, struct drm_i915_gem_object *obj),
> -
> - TP_ARGS(plane, obj),
> -
> - TP_STRUCT__entry(
> - __field(int, plane)
> - __field(struct drm_i915_gem_object *, obj)
> - ),
> -
> - TP_fast_assign(
> - __entry->plane = plane;
> - __entry->obj = obj;
> - ),
> -
> - TP_printk("plane=%d, obj=%p", __entry->plane, __entry->obj)
> -);
> -
> TRACE_EVENT_CONDITION(i915_reg_rw,
> TP_PROTO(bool write, i915_reg_t reg, u64 val, int len, bool trace),
>
> --
> 2.17.0
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/i915: Remove unused i915_flip tracepoints
2018-05-08 15:35 ` Ville Syrjälä
@ 2018-05-08 20:50 ` Chris Wilson
0 siblings, 0 replies; 6+ messages in thread
From: Chris Wilson @ 2018-05-08 20:50 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: Daniel Vetter, intel-gfx
Quoting Ville Syrjälä (2018-05-08 16:35:18)
> On Tue, May 08, 2018 at 04:15:52PM +0100, Chris Wilson wrote:
> > The i915_flip* tracepoints are no longer in use since the removal of CS
> > flip in commit 8b5d27b911d7 ("drm/i915: Remove intel_flip_work
> > infrastructure")
> >
> > References: 8b5d27b911d7 ("drm/i915: Remove intel_flip_work infrastructure")
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Cc: Daniel Vetter <daniel.vetter@intel.com>
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Pushed, many thanks for the review.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Remove unused i915_flip tracepoints
2018-05-08 15:15 [PATCH] drm/i915: Remove unused i915_flip tracepoints Chris Wilson
2018-05-08 15:35 ` Ville Syrjälä
@ 2018-05-08 16:46 ` Patchwork
2018-05-08 17:03 ` ✓ Fi.CI.BAT: success " Patchwork
2018-05-08 20:18 ` ✗ Fi.CI.IGT: failure " Patchwork
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-05-08 16:46 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Remove unused i915_flip tracepoints
URL : https://patchwork.freedesktop.org/series/42879/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
31b71b60b3a0 drm/i915: Remove unused i915_flip tracepoints
-:13: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#13:
References: 8b5d27b911d7 ("drm/i915: Remove intel_flip_work infrastructure")
-:13: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 8b5d27b911d7 ("drm/i915: Remove intel_flip_work infrastructure")'
#13:
References: 8b5d27b911d7 ("drm/i915: Remove intel_flip_work infrastructure")
total: 1 errors, 1 warnings, 0 checks, 42 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915: Remove unused i915_flip tracepoints
2018-05-08 15:15 [PATCH] drm/i915: Remove unused i915_flip tracepoints Chris Wilson
2018-05-08 15:35 ` Ville Syrjälä
2018-05-08 16:46 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2018-05-08 17:03 ` Patchwork
2018-05-08 20:18 ` ✗ Fi.CI.IGT: failure " Patchwork
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-05-08 17:03 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Remove unused i915_flip tracepoints
URL : https://patchwork.freedesktop.org/series/42879/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4158 -> Patchwork_8945 =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_8945 need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_8945, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/42879/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_8945:
=== IGT changes ===
==== Warnings ====
igt@kms_force_connector_basic@force-edid:
fi-ivb-3520m: PASS -> SKIP +3
== Known issues ==
Here are the changes found in Patchwork_8945 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_chamelium@dp-edid-read:
fi-kbl-7500u: PASS -> FAIL (fdo#103841)
==== Possible fixes ====
igt@drv_module_reload@basic-reload:
fi-bsw-n3050: DMESG-FAIL (fdo#106373) -> PASS
igt@gem_exec_suspend@basic-s3:
fi-skl-guc: FAIL (fdo#104699, fdo#105900) -> PASS
igt@gem_exec_suspend@basic-s4-devices:
fi-kbl-7500u: DMESG-WARN (fdo#105128) -> PASS
igt@gem_mmap_gtt@basic-small-bo-tiledx:
fi-gdg-551: FAIL (fdo#102575) -> PASS
igt@kms_frontbuffer_tracking@basic:
fi-hsw-4200u: DMESG-FAIL (fdo#102614, fdo#106103) -> PASS
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-snb-2520m: INCOMPLETE (fdo#103713) -> PASS
fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#103841 https://bugs.freedesktop.org/show_bug.cgi?id=103841
fdo#104699 https://bugs.freedesktop.org/show_bug.cgi?id=104699
fdo#105128 https://bugs.freedesktop.org/show_bug.cgi?id=105128
fdo#105900 https://bugs.freedesktop.org/show_bug.cgi?id=105900
fdo#106103 https://bugs.freedesktop.org/show_bug.cgi?id=106103
fdo#106373 https://bugs.freedesktop.org/show_bug.cgi?id=106373
== Participating hosts (40 -> 37) ==
Additional (1): fi-byt-j1900
Missing (4): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-skl-6700hq
== Build changes ==
* Linux: CI_DRM_4158 -> Patchwork_8945
CI_DRM_4158: b4cf5831333d423c2420f167111c03e4c1729672 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4465: 41eb85f918b02918787fc59d9cb5aab93b81f323 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_8945: 31b71b60b3a083a072d36fd15472cb63a65fa890 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4465: 33e58d5583eb7ed3966a1b905f875a1dfa959f6b @ git://anongit.freedesktop.org/piglit
== Linux commits ==
31b71b60b3a0 drm/i915: Remove unused i915_flip tracepoints
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8945/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* ✗ Fi.CI.IGT: failure for drm/i915: Remove unused i915_flip tracepoints
2018-05-08 15:15 [PATCH] drm/i915: Remove unused i915_flip tracepoints Chris Wilson
` (2 preceding siblings ...)
2018-05-08 17:03 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2018-05-08 20:18 ` Patchwork
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-05-08 20:18 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Remove unused i915_flip tracepoints
URL : https://patchwork.freedesktop.org/series/42879/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_4158_full -> Patchwork_8945_full =
== Summary - FAILURE ==
Serious unknown changes coming with Patchwork_8945_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_8945_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/42879/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_8945_full:
=== IGT changes ===
==== Possible regressions ====
igt@perf_pmu@busy-accuracy-98-bcs0:
shard-apl: PASS -> FAIL
==== Warnings ====
igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-onoff:
shard-hsw: SKIP -> PASS
== Known issues ==
Here are the changes found in Patchwork_8945_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_flip@dpms-vs-vblank-race-interruptible:
shard-glk: PASS -> FAIL (fdo#103060)
igt@kms_flip@wf_vblank-ts-check-interruptible:
shard-glk: PASS -> FAIL (fdo#100368) +1
==== Possible fixes ====
igt@drv_selftest@live_gtt:
shard-apl: DMESG-FAIL -> PASS
igt@drv_selftest@live_hugepages:
shard-apl: INCOMPLETE (fdo#103927) -> PASS
igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
shard-hsw: FAIL (fdo#104873) -> PASS
igt@kms_flip@2x-plain-flip-ts-check:
shard-hsw: FAIL (fdo#103928) -> PASS
igt@kms_flip@plain-flip-ts-check-interruptible:
shard-glk: FAIL (fdo#105312) -> PASS
igt@kms_rotation_crc@primary-rotation-270:
shard-apl: FAIL (fdo#103925, fdo#104724) -> PASS +1
igt@kms_setmode@basic:
shard-apl: FAIL (fdo#99912) -> PASS
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#103928 https://bugs.freedesktop.org/show_bug.cgi?id=103928
fdo#104724 https://bugs.freedesktop.org/show_bug.cgi?id=104724
fdo#104873 https://bugs.freedesktop.org/show_bug.cgi?id=104873
fdo#105312 https://bugs.freedesktop.org/show_bug.cgi?id=105312
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (5 -> 4) ==
Missing (1): shard-kbl
== Build changes ==
* Linux: CI_DRM_4158 -> Patchwork_8945
CI_DRM_4158: b4cf5831333d423c2420f167111c03e4c1729672 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4465: 41eb85f918b02918787fc59d9cb5aab93b81f323 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_8945: 31b71b60b3a083a072d36fd15472cb63a65fa890 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4465: 33e58d5583eb7ed3966a1b905f875a1dfa959f6b @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8945/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-05-08 20:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-08 15:15 [PATCH] drm/i915: Remove unused i915_flip tracepoints Chris Wilson
2018-05-08 15:35 ` Ville Syrjälä
2018-05-08 20:50 ` Chris Wilson
2018-05-08 16:46 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2018-05-08 17:03 ` ✓ Fi.CI.BAT: success " Patchwork
2018-05-08 20:18 ` ✗ Fi.CI.IGT: failure " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.