All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Cody <jcody@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, qemu-trivial@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-block] [PATCH 3/5] qemu-img: remove references to GEN_DOCS
Date: Tue, 8 May 2018 11:45:01 -0400	[thread overview]
Message-ID: <20180508154501.GC6722@localhost.localdomain> (raw)
In-Reply-To: <20180503225648.13153-4-jsnow@redhat.com>

On Thu, May 03, 2018 at 06:56:46PM -0400, John Snow wrote:
> Nothing seemingly uses this.
>

Indeed - it looks like it has been vestigial for a while now (commit
77bd1119ba even mentions that it appears unused).

Reviewed-by: Jeff Cody <jcody@redhat.com>

> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>  qemu-img.c             | 2 --
>  qemu-options-wrapper.h | 1 -
>  2 files changed, 3 deletions(-)
> 
> diff --git a/qemu-img.c b/qemu-img.c
> index 855fa52514..a01425372d 100644
> --- a/qemu-img.c
> +++ b/qemu-img.c
> @@ -123,7 +123,6 @@ static void QEMU_NORETURN help(void)
>             "  " arg_string "\n"
>  #include "qemu-img-cmds.h"
>  #undef DEF
> -#undef GEN_DOCS
>             "\n"
>             "Command parameters:\n"
>             "  'filename' is a disk image filename\n"
> @@ -4685,7 +4684,6 @@ static const img_cmd_t img_cmds[] = {
>      { option, callback },
>  #include "qemu-img-cmds.h"
>  #undef DEF
> -#undef GEN_DOCS
>      { NULL, NULL, },
>  };
>  
> diff --git a/qemu-options-wrapper.h b/qemu-options-wrapper.h
> index 13bfea0294..6f548e3922 100644
> --- a/qemu-options-wrapper.h
> +++ b/qemu-options-wrapper.h
> @@ -34,7 +34,6 @@
>  #undef DEF
>  #undef DEFHEADING
>  #undef ARCHHEADING
> -#undef GEN_DOCS
>  
>  #undef QEMU_OPTIONS_GENERATE_ENUM
>  #undef QEMU_OPTIONS_GENERATE_HELP
> -- 
> 2.14.3
> 
> 


WARNING: multiple messages have this Message-ID (diff)
From: Jeff Cody <jcody@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 3/5] qemu-img: remove references to GEN_DOCS
Date: Tue, 8 May 2018 11:45:01 -0400	[thread overview]
Message-ID: <20180508154501.GC6722@localhost.localdomain> (raw)
In-Reply-To: <20180503225648.13153-4-jsnow@redhat.com>

On Thu, May 03, 2018 at 06:56:46PM -0400, John Snow wrote:
> Nothing seemingly uses this.
>

Indeed - it looks like it has been vestigial for a while now (commit
77bd1119ba even mentions that it appears unused).

Reviewed-by: Jeff Cody <jcody@redhat.com>

> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>  qemu-img.c             | 2 --
>  qemu-options-wrapper.h | 1 -
>  2 files changed, 3 deletions(-)
> 
> diff --git a/qemu-img.c b/qemu-img.c
> index 855fa52514..a01425372d 100644
> --- a/qemu-img.c
> +++ b/qemu-img.c
> @@ -123,7 +123,6 @@ static void QEMU_NORETURN help(void)
>             "  " arg_string "\n"
>  #include "qemu-img-cmds.h"
>  #undef DEF
> -#undef GEN_DOCS
>             "\n"
>             "Command parameters:\n"
>             "  'filename' is a disk image filename\n"
> @@ -4685,7 +4684,6 @@ static const img_cmd_t img_cmds[] = {
>      { option, callback },
>  #include "qemu-img-cmds.h"
>  #undef DEF
> -#undef GEN_DOCS
>      { NULL, NULL, },
>  };
>  
> diff --git a/qemu-options-wrapper.h b/qemu-options-wrapper.h
> index 13bfea0294..6f548e3922 100644
> --- a/qemu-options-wrapper.h
> +++ b/qemu-options-wrapper.h
> @@ -34,7 +34,6 @@
>  #undef DEF
>  #undef DEFHEADING
>  #undef ARCHHEADING
> -#undef GEN_DOCS
>  
>  #undef QEMU_OPTIONS_GENERATE_ENUM
>  #undef QEMU_OPTIONS_GENERATE_HELP
> -- 
> 2.14.3
> 
> 

  reply	other threads:[~2018-05-08 15:45 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-03 22:56 [Qemu-trivial] [PATCH 0/5] qemu-img: make subcommand usage docstrings consistent John Snow
2018-05-03 22:56 ` [Qemu-devel] " John Snow
2018-05-03 22:56 ` [Qemu-trivial] [PATCH 1/5] qemu-img-commands.hx: argument ordering fixups John Snow
2018-05-03 22:56   ` [Qemu-devel] " John Snow
2018-05-08 15:33   ` [Qemu-trivial] [Qemu-block] " Jeff Cody
2018-05-08 15:33     ` [Qemu-devel] " Jeff Cody
2018-05-03 22:56 ` [Qemu-trivial] [PATCH 2/5] qemu-img.texi: fix command ordering John Snow
2018-05-03 22:56   ` [Qemu-devel] " John Snow
2018-05-08 15:33   ` [Qemu-trivial] [Qemu-block] " Jeff Cody
2018-05-08 15:33     ` [Qemu-devel] " Jeff Cody
2018-05-03 22:56 ` [Qemu-trivial] [PATCH 3/5] qemu-img: remove references to GEN_DOCS John Snow
2018-05-03 22:56   ` [Qemu-devel] " John Snow
2018-05-08 15:45   ` Jeff Cody [this message]
2018-05-08 15:45     ` [Qemu-devel] [Qemu-block] " Jeff Cody
2018-05-03 22:56 ` [Qemu-trivial] [PATCH 4/5] qemu-img: Make documentation between .texi and .hx consistent John Snow
2018-05-03 22:56   ` [Qemu-devel] " John Snow
2018-05-08 15:45   ` [Qemu-trivial] [Qemu-block] " Jeff Cody
2018-05-08 15:45     ` [Qemu-devel] " Jeff Cody
2018-05-03 22:56 ` [Qemu-trivial] [PATCH 5/5] qemu-img-cmds.hx: add passive-aggressive note John Snow
2018-05-03 22:56   ` [Qemu-devel] " John Snow
2018-05-08 15:49   ` [Qemu-trivial] [Qemu-block] " Jeff Cody
2018-05-08 15:49     ` [Qemu-devel] " Jeff Cody
2018-05-04  1:03 ` [Qemu-trivial] [PATCH 0/5] qemu-img: make subcommand usage docstrings consistent John Snow
2018-05-04  1:03   ` [Qemu-devel] " John Snow
2018-05-09 18:07   ` [Qemu-trivial] [Qemu-block] " Max Reitz
2018-05-09 18:07     ` [Qemu-devel] " Max Reitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180508154501.GC6722@localhost.localdomain \
    --to=jcody@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.