From: Stephen Hemminger <stephen@networkplumber.org>
To: dccp@vger.kernel.org
Subject: Re: [PATCH net-next v3 0/2] socket statistics for ss
Date: Wed, 09 May 2018 15:22:09 +0000 [thread overview]
Message-ID: <20180509082209.38fa4f43@xeon-e3> (raw)
In-Reply-To: <20180507184333.32688-1-sthemmin@microsoft.com>
On Mon, 7 May 2018 11:43:31 -0700
Stephen Hemminger <stephen@networkplumber.org> wrote:
> The eventual goal is to remove all accesses to slab statistics
> by iproute2 ss command. This are preliminary steps to add two
> statistics which are not working now, because of slab merging
> and changes that were done years ago to allow for common inet_hash
> tables.
>
> Stephen Hemminger (2):
> inet: add bound ports statistic
> socket: keep track of the number of sockets allocated
>
> v3
> - fix build :-(
> - add allocated sockets statistic
>
> include/net/inet_hashtables.h | 3 +++
> include/net/inet_timewait_sock.h | 2 ++
> net/dccp/proto.c | 1 +
> net/ipv4/inet_hashtables.c | 22 +++++++++++++++++++---
> net/ipv4/inet_timewait_sock.c | 8 +++++---
> net/ipv4/proc.c | 5 +++--
> net/ipv4/tcp.c | 1 +
> net/socket.c | 21 +++++++++++++++++++--
> 8 files changed, 53 insertions(+), 10 deletions(-)
>
I am not sure if these patches are worth applying.
The 'ss -s' command has had missing values since 2.4 kernel.
And the first complaints came in only this year.
Another alternative would be just to remove these fields from ss -s
output and move on.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Hemminger <stephen@networkplumber.org>
To: davem@davemloft.net, gerrit@erg.abdn.ac.uk, kuznet@ms2.inr.ac.ru,
yoshfuji@linux-ipv6.org
Cc: netdev@vger.kernel.org, dccp@vger.kernel.org,
Stephen Hemminger <sthemmin@microsoft.com>
Subject: Re: [PATCH net-next v3 0/2] socket statistics for ss
Date: Wed, 9 May 2018 08:22:09 -0700 [thread overview]
Message-ID: <20180509082209.38fa4f43@xeon-e3> (raw)
In-Reply-To: <20180507184333.32688-1-sthemmin@microsoft.com>
On Mon, 7 May 2018 11:43:31 -0700
Stephen Hemminger <stephen@networkplumber.org> wrote:
> The eventual goal is to remove all accesses to slab statistics
> by iproute2 ss command. This are preliminary steps to add two
> statistics which are not working now, because of slab merging
> and changes that were done years ago to allow for common inet_hash
> tables.
>
> Stephen Hemminger (2):
> inet: add bound ports statistic
> socket: keep track of the number of sockets allocated
>
> v3
> - fix build :-(
> - add allocated sockets statistic
>
> include/net/inet_hashtables.h | 3 +++
> include/net/inet_timewait_sock.h | 2 ++
> net/dccp/proto.c | 1 +
> net/ipv4/inet_hashtables.c | 22 +++++++++++++++++++---
> net/ipv4/inet_timewait_sock.c | 8 +++++---
> net/ipv4/proc.c | 5 +++--
> net/ipv4/tcp.c | 1 +
> net/socket.c | 21 +++++++++++++++++++--
> 8 files changed, 53 insertions(+), 10 deletions(-)
>
I am not sure if these patches are worth applying.
The 'ss -s' command has had missing values since 2.4 kernel.
And the first complaints came in only this year.
Another alternative would be just to remove these fields from ss -s
output and move on.
next prev parent reply other threads:[~2018-05-09 15:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-07 18:43 [PATCH net-next v3 0/2] socket statistics for ss Stephen Hemminger
2018-05-07 18:43 ` Stephen Hemminger
2018-05-09 15:22 ` Stephen Hemminger [this message]
2018-05-09 15:22 ` Stephen Hemminger
2018-05-09 17:18 ` Eric Dumazet
2018-05-09 17:18 ` Eric Dumazet
2018-05-09 17:31 ` Stephen Hemminger
2018-05-09 17:31 ` Stephen Hemminger
2018-05-09 17:53 ` Eric Dumazet
2018-05-09 17:53 ` Eric Dumazet
2018-05-09 18:44 ` Stephen Hemminger
2018-05-09 18:44 ` Stephen Hemminger
2018-05-09 18:53 ` Eric Dumazet
2018-05-09 18:53 ` Eric Dumazet
2018-05-09 19:34 ` Stephen Hemminger
2018-05-09 19:34 ` Stephen Hemminger
-- strict thread matches above, loose matches on Subject: below --
2018-05-07 18:43 [PATCH net-next v3 1/2] inet: add bound ports statistic Stephen Hemminger
2018-05-07 18:43 ` Stephen Hemminger
2018-05-07 18:43 [PATCH net-next v3 2/2] socket: keep track of the number of sockets allocated Stephen Hemminger
2018-05-07 18:43 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180509082209.38fa4f43@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dccp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.