All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@bootlin.com>
To: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	dri-devel@lists.freedesktop.org
Cc: Eric Anholt <eric@anholt.net>, stable@vger.kernel.org
Subject: Re: [PATCH] drm/vc4: Fix scaling of uni-planar formats
Date: Wed, 9 May 2018 09:50:57 +0200	[thread overview]
Message-ID: <20180509095057.09f7d9a1@bbrezillon> (raw)
In-Reply-To: <20180507121303.5610-1-boris.brezillon@bootlin.com>

On Mon,  7 May 2018 14:13:03 +0200
Boris Brezillon <boris.brezillon@bootlin.com> wrote:

> When using uni-planar formats (like RGB), the scaling parameters are
> stored in plane 0, not plane 1.
> 
> Fixes: fc04023fafec ("drm/vc4: Add support for YUV planes.")
> Cc: stable@vger.kernel.org
> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>

Queued to drm-misc-fixes.

> ---
>  drivers/gpu/drm/vc4/vc4_plane.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/vc4/vc4_plane.c b/drivers/gpu/drm/vc4/vc4_plane.c
> index ebf081c7a53b..6831975604b5 100644
> --- a/drivers/gpu/drm/vc4/vc4_plane.c
> +++ b/drivers/gpu/drm/vc4/vc4_plane.c
> @@ -541,7 +541,7 @@ static int vc4_plane_mode_set(struct drm_plane *plane,
>  	 * the scl fields here.
>  	 */
>  	if (num_planes == 1) {
> -		scl0 = vc4_get_scl_field(state, 1);
> +		scl0 = vc4_get_scl_field(state, 0);
>  		scl1 = scl0;
>  	} else {
>  		scl0 = vc4_get_scl_field(state, 1);

      parent reply	other threads:[~2018-05-09  7:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-07 12:13 [PATCH] drm/vc4: Fix scaling of uni-planar formats Boris Brezillon
2018-05-07 15:56 ` Eric Anholt
2018-05-07 15:56   ` Eric Anholt
2018-05-07 16:11   ` Boris Brezillon
2018-05-09  7:43     ` Boris Brezillon
2018-05-09  7:43       ` Boris Brezillon
2018-05-09  7:50 ` Boris Brezillon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180509095057.09f7d9a1@bbrezillon \
    --to=boris.brezillon@bootlin.com \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eric@anholt.net \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.