All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Anholt <eric@anholt.net>
To: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	dri-devel@lists.freedesktop.org
Cc: Boris Brezillon <boris.brezillon@bootlin.com>, stable@vger.kernel.org
Subject: Re: [PATCH] drm/vc4: Fix scaling of uni-planar formats
Date: Mon, 07 May 2018 08:56:14 -0700	[thread overview]
Message-ID: <87vabz1mu9.fsf@anholt.net> (raw)
In-Reply-To: <20180507121303.5610-1-boris.brezillon@bootlin.com>


[-- Attachment #1.1: Type: text/plain, Size: 589 bytes --]

Boris Brezillon <boris.brezillon@bootlin.com> writes:

> When using uni-planar formats (like RGB), the scaling parameters are
> stored in plane 0, not plane 1.
>
> Fixes: fc04023fafec ("drm/vc4: Add support for YUV planes.")
> Cc: stable@vger.kernel.org
> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>

Reviewed-by: Eric Anholt <eric@anholt.net>

Looking at the other branch, did I get the scl0/scl1 backwards?  HVS
docs say for non-444 YCBCR: "In these cases Channel 0 performs Y/Alpha
scaling and Channel 1 performs CB/CR scaling and should be configured as
appropriate."

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Eric Anholt <eric@anholt.net>
To: Boris Brezillon <boris.brezillon@bootlin.com>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	dri-devel@lists.freedesktop.org
Cc: Boris Brezillon <boris.brezillon@bootlin.com>, stable@vger.kernel.org
Subject: Re: [PATCH] drm/vc4: Fix scaling of uni-planar formats
Date: Mon, 07 May 2018 08:56:14 -0700	[thread overview]
Message-ID: <87vabz1mu9.fsf@anholt.net> (raw)
In-Reply-To: <20180507121303.5610-1-boris.brezillon@bootlin.com>

[-- Attachment #1: Type: text/plain, Size: 589 bytes --]

Boris Brezillon <boris.brezillon@bootlin.com> writes:

> When using uni-planar formats (like RGB), the scaling parameters are
> stored in plane 0, not plane 1.
>
> Fixes: fc04023fafec ("drm/vc4: Add support for YUV planes.")
> Cc: stable@vger.kernel.org
> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>

Reviewed-by: Eric Anholt <eric@anholt.net>

Looking at the other branch, did I get the scl0/scl1 backwards?  HVS
docs say for non-444 YCBCR: "In these cases Channel 0 performs Y/Alpha
scaling and Channel 1 performs CB/CR scaling and should be configured as
appropriate."

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  reply	other threads:[~2018-05-07 15:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-07 12:13 [PATCH] drm/vc4: Fix scaling of uni-planar formats Boris Brezillon
2018-05-07 15:56 ` Eric Anholt [this message]
2018-05-07 15:56   ` Eric Anholt
2018-05-07 16:11   ` Boris Brezillon
2018-05-09  7:43     ` Boris Brezillon
2018-05-09  7:43       ` Boris Brezillon
2018-05-09  7:50 ` Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vabz1mu9.fsf@anholt.net \
    --to=eric@anholt.net \
    --cc=airlied@linux.ie \
    --cc=boris.brezillon@bootlin.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.