* [PATCH] drm/i915/psr: Check if VBT says PSR can be enabled.
@ 2018-05-09 0:35 Dhinakaran Pandiyan
2018-05-09 0:43 ` ✗ Fi.CI.SPARSE: warning for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Dhinakaran Pandiyan @ 2018-05-09 0:35 UTC (permalink / raw)
To: intel-gfx; +Cc: Dhinakaran Pandiyan, Rodrigo Vivi
Driver features data block has a boolean flag for PSR, use this to decide
whether PSR should be enabled on a platform. The module parameter can
still be used to override this.
Note: The feature currently remains disabled by default for all platforms
irrespective of what VBT says.
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
---
drivers/gpu/drm/i915/i915_drv.h | 1 +
drivers/gpu/drm/i915/intel_bios.c | 1 +
drivers/gpu/drm/i915/intel_psr.c | 7 +++++--
3 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 04e27806e581..24c5e4765afd 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -1073,6 +1073,7 @@ struct intel_vbt_data {
} edp;
struct {
+ bool enable;
bool full_link;
bool require_aux_wakeup;
int idle_frames;
diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
index 702d3fab97fc..54270bdde100 100644
--- a/drivers/gpu/drm/i915/intel_bios.c
+++ b/drivers/gpu/drm/i915/intel_bios.c
@@ -530,6 +530,7 @@ parse_driver_features(struct drm_i915_private *dev_priv,
*/
if (!driver->drrs_enabled)
dev_priv->vbt.drrs_type = DRRS_NOT_SUPPORTED;
+ dev_priv->vbt.psr.enable = driver->psr_enabled;
}
static void
diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c
index 6233a322aac5..db27f2faa1de 100644
--- a/drivers/gpu/drm/i915/intel_psr.c
+++ b/drivers/gpu/drm/i915/intel_psr.c
@@ -1173,9 +1173,12 @@ void intel_psr_init(struct drm_i915_private *dev_priv)
if (!dev_priv->psr.sink_support)
return;
- /* Per platform default: all disabled. */
- if (i915_modparams.enable_psr == -1)
+ if (i915_modparams.enable_psr == -1) {
+ i915_modparams.enable_psr = dev_priv->vbt.psr.enable;
+
+ /* Per platform default: all disabled. */
i915_modparams.enable_psr = 0;
+ }
/* Set link_standby x link_off defaults */
if (IS_HASWELL(dev_priv) || IS_BROADWELL(dev_priv))
--
2.14.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread* ✗ Fi.CI.SPARSE: warning for drm/i915/psr: Check if VBT says PSR can be enabled.
2018-05-09 0:35 [PATCH] drm/i915/psr: Check if VBT says PSR can be enabled Dhinakaran Pandiyan
@ 2018-05-09 0:43 ` Patchwork
2018-05-09 1:03 ` ✓ Fi.CI.BAT: success " Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-05-09 0:43 UTC (permalink / raw)
To: Dhinakaran Pandiyan; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/psr: Check if VBT says PSR can be enabled.
URL : https://patchwork.freedesktop.org/series/42909/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Commit: drm/i915/psr: Check if VBT says PSR can be enabled.
-drivers/gpu/drm/i915/selftests/../i915_drv.h:3653:16: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/selftests/../i915_drv.h:3654:16: warning: expression using sizeof(void)
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915/psr: Check if VBT says PSR can be enabled.
2018-05-09 0:35 [PATCH] drm/i915/psr: Check if VBT says PSR can be enabled Dhinakaran Pandiyan
2018-05-09 0:43 ` ✗ Fi.CI.SPARSE: warning for " Patchwork
@ 2018-05-09 1:03 ` Patchwork
2018-05-09 4:37 ` ✓ Fi.CI.IGT: " Patchwork
2018-05-09 12:29 ` [PATCH] " Rodrigo Vivi
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-05-09 1:03 UTC (permalink / raw)
To: Dhinakaran Pandiyan; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/psr: Check if VBT says PSR can be enabled.
URL : https://patchwork.freedesktop.org/series/42909/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4160 -> Patchwork_8954 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/42909/revisions/1/mbox/
== Known issues ==
Here are the changes found in Patchwork_8954 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_flip@basic-flip-vs-wf_vblank:
fi-cfl-s3: PASS -> FAIL (fdo#100368)
==== Possible fixes ====
igt@gem_exec_suspend@basic-s4-devices:
fi-kbl-7500u: DMESG-WARN (fdo#105128) -> PASS
igt@kms_chamelium@hdmi-hpd-fast:
fi-kbl-7500u: FAIL (fdo#102672, fdo#103841) -> SKIP
igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b-frame-sequence:
fi-glk-j4005: DMESG-WARN (fdo#106235) -> PASS +1
igt@pm_rpm@basic-pci-d3-state:
fi-glk-j4005: DMESG-WARN (fdo#106097) -> PASS
igt@prime_vgem@basic-fence-flip:
fi-ilk-650: FAIL (fdo#104008) -> PASS
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#102672 https://bugs.freedesktop.org/show_bug.cgi?id=102672
fdo#103841 https://bugs.freedesktop.org/show_bug.cgi?id=103841
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
fdo#105128 https://bugs.freedesktop.org/show_bug.cgi?id=105128
fdo#106097 https://bugs.freedesktop.org/show_bug.cgi?id=106097
fdo#106235 https://bugs.freedesktop.org/show_bug.cgi?id=106235
== Participating hosts (41 -> 37) ==
Missing (4): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-skl-6700hq
== Build changes ==
* Linux: CI_DRM_4160 -> Patchwork_8954
CI_DRM_4160: 6d9a2ccf9fca7c006f24b7ff6193ee356b6d3503 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4467: 548a894dc904c4628522dbbc77cb179a4c965ebc @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_8954: ca4cdd80fa426b491aef4f5be2dabcfe5b3e4ca5 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4467: dd20daa579c816498f61e08c819117ad6eb4b4a5 @ git://anongit.freedesktop.org/piglit
== Linux commits ==
ca4cdd80fa42 drm/i915/psr: Check if VBT says PSR can be enabled.
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8954/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* ✓ Fi.CI.IGT: success for drm/i915/psr: Check if VBT says PSR can be enabled.
2018-05-09 0:35 [PATCH] drm/i915/psr: Check if VBT says PSR can be enabled Dhinakaran Pandiyan
2018-05-09 0:43 ` ✗ Fi.CI.SPARSE: warning for " Patchwork
2018-05-09 1:03 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2018-05-09 4:37 ` Patchwork
2018-05-09 12:29 ` [PATCH] " Rodrigo Vivi
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-05-09 4:37 UTC (permalink / raw)
To: Dhinakaran Pandiyan; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/psr: Check if VBT says PSR can be enabled.
URL : https://patchwork.freedesktop.org/series/42909/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4160_full -> Patchwork_8954_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_8954_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_8954_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/42909/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_8954_full:
=== IGT changes ===
==== Warnings ====
igt@drv_selftest@live_execlists:
shard-apl: PASS -> SKIP +1
igt@drv_selftest@live_hangcheck:
shard-apl: DMESG-WARN -> DMESG-FAIL
igt@gem_exec_schedule@deep-render:
shard-kbl: SKIP -> PASS +1
igt@gem_mocs_settings@mocs-rc6-bsd1:
shard-kbl: PASS -> SKIP
igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-mmap-gtt:
shard-snb: SKIP -> PASS
== Known issues ==
Here are the changes found in Patchwork_8954_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_flip@absolute-wf_vblank-interruptible:
shard-glk: PASS -> FAIL (fdo#106087)
igt@kms_flip@plain-flip-ts-check-interruptible:
shard-hsw: PASS -> FAIL (fdo#100368)
igt@kms_sysfs_edid_timing:
shard-apl: PASS -> WARN (fdo#100047)
==== Possible fixes ====
igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
shard-kbl: DMESG-WARN (fdo#103558, fdo#105602, fdo#103313) -> PASS +1
igt@kms_flip@flip-vs-wf_vblank-interruptible:
shard-glk: FAIL (fdo#105312) -> PASS
igt@kms_setmode@basic:
shard-hsw: FAIL (fdo#99912) -> PASS
igt@kms_vblank@pipe-c-query-forked-busy-hang:
shard-kbl: DMESG-WARN (fdo#103558, fdo#105602) -> PASS +22
fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103313 https://bugs.freedesktop.org/show_bug.cgi?id=103313
fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
fdo#105312 https://bugs.freedesktop.org/show_bug.cgi?id=105312
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#106087 https://bugs.freedesktop.org/show_bug.cgi?id=106087
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4160 -> Patchwork_8954
CI_DRM_4160: 6d9a2ccf9fca7c006f24b7ff6193ee356b6d3503 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4467: 548a894dc904c4628522dbbc77cb179a4c965ebc @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_8954: ca4cdd80fa426b491aef4f5be2dabcfe5b3e4ca5 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4467: dd20daa579c816498f61e08c819117ad6eb4b4a5 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8954/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/i915/psr: Check if VBT says PSR can be enabled.
2018-05-09 0:35 [PATCH] drm/i915/psr: Check if VBT says PSR can be enabled Dhinakaran Pandiyan
` (2 preceding siblings ...)
2018-05-09 4:37 ` ✓ Fi.CI.IGT: " Patchwork
@ 2018-05-09 12:29 ` Rodrigo Vivi
2018-05-09 13:59 ` Rodrigo Vivi
3 siblings, 1 reply; 6+ messages in thread
From: Rodrigo Vivi @ 2018-05-09 12:29 UTC (permalink / raw)
To: Dhinakaran Pandiyan; +Cc: intel-gfx
On Tue, May 08, 2018 at 05:35:24PM -0700, Dhinakaran Pandiyan wrote:
> Driver features data block has a boolean flag for PSR, use this to decide
> whether PSR should be enabled on a platform. The module parameter can
> still be used to override this.
>
> Note: The feature currently remains disabled by default for all platforms
> irrespective of what VBT says.
>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/i915_drv.h | 1 +
> drivers/gpu/drm/i915/intel_bios.c | 1 +
> drivers/gpu/drm/i915/intel_psr.c | 7 +++++--
> 3 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index 04e27806e581..24c5e4765afd 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -1073,6 +1073,7 @@ struct intel_vbt_data {
> } edp;
>
> struct {
> + bool enable;
> bool full_link;
> bool require_aux_wakeup;
> int idle_frames;
> diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
> index 702d3fab97fc..54270bdde100 100644
> --- a/drivers/gpu/drm/i915/intel_bios.c
> +++ b/drivers/gpu/drm/i915/intel_bios.c
> @@ -530,6 +530,7 @@ parse_driver_features(struct drm_i915_private *dev_priv,
> */
> if (!driver->drrs_enabled)
> dev_priv->vbt.drrs_type = DRRS_NOT_SUPPORTED;
> + dev_priv->vbt.psr.enable = driver->psr_enabled;
> }
>
> static void
> diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c
> index 6233a322aac5..db27f2faa1de 100644
> --- a/drivers/gpu/drm/i915/intel_psr.c
> +++ b/drivers/gpu/drm/i915/intel_psr.c
> @@ -1173,9 +1173,12 @@ void intel_psr_init(struct drm_i915_private *dev_priv)
> if (!dev_priv->psr.sink_support)
> return;
>
> - /* Per platform default: all disabled. */
> - if (i915_modparams.enable_psr == -1)
> + if (i915_modparams.enable_psr == -1) {
> + i915_modparams.enable_psr = dev_priv->vbt.psr.enable;
> +
> + /* Per platform default: all disabled. */
> i915_modparams.enable_psr = 0;
> + }
>
> /* Set link_standby x link_off defaults */
> if (IS_HASWELL(dev_priv) || IS_BROADWELL(dev_priv))
> --
> 2.14.1
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/i915/psr: Check if VBT says PSR can be enabled.
2018-05-09 12:29 ` [PATCH] " Rodrigo Vivi
@ 2018-05-09 13:59 ` Rodrigo Vivi
0 siblings, 0 replies; 6+ messages in thread
From: Rodrigo Vivi @ 2018-05-09 13:59 UTC (permalink / raw)
To: Dhinakaran Pandiyan; +Cc: intel-gfx
On Wed, May 09, 2018 at 05:29:14AM -0700, Rodrigo Vivi wrote:
> On Tue, May 08, 2018 at 05:35:24PM -0700, Dhinakaran Pandiyan wrote:
> > Driver features data block has a boolean flag for PSR, use this to decide
> > whether PSR should be enabled on a platform. The module parameter can
> > still be used to override this.
> >
> > Note: The feature currently remains disabled by default for all platforms
> > irrespective of what VBT says.
> >
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
pushed to dinq. Thanks for the patch.
>
> > ---
> > drivers/gpu/drm/i915/i915_drv.h | 1 +
> > drivers/gpu/drm/i915/intel_bios.c | 1 +
> > drivers/gpu/drm/i915/intel_psr.c | 7 +++++--
> > 3 files changed, 7 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> > index 04e27806e581..24c5e4765afd 100644
> > --- a/drivers/gpu/drm/i915/i915_drv.h
> > +++ b/drivers/gpu/drm/i915/i915_drv.h
> > @@ -1073,6 +1073,7 @@ struct intel_vbt_data {
> > } edp;
> >
> > struct {
> > + bool enable;
> > bool full_link;
> > bool require_aux_wakeup;
> > int idle_frames;
> > diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
> > index 702d3fab97fc..54270bdde100 100644
> > --- a/drivers/gpu/drm/i915/intel_bios.c
> > +++ b/drivers/gpu/drm/i915/intel_bios.c
> > @@ -530,6 +530,7 @@ parse_driver_features(struct drm_i915_private *dev_priv,
> > */
> > if (!driver->drrs_enabled)
> > dev_priv->vbt.drrs_type = DRRS_NOT_SUPPORTED;
> > + dev_priv->vbt.psr.enable = driver->psr_enabled;
> > }
> >
> > static void
> > diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c
> > index 6233a322aac5..db27f2faa1de 100644
> > --- a/drivers/gpu/drm/i915/intel_psr.c
> > +++ b/drivers/gpu/drm/i915/intel_psr.c
> > @@ -1173,9 +1173,12 @@ void intel_psr_init(struct drm_i915_private *dev_priv)
> > if (!dev_priv->psr.sink_support)
> > return;
> >
> > - /* Per platform default: all disabled. */
> > - if (i915_modparams.enable_psr == -1)
> > + if (i915_modparams.enable_psr == -1) {
> > + i915_modparams.enable_psr = dev_priv->vbt.psr.enable;
> > +
> > + /* Per platform default: all disabled. */
> > i915_modparams.enable_psr = 0;
> > + }
> >
> > /* Set link_standby x link_off defaults */
> > if (IS_HASWELL(dev_priv) || IS_BROADWELL(dev_priv))
> > --
> > 2.14.1
> >
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-05-09 13:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-09 0:35 [PATCH] drm/i915/psr: Check if VBT says PSR can be enabled Dhinakaran Pandiyan
2018-05-09 0:43 ` ✗ Fi.CI.SPARSE: warning for " Patchwork
2018-05-09 1:03 ` ✓ Fi.CI.BAT: success " Patchwork
2018-05-09 4:37 ` ✓ Fi.CI.IGT: " Patchwork
2018-05-09 12:29 ` [PATCH] " Rodrigo Vivi
2018-05-09 13:59 ` Rodrigo Vivi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.