[meta-multimedia][PATCH] openh264: switch away from github archive

[meta-multimedia][PATCH] openh264: switch away from github archive

[Trevor Woerner]

Since we know that github archives which are automatically generated have a
tendency to change their checksums[1], switch to using a git clone.

[1] http://lists.openembedded.org/pipermail/openembedded-devel/2017-September/114916.html

Signed-off-by: Trevor Woerner <twoerner@gmail.com>
---
 .../recipes-multimedia/openh264/openh264_1.7.0.bb          | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/meta-multimedia/recipes-multimedia/openh264/openh264_1.7.0.bb b/meta-multimedia/recipes-multimedia/openh264/openh264_1.7.0.bb
index a7aaab3623..de8352336e 100644
--- a/meta-multimedia/recipes-multimedia/openh264/openh264_1.7.0.bb
+++ b/meta-multimedia/recipes-multimedia/openh264/openh264_1.7.0.bb
@@ -11,9 +11,10 @@ LICENSE = "BSD-2-Clause"
 LICENSE_FLAGS = "commercial"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=bb6d3771da6a07d33fd50d4d9aa73bcf"
 
-SRC_URI = "https://github.com/cisco/openh264/archive/v${PV}.tar.gz"
-SRC_URI[md5sum] = "93da4e76cfda7ede8fd2df51b0021efd"
-SRC_URI[sha256sum] = "9c07c38d7de00046c9c52b12c76a2af7648b70d05bd5460c8b67f6895738653f"
+S = "${WORKDIR}/git"
+SRCREV = "a180c9d4d6f1a4830ca9eed9d159d54996bd63cb"
+OPENHBRANCH = "openh264v1.7"
+SRC_URI = "git://github.com/cisco/openh264.git;protocol=https;branch=${OPENHBRANCH};"
 
 COMPATIBLE_MACHINE_armv7a = "(.*)"
 COMPATIBLE_MACHINE_aarch64 = "(.*)"
-- 
2.17.0.rc2.3.gc2a499e6c

Re: [meta-multimedia][PATCH] openh264: switch away from github archive

[Andre McCurdy]

On Wed, May 9, 2018 at 3:46 PM, Trevor Woerner <twoerner@gmail.com> wrote:
> Since we know that github archives which are automatically generated have a
> tendency to change their checksums[1], switch to using a git clone.
>
> [1] http://lists.openembedded.org/pipermail/openembedded-devel/2017-September/114916.html
>
> Signed-off-by: Trevor Woerner <twoerner@gmail.com>
> ---
>  .../recipes-multimedia/openh264/openh264_1.7.0.bb          | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/meta-multimedia/recipes-multimedia/openh264/openh264_1.7.0.bb b/meta-multimedia/recipes-multimedia/openh264/openh264_1.7.0.bb
> index a7aaab3623..de8352336e 100644
> --- a/meta-multimedia/recipes-multimedia/openh264/openh264_1.7.0.bb
> +++ b/meta-multimedia/recipes-multimedia/openh264/openh264_1.7.0.bb
> @@ -11,9 +11,10 @@ LICENSE = "BSD-2-Clause"
>  LICENSE_FLAGS = "commercial"
>  LIC_FILES_CHKSUM = "file://LICENSE;md5=bb6d3771da6a07d33fd50d4d9aa73bcf"
>
> -SRC_URI = "https://github.com/cisco/openh264/archive/v${PV}.tar.gz"
> -SRC_URI[md5sum] = "93da4e76cfda7ede8fd2df51b0021efd"
> -SRC_URI[sha256sum] = "9c07c38d7de00046c9c52b12c76a2af7648b70d05bd5460c8b67f6895738653f"
> +S = "${WORKDIR}/git"
> +SRCREV = "a180c9d4d6f1a4830ca9eed9d159d54996bd63cb"
> +OPENHBRANCH = "openh264v1.7"

"openh264" is a combination of "open" and "h264", so using "openh" in
this variable name looks a little odd?

Since the variable is local to the recipe, maybe just "BRANCH" would be OK?

> +SRC_URI = "git://github.com/cisco/openh264.git;protocol=https;branch=${OPENHBRANCH};"
>
>  COMPATIBLE_MACHINE_armv7a = "(.*)"
>  COMPATIBLE_MACHINE_aarch64 = "(.*)"
> --
> 2.17.0.rc2.3.gc2a499e6c
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [meta-multimedia][PATCH] openh264: switch away from github archive

[Trevor Woerner]

On Wed, May 9, 2018 at 7:34 PM, Andre McCurdy <armccurdy@gmail.com> wrote:

> On Wed, May 9, 2018 at 3:46 PM, Trevor Woerner <twoerner@gmail.com> wrote:
> > +OPENHBRANCH = "openh264v1.7"
>
> "openh264" is a combination of "open" and "h264", so using "openh" in
> this variable name looks a little odd?
>
> Since the variable is local to the recipe, maybe just "BRANCH" would be OK?
>

I assumed (but didn't test or check) that something as plain as BRANCH
would conflict with any number of dozens of established internal variables
:-) So I figured I'd scope it.

I'll try BRANCH and send a v2.