[tisdk-build-scripts][PATCH] bitbake-test-sdk-image: preserve bitbake-cookerdaemon.log

[tisdk-build-scripts][PATCH] bitbake-test-sdk-image: preserve bitbake-cookerdaemon.log

[Jacob Stiffler]

* When stdout/stderr is piped, if there is an error during parsing,
  all that will be printed is "Unable to start bitbake server"
* The bitbake-cookerdaemon.log will contain the error message, so
  preserve it in the LOG_DIR.

Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
---
 lib/oesdk/bitbake-test-sdk-image | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/lib/oesdk/bitbake-test-sdk-image b/lib/oesdk/bitbake-test-sdk-image
index f17b594..de081cf 100644
--- a/lib/oesdk/bitbake-test-sdk-image
+++ b/lib/oesdk/bitbake-test-sdk-image
@@ -465,6 +465,9 @@ bitbake_sdk_images(){
             fi
         done
 
+        # Move the bitbake-cooker.log as some errors may get hidden in there.
+        mv $build_dir/bitbake-cookerdaemon.log $LOG_DIR/$m-bitbake-cookerdaemon.log
+
         # Only run the build testing if the status of the above builds
         # was "pass"
         if [ "$build_status" == "pass" ]
-- 
1.9.1

Re: [tisdk-build-scripts][PATCH] bitbake-test-sdk-image: preserve bitbake-cookerdaemon.log

[Denys Dmytriyenko]

On Thu, May 10, 2018 at 10:36:28AM -0400, Jacob Stiffler wrote:
> * When stdout/stderr is piped, if there is an error during parsing,
>   all that will be printed is "Unable to start bitbake server"
> * The bitbake-cookerdaemon.log will contain the error message, so
>   preserve it in the LOG_DIR.
> 
> Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
> ---
>  lib/oesdk/bitbake-test-sdk-image | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/lib/oesdk/bitbake-test-sdk-image b/lib/oesdk/bitbake-test-sdk-image
> index f17b594..de081cf 100644
> --- a/lib/oesdk/bitbake-test-sdk-image
> +++ b/lib/oesdk/bitbake-test-sdk-image
> @@ -465,6 +465,9 @@ bitbake_sdk_images(){
>              fi
>          done
>  
> +        # Move the bitbake-cooker.log as some errors may get hidden in there.
> +        mv $build_dir/bitbake-cookerdaemon.log $LOG_DIR/$m-bitbake-cookerdaemon.log

What happens if the file doesn't exist?


>          # Only run the build testing if the status of the above builds
>          # was "pass"
>          if [ "$build_status" == "pass" ]
> -- 
> 1.9.1
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago

Re: [tisdk-build-scripts][PATCH] bitbake-test-sdk-image: preserve bitbake-cookerdaemon.log

[Jacob Stiffler]

On 5/10/2018 11:47 AM, Denys Dmytriyenko wrote:
> On Thu, May 10, 2018 at 10:36:28AM -0400, Jacob Stiffler wrote:
>> * When stdout/stderr is piped, if there is an error during parsing,
>>    all that will be printed is "Unable to start bitbake server"
>> * The bitbake-cookerdaemon.log will contain the error message, so
>>    preserve it in the LOG_DIR.
>>
>> Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
>> ---
>>   lib/oesdk/bitbake-test-sdk-image | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/lib/oesdk/bitbake-test-sdk-image b/lib/oesdk/bitbake-test-sdk-image
>> index f17b594..de081cf 100644
>> --- a/lib/oesdk/bitbake-test-sdk-image
>> +++ b/lib/oesdk/bitbake-test-sdk-image
>> @@ -465,6 +465,9 @@ bitbake_sdk_images(){
>>               fi
>>           done
>>   
>> +        # Move the bitbake-cooker.log as some errors may get hidden in there.
>> +        mv $build_dir/bitbake-cookerdaemon.log $LOG_DIR/$m-bitbake-cookerdaemon.log
> What happens if the file doesn't exist?

There will be an error printed and an error code returned. The error 
code is not caught, so the script will proceed.

Would you prefer to first check if the file exists, or hide the error 
code with an "mv ... || true"?

>
>>           # Only run the build testing if the status of the above builds
>>           # was "pass"
>>           if [ "$build_status" == "pass" ]
>> -- 
>> 1.9.1
>>
>> _______________________________________________
>> meta-arago mailing list
>> meta-arago@arago-project.org
>> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago

Re: [tisdk-build-scripts][PATCH] bitbake-test-sdk-image: preserve bitbake-cookerdaemon.log

[Denys Dmytriyenko]

On Thu, May 10, 2018 at 12:15:21PM -0400, Jacob Stiffler wrote:
> 
> 
> On 5/10/2018 11:47 AM, Denys Dmytriyenko wrote:
> >On Thu, May 10, 2018 at 10:36:28AM -0400, Jacob Stiffler wrote:
> >>* When stdout/stderr is piped, if there is an error during parsing,
> >>   all that will be printed is "Unable to start bitbake server"
> >>* The bitbake-cookerdaemon.log will contain the error message, so
> >>   preserve it in the LOG_DIR.
> >>
> >>Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
> >>---
> >>  lib/oesdk/bitbake-test-sdk-image | 3 +++
> >>  1 file changed, 3 insertions(+)
> >>
> >>diff --git a/lib/oesdk/bitbake-test-sdk-image b/lib/oesdk/bitbake-test-sdk-image
> >>index f17b594..de081cf 100644
> >>--- a/lib/oesdk/bitbake-test-sdk-image
> >>+++ b/lib/oesdk/bitbake-test-sdk-image
> >>@@ -465,6 +465,9 @@ bitbake_sdk_images(){
> >>              fi
> >>          done
> >>+        # Move the bitbake-cooker.log as some errors may get hidden in there.
> >>+        mv $build_dir/bitbake-cookerdaemon.log $LOG_DIR/$m-bitbake-cookerdaemon.log
> >What happens if the file doesn't exist?
> 
> There will be an error printed and an error code returned. The error
> code is not caught, so the script will proceed.
> 
> Would you prefer to first check if the file exists, or hide the
> error code with an "mv ... || true"?

Doesn't matter in this case, so mv || true is shorter and concise.


> >>          # Only run the build testing if the status of the above builds
> >>          # was "pass"
> >>          if [ "$build_status" == "pass" ]
> >>-- 
> >>1.9.1
> >>
> >>_______________________________________________
> >>meta-arago mailing list
> >>meta-arago@arago-project.org
> >>http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
>