From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Dmitry Safonov <dima@arista.com>
Cc: linux-kernel@vger.kernel.org, 0x7f454c46@gmail.com,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 1/2] random: Omit double-printing ratelimit messages
Date: Thu, 10 May 2018 15:40:41 -0400 [thread overview]
Message-ID: <20180510194041.GH8335@thunk.org> (raw)
In-Reply-To: <1525977460.28243.2.camel@arista.com>
On Thu, May 10, 2018 at 07:37:40PM +0100, Dmitry Safonov wrote:
>
> Ok, then what's the purpose of those messages?
> : pr_notice("random: %d get_random_xx warning(s) missed "
> : "due to ratelimiting\n",
> : unseeded_warning.missed);
> : pr_notice("random: %d urandom warning(s) missed "
> : "due to ratelimiting\n",
> : urandom_warning.missed);
>
> I thought you want to print the summary after initializing random,
> not once per second?
Yes, and that's what is happening today. The "output lines suppressed
due to ratelimiting" message is only printed out by printk_ratelimit()
function, which we are *not* using.
So I'm not sure what you are unhappy about? What are you trying to fix?
>From my testing, it is *NOT* double-printing ratelimit messages today.
Are you seeing something that I am not?
- Ted
next prev parent reply other threads:[~2018-05-10 19:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-10 12:52 [PATCH 0/2] ratelimit: Do not lose messages under limit Dmitry Safonov
2018-05-10 12:52 ` [PATCH 1/2] random: Omit double-printing ratelimit messages Dmitry Safonov
2018-05-10 18:19 ` Theodore Y. Ts'o
2018-05-10 18:37 ` Dmitry Safonov
2018-05-10 19:40 ` Theodore Y. Ts'o [this message]
2018-05-10 19:50 ` Dmitry Safonov
2018-05-11 3:51 ` Theodore Y. Ts'o
2018-05-11 12:41 ` Dmitry Safonov
2018-05-16 15:46 ` Dmitry Safonov
2018-05-16 20:54 ` Theodore Y. Ts'o
2018-05-16 22:11 ` Dmitry Safonov
2018-05-10 12:52 ` [PATCH 2/2] lib/ratelimit: Lockless ratelimiting Dmitry Safonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180510194041.GH8335@thunk.org \
--to=tytso@mit.edu \
--cc=0x7f454c46@gmail.com \
--cc=arnd@arndb.de \
--cc=dima@arista.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.