From: Greg KH <gregkh@linuxfoundation.org>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v3 0/1] multi-threading device shutdown
Date: Mon, 14 May 2018 17:03:36 +0200 [thread overview]
Message-ID: <20180514150336.GA18769@kroah.com> (raw)
In-Reply-To: <20180507155402.10086-1-pasha.tatashin@oracle.com>
On Mon, May 07, 2018 at 11:54:01AM -0400, Pavel Tatashin wrote:
> Changelog
> v2 - v3
> - Fixed warning from kbuild test.
> - Moved device_lock/device_unlock inside device_shutdown_tree().
>
> v1 - v2
> - It turns out we cannot lock more than MAX_LOCK_DEPTH by a single
> thread. (By default this value is 48), and is used to detect
> deadlocks. So, I re-wrote the code to only lock one devices per
> thread instead of pre-locking all devices by the main thread.
> - Addressed comments from Tobin C. Harding.
> - As suggested by Alexander Duyck removed ixgbe changes. It can be
> done as a separate work scaling RTNL mutex.
>
> Do a faster shutdown by calling dev->*->shutdown(dev) in parallel.
> device_shutdown() calls these functions for every single device but
> only using one thread.
>
> Since, nothing else is running on the machine by the device_shutdown()
> s called, there is no reason not to utilize all the available CPU
> resources.
Ah, we can hope so. I bet this is going to break something, so can we
have some way of turning it on/off dynamically for when it does?
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Pavel Tatashin <pasha.tatashin@oracle.com>
Cc: steven.sistare@oracle.com, daniel.m.jordan@oracle.com,
linux-kernel@vger.kernel.org, jeffrey.t.kirsher@intel.com,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
alexander.duyck@gmail.com, tobin@apporbit.com
Subject: Re: [PATCH v3 0/1] multi-threading device shutdown
Date: Mon, 14 May 2018 17:03:36 +0200 [thread overview]
Message-ID: <20180514150336.GA18769@kroah.com> (raw)
In-Reply-To: <20180507155402.10086-1-pasha.tatashin@oracle.com>
On Mon, May 07, 2018 at 11:54:01AM -0400, Pavel Tatashin wrote:
> Changelog
> v2 - v3
> - Fixed warning from kbuild test.
> - Moved device_lock/device_unlock inside device_shutdown_tree().
>
> v1 - v2
> - It turns out we cannot lock more than MAX_LOCK_DEPTH by a single
> thread. (By default this value is 48), and is used to detect
> deadlocks. So, I re-wrote the code to only lock one devices per
> thread instead of pre-locking all devices by the main thread.
> - Addressed comments from Tobin C. Harding.
> - As suggested by Alexander Duyck removed ixgbe changes. It can be
> done as a separate work scaling RTNL mutex.
>
> Do a faster shutdown by calling dev->*->shutdown(dev) in parallel.
> device_shutdown() calls these functions for every single device but
> only using one thread.
>
> Since, nothing else is running on the machine by the device_shutdown()
> s called, there is no reason not to utilize all the available CPU
> resources.
Ah, we can hope so. I bet this is going to break something, so can we
have some way of turning it on/off dynamically for when it does?
thanks,
greg k-h
next prev parent reply other threads:[~2018-05-14 15:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-07 15:54 [Intel-wired-lan] [PATCH v3 0/1] multi-threading device shutdown Pavel Tatashin
2018-05-07 15:54 ` Pavel Tatashin
2018-05-07 15:54 ` [Intel-wired-lan] [PATCH v3 1/1] drivers core: " Pavel Tatashin
2018-05-07 15:54 ` Pavel Tatashin
2018-05-14 15:03 ` Greg KH [this message]
2018-05-14 15:03 ` [PATCH v3 0/1] " Greg KH
2018-05-14 16:54 ` [Intel-wired-lan] " Pavel Tatashin
2018-05-14 16:54 ` Pavel Tatashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180514150336.GA18769@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.