[PATCH] Drivers: hv: vmbus: Removed an unnecessary cast from void *

[PATCH] Drivers: hv: vmbus: Removed an unnecessary cast from void *

[Dexuan Cui]

In C, we don't need such a cast.

Fixes: ae20b254306a ("Drivers: hv: vmbus: enable VMBus protocol version 5.0")
Reported-by: Stephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: Dexuan Cui <decui@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
---

Thanks Stephen Hemminger for pointing this out!

So far, ae20b254306a ("Drivers: hv: vmbus: enable VMBus protocol version 5.0") only
appears in the char-misc tree's char-misc-testing and char-misc-next branches. If 
possible, please merge both patches into one.

 drivers/hv/connection.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hv/connection.c b/drivers/hv/connection.c
index 19e0468..ced0418 100644
--- a/drivers/hv/connection.c
+++ b/drivers/hv/connection.c
@@ -409,7 +409,7 @@ int vmbus_post_msg(void *buffer, size_t buflen, bool can_sleep)
 			 * HV_STATUS_INVALID_CONNECTION_ID and we should
 			 * return an error immediately without retrying.
 			 */
-			hdr = (struct vmbus_channel_message_header *)buffer;
+			hdr = buffer;
 			if (hdr->msgtype == CHANNELMSG_INITIATE_CONTACT)
 				return -EINVAL;
 			/*
-- 
2.7.4

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Drivers: hv: vmbus: Removed an unnecessary cast from void *

['gregkh@linuxfoundation.org']

On Tue, May 15, 2018 at 12:25:01AM +0000, Dexuan Cui wrote:
> 
> In C, we don't need such a cast.
> 
> Fixes: ae20b254306a ("Drivers: hv: vmbus: enable VMBus protocol version 5.0")
> Signed-off-by: Dexuan Cui <decui@microsoft.com>
> Cc: Stephen Hemminger <sthemmin@microsoft.com>

Should be "Reported-by:", I'll go edit this by hand :(

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Drivers: hv: vmbus: Removed an unnecessary cast from void *

['gregkh@linuxfoundation.org']

On Tue, May 15, 2018 at 12:25:01AM +0000, Dexuan Cui wrote:
> 
> In C, we don't need such a cast.
> 
> Fixes: ae20b254306a ("Drivers: hv: vmbus: enable VMBus protocol version 5.0")
> Reported-by: Stephen Hemminger <sthemmin@microsoft.com>
> Signed-off-by: Dexuan Cui <decui@microsoft.com>
> Cc: K. Y. Srinivasan <kys@microsoft.com>
> ---
> 
> Thanks Stephen Hemminger for pointing this out!
> 
> So far, ae20b254306a ("Drivers: hv: vmbus: enable VMBus protocol version 5.0") only
> appears in the char-misc tree's char-misc-testing and char-misc-next branches. If 
> possible, please merge both patches into one.

I can not rebase/merge patches in public branches, sorry, so I'll just
apply this one.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel