From: Omar Sandoval <osandov@osandov.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Jan Kara <jack@suse.cz>, Aleksei Besogonov <cyberax@amazon.com>
Subject: Re: [PATCH] iomap: don't allow holes in swapfiles
Date: Wed, 16 May 2018 09:19:55 -0700 [thread overview]
Message-ID: <20180516161955.GA14174@vader> (raw)
In-Reply-To: <20180516155638.GD23858@magnolia>
On Wed, May 16, 2018 at 08:56:38AM -0700, Darrick J. Wong wrote:
> On Wed, May 16, 2018 at 08:51:46AM -0700, Christoph Hellwig wrote:
> > On Wed, May 16, 2018 at 08:50:00AM -0700, Darrick J. Wong wrote:
> > > > Hey, Darrick, I noticed this while writing up a generic xfstest to test
> > > > that the Btrfs swap support patches don't allow a swapfile with holes.
> > > > It'd be nice if we were all consistent :) This is based on
> > > > xfs-linux/for-next. Feel free to fold it in to your patch or apply it
> > > > separately as you see fit. Thanks!
> > >
> > > I sent a testcase of my own ("generic: test swapfile creation,
> > > activation, and deactivation") a while back; would you mind sending out
> > > yours so we can combine them into a single testcase?
Sure thing, I have a small pile of tests. I'm still working on some
Btrfs-specific ones, but I can send out the generic ones and we can
figure out how to merge them.
> > Wasn't the desire to support holes the rationale for the Aleksei
> > version of the iomap swapfile patch?
>
> Ah, so it was. FWIW I'm not sure why you'd /want/ a holey swapfile?
>From reading the old thread, it looks like Aleksei just wanted
fallocated swap files to work: "I've traced the problem to bmap(), used
in generic_swapfile_activate call, which returns 0 for blocks inside
holes created by fallocate". Are holes in that sense are different from
actual holes in the iomap sense?
next prev parent reply other threads:[~2018-05-16 16:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-16 6:45 [PATCH] iomap: don't allow holes in swapfiles Omar Sandoval
2018-05-16 15:50 ` Darrick J. Wong
2018-05-16 15:51 ` Christoph Hellwig
2018-05-16 15:56 ` Darrick J. Wong
2018-05-16 16:19 ` Omar Sandoval [this message]
2018-05-16 16:24 ` Christoph Hellwig
2018-05-16 16:23 ` Christoph Hellwig
2018-05-16 16:26 ` Omar Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180516161955.GA14174@vader \
--to=osandov@osandov.com \
--cc=cyberax@amazon.com \
--cc=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.