From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 6/8] firmware: arm_scmi: remove unnecessary bitmap_zero
Date: Thu, 17 May 2018 09:43:29 +0100 [thread overview]
Message-ID: <20180517094329.000002f1@huawei.com> (raw)
In-Reply-To: <1525885634-22348-7-git-send-email-sudeep.holla@arm.com>
On Wed, 9 May 2018 18:07:12 +0100
Sudeep Holla <sudeep.holla@arm.com> wrote:
> kcalloc zeros the memory and it's totally unnecessary to zero the bitmap
> again using bitmap_zero. This patch just drops the unnecessary use of
> the bitmap_zero in the context.
>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> drivers/firmware/arm_scmi/driver.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c
> index 33d2b78af3ff..4087d6c50ecd 100644
> --- a/drivers/firmware/arm_scmi/driver.c
> +++ b/drivers/firmware/arm_scmi/driver.c
> @@ -636,8 +636,6 @@ static int scmi_xfer_info_init(struct scmi_info *sinfo)
> if (!info->xfer_alloc_table)
> return -ENOMEM;
>
> - bitmap_zero(info->xfer_alloc_table, desc->max_msg);
> -
> /* Pre-initialize the buffer pointer to pre-allocated buffers */
> for (i = 0, xfer = info->xfer_block; i < desc->max_msg; i++, xfer++) {
> xfer->rx.buf = devm_kcalloc(dev, sizeof(u8), desc->max_msg_size,
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan.Cameron@huawei.com (Jonathan Cameron)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/8] firmware: arm_scmi: remove unnecessary bitmap_zero
Date: Thu, 17 May 2018 09:43:29 +0100 [thread overview]
Message-ID: <20180517094329.000002f1@huawei.com> (raw)
In-Reply-To: <1525885634-22348-7-git-send-email-sudeep.holla@arm.com>
On Wed, 9 May 2018 18:07:12 +0100
Sudeep Holla <sudeep.holla@arm.com> wrote:
> kcalloc zeros the memory and it's totally unnecessary to zero the bitmap
> again using bitmap_zero. This patch just drops the unnecessary use of
> the bitmap_zero in the context.
>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> drivers/firmware/arm_scmi/driver.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c
> index 33d2b78af3ff..4087d6c50ecd 100644
> --- a/drivers/firmware/arm_scmi/driver.c
> +++ b/drivers/firmware/arm_scmi/driver.c
> @@ -636,8 +636,6 @@ static int scmi_xfer_info_init(struct scmi_info *sinfo)
> if (!info->xfer_alloc_table)
> return -ENOMEM;
>
> - bitmap_zero(info->xfer_alloc_table, desc->max_msg);
> -
> /* Pre-initialize the buffer pointer to pre-allocated buffers */
> for (i = 0, xfer = info->xfer_block; i < desc->max_msg; i++, xfer++) {
> xfer->rx.buf = devm_kcalloc(dev, sizeof(u8), desc->max_msg_size,
next prev parent reply other threads:[~2018-05-17 8:43 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-09 17:07 [PATCH 0/8] firmware: arm_scmi: trivial cleanups Sudeep Holla
2018-05-09 17:07 ` Sudeep Holla
2018-05-09 17:07 ` [PATCH 1/8] firmware: arm_scmi: improve code readability using bitfield accessor macros Sudeep Holla
2018-05-09 17:07 ` Sudeep Holla
2018-05-17 8:14 ` Jonathan Cameron
2018-05-17 8:14 ` Jonathan Cameron
2018-05-09 17:07 ` [PATCH 2/8] firmware: arm_scmi: fix kernel-docs documentation Sudeep Holla
2018-05-09 17:07 ` Sudeep Holla
2018-05-17 8:30 ` Jonathan Cameron
2018-05-17 8:30 ` Jonathan Cameron
2018-05-09 17:07 ` [PATCH 3/8] firmware: arm_scmi: rename get_transition_latency and add_opps_to_device Sudeep Holla
2018-05-09 17:07 ` Sudeep Holla
2018-05-10 8:29 ` Rafael J. Wysocki
2018-05-10 8:29 ` Rafael J. Wysocki
2018-05-10 9:53 ` Sudeep Holla
2018-05-10 9:53 ` Sudeep Holla
2018-05-17 8:32 ` Jonathan Cameron
2018-05-17 8:32 ` Jonathan Cameron
2018-05-09 17:07 ` [PATCH 4/8] firmware: arm_scmi: rename scmi_xfer_{init,get,put} Sudeep Holla
2018-05-09 17:07 ` Sudeep Holla
2018-05-17 8:38 ` Jonathan Cameron
2018-05-17 8:38 ` Jonathan Cameron
2018-05-09 17:07 ` [PATCH 5/8] firmware: arm_scmi: drop unused `con_priv` structure member Sudeep Holla
2018-05-09 17:07 ` Sudeep Holla
2018-05-17 8:41 ` Jonathan Cameron
2018-05-17 8:41 ` Jonathan Cameron
2018-05-09 17:07 ` [PATCH 6/8] firmware: arm_scmi: remove unnecessary bitmap_zero Sudeep Holla
2018-05-09 17:07 ` Sudeep Holla
2018-05-17 8:43 ` Jonathan Cameron [this message]
2018-05-17 8:43 ` Jonathan Cameron
2018-05-09 17:07 ` [PATCH 7/8] firmware: arm_scmi: improve exit paths and code readability Sudeep Holla
2018-05-09 17:07 ` Sudeep Holla
2018-05-17 9:13 ` Jonathan Cameron
2018-05-17 9:13 ` Jonathan Cameron
2018-05-09 17:07 ` [PATCH 8/8] firmware: arm_scmi: simplify exit path by returning on error Sudeep Holla
2018-05-09 17:07 ` Sudeep Holla
2018-05-17 9:14 ` Jonathan Cameron
2018-05-17 9:14 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180517094329.000002f1@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.