All of lore.kernel.org
 help / color / mirror / Atom feed
* [bug report] ath9k: Fix issue with MCS15
@ 2018-05-17 14:21 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2018-05-17 14:21 UTC (permalink / raw)
  To: c_manoha; +Cc: linux-wireless

Hello Sujith Manoharan,

The patch 6fcbe538be43: "ath9k: Fix issue with MCS15" from Nov 14,
2013, leads to the following static checker warning:

	drivers/net/wireless/ath/ath9k/ar9003_phy.c:836 ar9003_doubler_fix()
	warn: 'ah->hw_version.macVersion == 448' 'false' implies 'ah->hw_version.macVersion == 448' is 'false'

drivers/net/wireless/ath/ath9k/ar9003_phy.c
   834  static void ar9003_doubler_fix(struct ath_hw *ah)
   835  {
   836          if (AR_SREV_9300(ah) || AR_SREV_9580(ah) || AR_SREV_9550(ah)) {

The problem is that both AR_SREV_VERSION_9300 and AR_SREV_VERSION_9580
are 0x1c0 so the test for AR_SREV_9580() is duplicative.

   837                  REG_RMW(ah, AR_PHY_65NM_CH0_RXTX2,
   838                          1 << AR_PHY_65NM_CH0_RXTX2_SYNTHON_MASK_S |
   839                          1 << AR_PHY_65NM_CH0_RXTX2_SYNTHOVR_MASK_S, 0);
   840                  REG_RMW(ah, AR_PHY_65NM_CH1_RXTX2,
   841                          1 << AR_PHY_65NM_CH0_RXTX2_SYNTHON_MASK_S |
   842                          1 << AR_PHY_65NM_CH0_RXTX2_SYNTHOVR_MASK_S, 0);
   843                  REG_RMW(ah, AR_PHY_65NM_CH2_RXTX2,
   844                          1 << AR_PHY_65NM_CH0_RXTX2_SYNTHON_MASK_S |
   845                          1 << AR_PHY_65NM_CH0_RXTX2_SYNTHOVR_MASK_S, 0);
   846  
   847                  udelay(200);
   848  

regards,
dan carpenter

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2018-05-17 14:21 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-17 14:21 [bug report] ath9k: Fix issue with MCS15 Dan Carpenter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.