From: Tony Lindgren <tony@atomide.com>
To: Keerthy <j-keerthy@ti.com>
Cc: t-kristo@ti.com, linux-gpio@vger.kernel.org,
linus.walleij@linaro.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] pinctrl: pinctrl-single: Add functions to save and restore pinctrl context
Date: Thu, 17 May 2018 11:46:12 -0700 [thread overview]
Message-ID: <20180517184612.GM98604@atomide.com> (raw)
In-Reply-To: <1526532021-16387-1-git-send-email-j-keerthy@ti.com>
* Keerthy <j-keerthy@ti.com> [180517 04:42]:
> This adds a pair of context save/restore functions to save/restore the
> state of a set of pinctrl registers. The context is lost during rtc only
> suspend with ddr in self-refresh on am43xx. Currently the save/restore
> is being done unconditionally. This will be optimized later with a
> pdata-quirk function which will allow is to save/restore only when doing
> the rtc only mode with ddr in self refresh.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
>
> Changes in v2:
>
> * As this is needed only the in the suspend/resume path
> removed the cpu_pm notifier and added the save/restore in
> the suspend/resume calls.
> * Saving/Restoring unconditionally at the moment. This will
> be optimized later with the help of a pdata-quirk function.
Looks good to me:
Acked-by: Tony Lindgren <tony@atomide.com>
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] pinctrl: pinctrl-single: Add functions to save and restore pinctrl context
Date: Thu, 17 May 2018 11:46:12 -0700 [thread overview]
Message-ID: <20180517184612.GM98604@atomide.com> (raw)
In-Reply-To: <1526532021-16387-1-git-send-email-j-keerthy@ti.com>
* Keerthy <j-keerthy@ti.com> [180517 04:42]:
> This adds a pair of context save/restore functions to save/restore the
> state of a set of pinctrl registers. The context is lost during rtc only
> suspend with ddr in self-refresh on am43xx. Currently the save/restore
> is being done unconditionally. This will be optimized later with a
> pdata-quirk function which will allow is to save/restore only when doing
> the rtc only mode with ddr in self refresh.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
>
> Changes in v2:
>
> * As this is needed only the in the suspend/resume path
> removed the cpu_pm notifier and added the save/restore in
> the suspend/resume calls.
> * Saving/Restoring unconditionally at the moment. This will
> be optimized later with the help of a pdata-quirk function.
Looks good to me:
Acked-by: Tony Lindgren <tony@atomide.com>
next prev parent reply other threads:[~2018-05-17 18:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 4:40 [PATCH v2] pinctrl: pinctrl-single: Add functions to save and restore pinctrl context Keerthy
2018-05-17 4:40 ` Keerthy
2018-05-17 18:46 ` Tony Lindgren [this message]
2018-05-17 18:46 ` Tony Lindgren
2018-05-23 8:30 ` Linus Walleij
2018-05-23 8:30 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180517184612.GM98604@atomide.com \
--to=tony@atomide.com \
--cc=j-keerthy@ti.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.