From: Niklas Cassel <niklas.cassel@linaro.org>
To: Erik Stromdahl <erik.stromdahl@gmail.com>
Cc: johannes@sipsolutions.net, toke@toke.dk,
linux-wireless@vger.kernel.org, kvalo@qca.qualcomm.com,
ath10k@lists.infradead.org
Subject: Re: ath10k wake_tx_queue issues
Date: Fri, 18 May 2018 01:47:11 +0200 [thread overview]
Message-ID: <20180517234711.GA13270@localhost.localdomain> (raw)
In-Reply-To: <6b81aa2e-09a3-ae48-7626-8ceb33a2a6b5@gmail.com>
On Wed, May 16, 2018 at 07:28:21PM +0200, Erik Stromdahl wrote:
> Hello Niklas
>
> Quick question:
> Are you using my patch: "ath10k: add htt_tx num_pending window"?
Nope, but I definitely think that your patch should be merged,
since the current code can lock/unlock/lock a lot of times for
no good reason.
(I actually tried it, but I could still reproduce the bug with it.)
>
> I assume (from your logs below) that you are not...
>
Thanks a lot for you suggestions Erik!
Increasing max_num_pending might be a good idea (perhaps we will
get better thoughput in the SDIO case).
However, increasing either max_num_pending or
HTC_HOST_MAX_MSG_PER_TX_BUNDLE would probably just move the problem,
since it would still be possible for us to get hit by the same problem
again in the future.
I actually took Toke's suggestion and cooked up a patch:
https://marc.info/?l=linux-kernel&m=152659902128543&w=2
Kind regards,
Niklas
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Niklas Cassel <niklas.cassel@linaro.org>
To: Erik Stromdahl <erik.stromdahl@gmail.com>
Cc: johannes@sipsolutions.net, kvalo@qca.qualcomm.com, toke@toke.dk,
linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: ath10k wake_tx_queue issues
Date: Fri, 18 May 2018 01:47:11 +0200 [thread overview]
Message-ID: <20180517234711.GA13270@localhost.localdomain> (raw)
In-Reply-To: <6b81aa2e-09a3-ae48-7626-8ceb33a2a6b5@gmail.com>
On Wed, May 16, 2018 at 07:28:21PM +0200, Erik Stromdahl wrote:
> Hello Niklas
>
> Quick question:
> Are you using my patch: "ath10k: add htt_tx num_pending window"?
Nope, but I definitely think that your patch should be merged,
since the current code can lock/unlock/lock a lot of times for
no good reason.
(I actually tried it, but I could still reproduce the bug with it.)
>
> I assume (from your logs below) that you are not...
>
Thanks a lot for you suggestions Erik!
Increasing max_num_pending might be a good idea (perhaps we will
get better thoughput in the SDIO case).
However, increasing either max_num_pending or
HTC_HOST_MAX_MSG_PER_TX_BUNDLE would probably just move the problem,
since it would still be possible for us to get hit by the same problem
again in the future.
I actually took Toke's suggestion and cooked up a patch:
https://marc.info/?l=linux-kernel&m=152659902128543&w=2
Kind regards,
Niklas
next prev parent reply other threads:[~2018-05-17 23:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-15 13:45 ath10k wake_tx_queue issues Niklas Cassel
2018-05-15 13:45 ` Niklas Cassel
2018-05-15 13:50 ` Ben Greear
2018-05-15 13:50 ` Ben Greear
2018-05-15 14:13 ` Toke Høiland-Jørgensen
2018-05-15 14:13 ` Toke Høiland-Jørgensen
2018-05-15 20:31 ` Niklas Cassel
2018-05-15 20:31 ` Niklas Cassel
2018-05-16 5:54 ` Alexander Wetzel
2018-05-16 5:54 ` Alexander Wetzel
2018-05-16 9:16 ` Niklas Cassel
2018-05-16 9:16 ` Niklas Cassel
2018-05-16 9:22 ` Toke Høiland-Jørgensen
2018-05-16 9:22 ` Toke Høiland-Jørgensen
2018-05-16 17:28 ` Erik Stromdahl
2018-05-16 17:28 ` Erik Stromdahl
2018-05-17 23:47 ` Niklas Cassel [this message]
2018-05-17 23:47 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180517234711.GA13270@localhost.localdomain \
--to=niklas.cassel@linaro.org \
--cc=ath10k@lists.infradead.org \
--cc=erik.stromdahl@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.