From: Greg KH <greg@kroah.com>
To: Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp>
Cc: stable@vger.kernel.org, mtk.manpages@gmail.com, viro@zeniv.linux.org.uk
Subject: Re: Backport of pipe.c patch to 4.4.y that fixes LTP fcntl35 test error
Date: Fri, 18 May 2018 08:43:27 +0200 [thread overview]
Message-ID: <20180518064327.GA12930@kroah.com> (raw)
In-Reply-To: <000d01d3ee46$292bbcd0$7b833670$@toshiba.co.jp>
On Fri, May 18, 2018 at 10:18:42AM +0900, Daniel Sangorrin wrote:
> Oops sorry, I failed to write the subject. It should been something like the subject of this e-mail.
>
> > -----Original Message-----
> > From: stable-owner@vger.kernel.org [mailto:stable-owner@vger.kernel.org] On
> > Behalf Of Daniel Sangorrin
> > Sent: Friday, May 18, 2018 9:59 AM
> > To: stable@vger.kernel.org
> > Cc: mtk.manpages@gmail.com; viro@zeniv.linux.org.uk
> > Subject:
> >
> > Hello Greg,
> >
> > After running LTP with Fuego on the LTS kernel 4.4.y, there were
> > a few test cases failing that I thought needed some investigation.
> >
> > I reviewed the first one (fcntl35 and fcntl35_64) so far. According to the
> > comments on LTP's fcntl35.c file (by Xiao Yang <yangx.jy@cn.fujitsu.com>)
> > the bug tested by this test case was fixed by:
> > pipe: cap initial pipe capacity according to pipe-max-size
> > commit 086e774a57fba4695f14383c0818994c0b31da7c
> > Author: Michael Kerrisk (man-pages) <mtk.manpages@gmail.com>
> > Date: Tue Oct 11 13:53:43 2016 -0700
> >
> > I backported that patch (see next e-mail), tested again and confirmed that
> > the patch fixed the bug (or at least the error message in LTP's test).
> >
> > Before:
> > fcntl35.c:98: FAIL: an unprivileged user init the capacity of a pipe to 65536
> > unexpectedly, expected 4096
> > After:
> > fcntl35.c:101: PASS: an unprivileged user init the capacity of a pipe to 4096
> > successfully
Looks great, thanks, I've queued this up now.
greg k-h
prev parent reply other threads:[~2018-05-18 6:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-18 1:18 Backport of pipe.c patch to 4.4.y that fixes LTP fcntl35 test error Daniel Sangorrin
2018-05-18 6:43 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180518064327.GA12930@kroah.com \
--to=greg@kroah.com \
--cc=daniel.sangorrin@toshiba.co.jp \
--cc=mtk.manpages@gmail.com \
--cc=stable@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.