* [PATCH 0/2] Remove calls to empty arch_setup_pdev_archdata()
@ 2018-05-18 11:06 ` Geert Uytterhoeven
0 siblings, 0 replies; 12+ messages in thread
From: Geert Uytterhoeven @ 2018-05-18 11:06 UTC (permalink / raw)
To: Yoshinori Sato, Rich Felker
Cc: Jacopo Mondi, linux-sh, linux-renesas-soc, Geert Uytterhoeven
Hi,
Recently, a few calls to arch_setup_pdev_archdata() were added to the
ecovec and migor board files (copied from platform_device_register())?
However, SuperH doesn't implement arch_setup_pdev_archdata(), and falls
back to the default (empty) implementation. As this code is
board-specific, the calls can just be removed.
Thanks!
Geert Uytterhoeven (2):
sh: ecovec: Remove calls to empty arch_setup_pdev_archdata()
sh: migor: Remove calls to empty arch_setup_pdev_archdata()
arch/sh/boards/mach-ecovec24/setup.c | 2 --
arch/sh/boards/mach-migor/setup.c | 1 -
2 files changed, 3 deletions(-)
--
2.7.4
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 12+ messages in thread* [PATCH 1/2] media: arch: sh: ecovec: Remove calls to empty arch_setup_pdev_archdata()
2018-05-18 11:06 ` Geert Uytterhoeven
@ 2018-05-18 11:06 ` Geert Uytterhoeven
-1 siblings, 0 replies; 12+ messages in thread
From: Geert Uytterhoeven @ 2018-05-18 11:06 UTC (permalink / raw)
To: Yoshinori Sato, Rich Felker
Cc: Jacopo Mondi, linux-sh, linux-renesas-soc, Geert Uytterhoeven
SuperH doesn't implement arch_setup_pdev_archdata(), and falls back to
the default (empty) implementation. As this code is board-specific, the
calls can just be removed.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/sh/boards/mach-ecovec24/setup.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/sh/boards/mach-ecovec24/setup.c b/arch/sh/boards/mach-ecovec24/setup.c
index adc61d14172c63b8..dc9708227b0d58e8 100644
--- a/arch/sh/boards/mach-ecovec24/setup.c
+++ b/arch/sh/boards/mach-ecovec24/setup.c
@@ -1396,7 +1396,6 @@ static int __init arch_setup(void)
/* Initialize CEU platform devices separately to map memory first */
device_initialize(&ecovec_ceu_devices[0]->dev);
- arch_setup_pdev_archdata(ecovec_ceu_devices[0]);
dma_declare_coherent_memory(&ecovec_ceu_devices[0]->dev,
ceu0_dma_membase, ceu0_dma_membase,
ceu0_dma_membase +
@@ -1405,7 +1404,6 @@ static int __init arch_setup(void)
platform_device_add(ecovec_ceu_devices[0]);
device_initialize(&ecovec_ceu_devices[1]->dev);
- arch_setup_pdev_archdata(ecovec_ceu_devices[1]);
dma_declare_coherent_memory(&ecovec_ceu_devices[1]->dev,
ceu1_dma_membase, ceu1_dma_membase,
ceu1_dma_membase +
--
2.7.4
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 1/2] media: arch: sh: ecovec: Remove calls to empty arch_setup_pdev_archdata()
@ 2018-05-18 11:06 ` Geert Uytterhoeven
0 siblings, 0 replies; 12+ messages in thread
From: Geert Uytterhoeven @ 2018-05-18 11:06 UTC (permalink / raw)
To: Yoshinori Sato, Rich Felker
Cc: Jacopo Mondi, linux-sh, linux-renesas-soc, Geert Uytterhoeven
SuperH doesn't implement arch_setup_pdev_archdata(), and falls back to
the default (empty) implementation. As this code is board-specific, the
calls can just be removed.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/sh/boards/mach-ecovec24/setup.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/sh/boards/mach-ecovec24/setup.c b/arch/sh/boards/mach-ecovec24/setup.c
index adc61d14172c63b8..dc9708227b0d58e8 100644
--- a/arch/sh/boards/mach-ecovec24/setup.c
+++ b/arch/sh/boards/mach-ecovec24/setup.c
@@ -1396,7 +1396,6 @@ static int __init arch_setup(void)
/* Initialize CEU platform devices separately to map memory first */
device_initialize(&ecovec_ceu_devices[0]->dev);
- arch_setup_pdev_archdata(ecovec_ceu_devices[0]);
dma_declare_coherent_memory(&ecovec_ceu_devices[0]->dev,
ceu0_dma_membase, ceu0_dma_membase,
ceu0_dma_membase +
@@ -1405,7 +1404,6 @@ static int __init arch_setup(void)
platform_device_add(ecovec_ceu_devices[0]);
device_initialize(&ecovec_ceu_devices[1]->dev);
- arch_setup_pdev_archdata(ecovec_ceu_devices[1]);
dma_declare_coherent_memory(&ecovec_ceu_devices[1]->dev,
ceu1_dma_membase, ceu1_dma_membase,
ceu1_dma_membase +
--
2.7.4
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] media: arch: sh: ecovec: Remove calls to empty arch_setup_pdev_archdata()
2018-05-18 11:06 ` Geert Uytterhoeven
@ 2018-05-22 8:22 ` Simon Horman
-1 siblings, 0 replies; 12+ messages in thread
From: Simon Horman @ 2018-05-22 8:22 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Yoshinori Sato, Rich Felker, Jacopo Mondi, linux-sh,
linux-renesas-soc
On Fri, May 18, 2018 at 01:06:50PM +0200, Geert Uytterhoeven wrote:
> SuperH doesn't implement arch_setup_pdev_archdata(), and falls back to
> the default (empty) implementation. As this code is board-specific, the
> calls can just be removed.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] media: arch: sh: ecovec: Remove calls to empty arch_setup_pdev_archdata()
@ 2018-05-22 8:22 ` Simon Horman
0 siblings, 0 replies; 12+ messages in thread
From: Simon Horman @ 2018-05-22 8:22 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Yoshinori Sato, Rich Felker, Jacopo Mondi, linux-sh,
linux-renesas-soc
On Fri, May 18, 2018 at 01:06:50PM +0200, Geert Uytterhoeven wrote:
> SuperH doesn't implement arch_setup_pdev_archdata(), and falls back to
> the default (empty) implementation. As this code is board-specific, the
> calls can just be removed.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 2/2] media: arch: sh: migor: Remove calls to empty arch_setup_pdev_archdata()
2018-05-18 11:06 ` Geert Uytterhoeven
@ 2018-05-18 11:06 ` Geert Uytterhoeven
-1 siblings, 0 replies; 12+ messages in thread
From: Geert Uytterhoeven @ 2018-05-18 11:06 UTC (permalink / raw)
To: Yoshinori Sato, Rich Felker
Cc: Jacopo Mondi, linux-sh, linux-renesas-soc, Geert Uytterhoeven
SuperH doesn't implement arch_setup_pdev_archdata(), and falls back to
the default (empty) implementation. As this code is board-specific, the
call can just be removed.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/sh/boards/mach-migor/setup.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/sh/boards/mach-migor/setup.c b/arch/sh/boards/mach-migor/setup.c
index 271dfc260e8281f6..8cc09f3d03689e0d 100644
--- a/arch/sh/boards/mach-migor/setup.c
+++ b/arch/sh/boards/mach-migor/setup.c
@@ -603,7 +603,6 @@ static int __init migor_devices_setup(void)
/* Initialize CEU platform device separately to map memory first */
device_initialize(&migor_ceu_device.dev);
- arch_setup_pdev_archdata(&migor_ceu_device);
dma_declare_coherent_memory(&migor_ceu_device.dev,
ceu_dma_membase, ceu_dma_membase,
ceu_dma_membase + CEU_BUFFER_MEMORY_SIZE - 1,
--
2.7.4
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/2] media: arch: sh: migor: Remove calls to empty arch_setup_pdev_archdata()
@ 2018-05-18 11:06 ` Geert Uytterhoeven
0 siblings, 0 replies; 12+ messages in thread
From: Geert Uytterhoeven @ 2018-05-18 11:06 UTC (permalink / raw)
To: Yoshinori Sato, Rich Felker
Cc: Jacopo Mondi, linux-sh, linux-renesas-soc, Geert Uytterhoeven
SuperH doesn't implement arch_setup_pdev_archdata(), and falls back to
the default (empty) implementation. As this code is board-specific, the
call can just be removed.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/sh/boards/mach-migor/setup.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/sh/boards/mach-migor/setup.c b/arch/sh/boards/mach-migor/setup.c
index 271dfc260e8281f6..8cc09f3d03689e0d 100644
--- a/arch/sh/boards/mach-migor/setup.c
+++ b/arch/sh/boards/mach-migor/setup.c
@@ -603,7 +603,6 @@ static int __init migor_devices_setup(void)
/* Initialize CEU platform device separately to map memory first */
device_initialize(&migor_ceu_device.dev);
- arch_setup_pdev_archdata(&migor_ceu_device);
dma_declare_coherent_memory(&migor_ceu_device.dev,
ceu_dma_membase, ceu_dma_membase,
ceu_dma_membase + CEU_BUFFER_MEMORY_SIZE - 1,
--
2.7.4
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] media: arch: sh: migor: Remove calls to empty arch_setup_pdev_archdata()
2018-05-18 11:06 ` Geert Uytterhoeven
@ 2018-05-22 8:22 ` Simon Horman
-1 siblings, 0 replies; 12+ messages in thread
From: Simon Horman @ 2018-05-22 8:22 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Yoshinori Sato, Rich Felker, Jacopo Mondi, linux-sh,
linux-renesas-soc
On Fri, May 18, 2018 at 01:06:51PM +0200, Geert Uytterhoeven wrote:
> SuperH doesn't implement arch_setup_pdev_archdata(), and falls back to
> the default (empty) implementation. As this code is board-specific, the
> call can just be removed.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] media: arch: sh: migor: Remove calls to empty arch_setup_pdev_archdata()
@ 2018-05-22 8:22 ` Simon Horman
0 siblings, 0 replies; 12+ messages in thread
From: Simon Horman @ 2018-05-22 8:22 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Yoshinori Sato, Rich Felker, Jacopo Mondi, linux-sh,
linux-renesas-soc
On Fri, May 18, 2018 at 01:06:51PM +0200, Geert Uytterhoeven wrote:
> SuperH doesn't implement arch_setup_pdev_archdata(), and falls back to
> the default (empty) implementation. As this code is board-specific, the
> call can just be removed.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 0/2] Remove calls to empty arch_setup_pdev_archdata()
2018-05-18 11:06 ` Geert Uytterhoeven
@ 2018-05-18 11:52 ` jacopo mondi
-1 siblings, 0 replies; 12+ messages in thread
From: jacopo mondi @ 2018-05-18 11:52 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Yoshinori Sato, Rich Felker, Jacopo Mondi, linux-sh,
linux-renesas-soc
[-- Attachment #1: Type: text/plain, Size: 1170 bytes --]
Hi Geert,
On Fri, May 18, 2018 at 01:06:49PM +0200, Geert Uytterhoeven wrote:
> Hi,
>
> Recently, a few calls to arch_setup_pdev_archdata() were added to the
> ecovec and migor board files (copied from platform_device_register())?
I suspect that was me
>
> However, SuperH doesn't implement arch_setup_pdev_archdata(), and falls
> back to the default (empty) implementation. As this code is
> board-specific, the calls can just be removed.
Thanks for looking into that.
Acked-by: Jacopo Mondi <jacopo@jmondi.org>
Thanks
j
>
> Thanks!
>
> Geert Uytterhoeven (2):
> sh: ecovec: Remove calls to empty arch_setup_pdev_archdata()
> sh: migor: Remove calls to empty arch_setup_pdev_archdata()
>
> arch/sh/boards/mach-ecovec24/setup.c | 2 --
> arch/sh/boards/mach-migor/setup.c | 1 -
> 2 files changed, 3 deletions(-)
>
> --
> 2.7.4
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 0/2] Remove calls to empty arch_setup_pdev_archdata()
@ 2018-05-18 11:52 ` jacopo mondi
0 siblings, 0 replies; 12+ messages in thread
From: jacopo mondi @ 2018-05-18 11:52 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Yoshinori Sato, Rich Felker, Jacopo Mondi, linux-sh,
linux-renesas-soc
[-- Attachment #1: Type: text/plain, Size: 1170 bytes --]
Hi Geert,
On Fri, May 18, 2018 at 01:06:49PM +0200, Geert Uytterhoeven wrote:
> Hi,
>
> Recently, a few calls to arch_setup_pdev_archdata() were added to the
> ecovec and migor board files (copied from platform_device_register())?
I suspect that was me
>
> However, SuperH doesn't implement arch_setup_pdev_archdata(), and falls
> back to the default (empty) implementation. As this code is
> board-specific, the calls can just be removed.
Thanks for looking into that.
Acked-by: Jacopo Mondi <jacopo@jmondi.org>
Thanks
j
>
> Thanks!
>
> Geert Uytterhoeven (2):
> sh: ecovec: Remove calls to empty arch_setup_pdev_archdata()
> sh: migor: Remove calls to empty arch_setup_pdev_archdata()
>
> arch/sh/boards/mach-ecovec24/setup.c | 2 --
> arch/sh/boards/mach-migor/setup.c | 1 -
> 2 files changed, 3 deletions(-)
>
> --
> 2.7.4
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread