From: Tony Lindgren <tony@atomide.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Nishanth Menon <nm@ti.com>, Tero Kristo <t-kristo@ti.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Marcel Partap <mpartap@gmx.net>, Dave Gerlach <d-gerlach@ti.com>,
Keerthy <j-keerthy@ti.com>, Merlijn Wajer <merlijn@wizzup.org>,
Sebastian Reichel <sre@kernel.org>,
Kalle Valo <kvalo@codeaurora.org>, NeKit <nekit1000@gmail.com>,
Eyal Reizer <eyalr@ti.com>, Ash Charles <ash@gumstix.com>,
Michael Scott <hashcode0f@gmail.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/4] omap4-droid4: Use software debounce for gpio-keys
Date: Fri, 18 May 2018 07:32:59 -0700 [thread overview]
Message-ID: <20180518143259.GW98604@atomide.com> (raw)
In-Reply-To: <20180518072109.GA31304@amd>
* Pavel Machek <pavel@ucw.cz> [180518 07:23]:
> BTW, did you notice that debouncing is wrong on most of the keyboard?
> If you double click a key (most will do, for example "J") it will fail
> to recognize second release and instead of expected "jj", you get
> autorepeat ("jjjjjjjjjjjjjjjjjjjjjj...").
Hmm OK I have not seen that one.
> Ok, I guess main keyboard is not on GPIO...
No it's using omap4-keypad.c.
> > @@ -128,6 +128,7 @@
> > gpios = <&gpio5 26 GPIO_ACTIVE_LOW>; /* gpio154 */
> > linux,code = <KEY_VOLUMEDOWN>;
> > linux,can-disable;
> > + debounce-interval = <10>;
>
> I'd say this subtlety is worth a comment.
Good idea, I'll add a comment "Value above 7.95ms for no GPIO hardware
debounce". I'll do it also for duovero.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] omap4-droid4: Use software debounce for gpio-keys
Date: Fri, 18 May 2018 07:32:59 -0700 [thread overview]
Message-ID: <20180518143259.GW98604@atomide.com> (raw)
In-Reply-To: <20180518072109.GA31304@amd>
* Pavel Machek <pavel@ucw.cz> [180518 07:23]:
> BTW, did you notice that debouncing is wrong on most of the keyboard?
> If you double click a key (most will do, for example "J") it will fail
> to recognize second release and instead of expected "jj", you get
> autorepeat ("jjjjjjjjjjjjjjjjjjjjjj...").
Hmm OK I have not seen that one.
> Ok, I guess main keyboard is not on GPIO...
No it's using omap4-keypad.c.
> > @@ -128,6 +128,7 @@
> > gpios = <&gpio5 26 GPIO_ACTIVE_LOW>; /* gpio154 */
> > linux,code = <KEY_VOLUMEDOWN>;
> > linux,can-disable;
> > + debounce-interval = <10>;
>
> I'd say this subtlety is worth a comment.
Good idea, I'll add a comment "Value above 7.95ms for no GPIO hardware
debounce". I'll do it also for duovero.
Regards,
Tony
next prev parent reply other threads:[~2018-05-18 14:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 23:35 [PATCH 0/4] Correct wlcore irqs for PM improvments for omap4 boards Tony Lindgren
2018-05-17 23:35 ` Tony Lindgren
2018-05-17 23:35 ` [PATCH 1/4] ARM: OMAP2+: Make sure LOGICRETSTATE bits are not cleared Tony Lindgren
2018-05-17 23:35 ` Tony Lindgren
2018-05-17 23:35 ` [PATCH 2/4] ARM: dts: Fix omap l4per idling with wlcore edge sensitive interrupt Tony Lindgren
2018-05-17 23:35 ` Tony Lindgren
2018-05-17 23:35 ` [PATCH 3/4] ARM: dts: Configure duovero for to allow core retention during idle Tony Lindgren
2018-05-17 23:35 ` Tony Lindgren
2018-05-17 23:35 ` [PATCH 4/4] omap4-droid4: Use software debounce for gpio-keys Tony Lindgren
2018-05-17 23:35 ` Tony Lindgren
2018-05-18 7:21 ` Pavel Machek
2018-05-18 7:21 ` Pavel Machek
2018-05-18 14:32 ` Tony Lindgren [this message]
2018-05-18 14:32 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180518143259.GW98604@atomide.com \
--to=tony@atomide.com \
--cc=ash@gumstix.com \
--cc=d-gerlach@ti.com \
--cc=eyalr@ti.com \
--cc=grygorii.strashko@ti.com \
--cc=hashcode0f@gmail.com \
--cc=j-keerthy@ti.com \
--cc=kvalo@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=merlijn@wizzup.org \
--cc=mpartap@gmx.net \
--cc=nekit1000@gmail.com \
--cc=nm@ti.com \
--cc=pavel@ucw.cz \
--cc=sre@kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.